Received-SPF: pass (google.com: domain of linux-kernel+bounces-181483-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240516090541.4164270-2-ardb+git@google.com> <FBF468D5-18D6-4D29-B6A2-83A0A1998A05@akamai.com>
 <202405161142.A62A23A9@keescook>
In-Reply-To: <202405161142.A62A23A9@keescook>
From: Ard Biesheuvel <ardb@kernel.org>
Date: Thu, 16 May 2024 20:47:27 +0200
Message-ID: <CAMj1kXEAqKTaXD8o3bM=1u3COG=CYUp7P83L6segM4dKYoDszg@mail.gmail.com>
Subject: Re: [PATCH] x86/efistub: Omit physical KASLR when memory reservations exist
To: Kees Cook <keescook@chromium.org>
Cc: "Chaney, Ben" <bchaney@akamai.com>, Ard Biesheuvel <ardb+git@google.com>, 
	"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>, 
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "x86@kernel.org" <x86@kernel.org>, 
	"stable@vger.kernel.org" <stable@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"

On Thu, 16 May 2024 at 20:45, Kees Cook <keescook@chromium.org> wrote:
>
> On Thu, May 16, 2024 at 05:29:11PM +0000, Chaney, Ben wrote:
> > > +static efi_status_t parse_options(const char *cmdline)
> > > +{
> > > + static const char opts[][14] = {
> > > + "mem=", "memmap=", "efi_fake_mem=", "hugepages="
> > > + };
> > > +
> >
> > I think we probably want to include both crashkernel and pstore as arguments that can disable this randomization.
>
> The carve-outs that pstore uses should already appear in the physical
> memory mapping that EFI has. (i.e. those things get listed in e820 as
> non-RAM, etc)
>
> I don't know anything about crashkernel, but if we really do have a lot
> of these, we likely need to find a way to express them to EFI...
>

Perhaps. But the fact that the current KASLR code ignores it entirely
suggests that this has not been a problem up to this point.