Received-SPF: pass (google.com: domain of linux-kernel+bounces-181484-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 16 May 2024 20:49:02 +0200
From: Michael Grzeschik <mgr@pengutronix.de>
To: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
Cc: Eric Van Hensbergen <ericvh@kernel.org>,
	Latchesar Ionkov <lucho@ionkov.net>,
	Dominique Martinet <asmadeus@codewreck.org>,
	Christian Schoenebeck <linux_oss@crudebyte.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	v9fs@lists.linux.dev, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	kernel@pengutronix.de
Subject: Re: [PATCH v4 2/3] net/9p/usbg: Add new usb gadget function transport
Message-ID: <ZkZVHoHcdoNF6T2-@pengutronix.de>
References: <20240116-ml-topic-u9p-v4-0-722ed28b0ade@pengutronix.de>
 <20240116-ml-topic-u9p-v4-2-722ed28b0ade@pengutronix.de>
 <c78c9e88-bd53-4ae5-8f78-d8b1c468a5cd@collabora.com>
 <Zj3y04btf16BGZAJ@pengutronix.de>
 <2f36e766-054c-4001-addf-fe388916d858@collabora.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="8+72CV5QLt3FWqM3"
Content-Disposition: inline
In-Reply-To: <2f36e766-054c-4001-addf-fe388916d858@collabora.com>


--8+72CV5QLt3FWqM3
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi

On Fri, May 10, 2024 at 04:11:27PM +0200, Andrzej Pietrasiewicz wrote:
>W dniu 10.05.2024 o=A012:11, Michael Grzeschik pisze:
>>On Fri, May 10, 2024 at 11:25:47AM +0200, Andrzej Pietrasiewicz wrote:
>>>Hi Michael,
>>>
>>>W dniu 30.04.2024 o=A001:33, Michael Grzeschik pisze:
>>>>Add the new gadget function for 9pfs transport. This function is
>>>>defining an simple 9pfs transport interface that consists of one in and
>>>>one out endpoint. The endpoints transmit and receive the 9pfs protocol
>>>>payload when mounting a 9p filesystem over usb.
>>>>
>>>>Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
>>>>
>>>>---
>>>>v3 -> v4:
>>>>=A0 - implemented conn_cancel
>>>
>>>I tried this scenario:
>>>
>>>1) run all the components and have 9pfs up and running
>>>2) stop the forwarder
>>>3) umount -f at the gadget side - this indeed succeeds now in v4
>>>4) start the forwarder again
>>>5) mount at the gadget side - this hangs.
>>>
>>>Did this scenario work for you?
>>
>>I actually tested this exact scenario. So this is
>>suprising. I will try this again just to be sure
>>that I did send the latest version.
>>
>>My latest testsetup included the dummy_hcd. Did you test on real hardware?
>
>Yes, I did.

I just also tested this again on real hardware. With the imx6 chipidea
udc I indeed see that this is stuck after the first round of mount and
remount. With the musb core on the beaglebone this seems to be fine.

While debugging this I also ran into some shutdown issues and lockdep
issues I see because the complete handler is possible to be resumed
immedeatly on musb, which is odd. However I fixed/fix them and send an
v5 afterwards.

Regarding the hang on the imx6, which hardware did you test this on?

Michael

--=20
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

--8+72CV5QLt3FWqM3
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEElXvEUs6VPX6mDPT8C+njFXoeLGQFAmZGVRsACgkQC+njFXoe
LGRgFw//WscWMXZFcbFLW4HiBLc2QmGtJZP2s/7F9Evy6G7D1trQoFPBP9TimGPI
/Hh6cbdJOtcUeg62SdHx2WWwPEdC5S4a/WDxAGmWmmpJsvKnHORq+auPWBdG6Lnb
/Q93NqZKlSO9eByMWSigLlxCNEcRgpdKR2lePU5zF8leavY2iS2sVB2eAAFNYURS
K3WiL/PGjuJ6eWUUfpSug/zMwDmrZHlX91zraeDcicjVrDFUuoz4/AxtWIsM6xM8
6RBcsQg1kqMIeUrbynqzUe997CckffDAoQBrfizydTKqFGRwt4Ofv+m0KFmqBhAl
1g332cvvJRGy3R4B9lIWWz99at67nF7eC/Fb9FHYG7e+Gf50rpCnP8RWV8xHycFP
SlKSDlqgCD9shSBmPWpJYbOTEFwrGbCVjew1SOgkMklI+heQDi6QJxsK/WGKO9Sq
xD6LxCogW3qrCrBru7Q6lkaUDTwaF6ol/DNnAotsCygHI9lye+gdJptJbo4jnDUv
AsbiBzU6vxx6D9vw2LhaNS8MHRNzChpjo5hAWu11jdhFQnukqgvscfAPc0I4A31F
Qgw/p2dB8sAPH21CNz3Y6eipXiDwKv2tvm/jOClgDw7bNU5BC6xDGUFlKzfSg7H4
tungGeFatDe+7SUKh0lJOOnGqYnhVjG3bbB5eOUbsAvYQSCW8JQ=
=WIQ9
-----END PGP SIGNATURE-----

--8+72CV5QLt3FWqM3--