Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp500378lqo; Thu, 16 May 2024 12:17:55 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWeiHYXPVRe3HB2uTP2Z9qbwLRYmjwffZHnL6vTS4C/3aitMYo+Q/8eIifP5Ph1w+0o3tfhteqWSCnv4xC4CZs7GJTrhVH+St35LGXReQ== X-Google-Smtp-Source: AGHT+IG2SF/7p9ldzn241BIp2LhT6C/WThEaZ3HKltNbZnAjmIIfBUPf2mXCn2H7fWtZFVlkH5ZQ X-Received: by 2002:a17:902:8a95:b0:1e5:10e5:b66e with SMTP id d9443c01a7336-1ef43d29924mr172651465ad.27.1715887074723; Thu, 16 May 2024 12:17:54 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715887074; cv=pass; d=google.com; s=arc-20160816; b=z3WSozDb3AMPebUtT08pZlT1RCHSGascbbq8nn/Pk2e6S2w4raCcj+YwNiGhqa3Jqr 4oaU4WvbCGp/Pj+RIqiknyrF+GyAM8bxbI4yXWQZ9XdP3Z7v40V/H2mYRmcGNucp9Dhi Y5b+W9GfeLwpQvJGLw21wPF6hBSqg8XMp6KBcGJBPl9DesjwjR9T5Vk2Vak5tBEXtsTO l1y85Ab3Isg1ltCN2+efO6Ly7MiobeGvM+LsjTJr3fMVMiWR3AH3XMPCBshP4J5CMqvn 4JRol2gDlBjouIAqWCGVINbt0XE3tgVnqCN6fW3wlniWoHcQPLYvd6frQ8G3FtzG3diO ubzQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=vdVstfTJWRr25JayXKawfEg+DKVNWLVsJwrCAWHBcOA=; fh=pwDlYF4xT2WdryFdQtOWhH8bE/48V+oLoniO13NRhkg=; b=0lKNz1kq2s7BEYu8/fyn+DuEO0gJSBaxJ2XdtK+YAeMSHWOHHrtWMXUh1gPoxv7ez5 M8gyXjD7MqVfM6s3QNRp3dZE5HKj6hSUekm1vlO0zV/pHM9N/nbUxQHa7+W66K/mzINZ jDbGeSc3/FCd591nK5KUNYRyB/R6GA1jTP5IwoaGbYt9kX/9ReYYQMCLzF7SdKBZlakg D2tFkZDZN4mar2yV7FrIWXMregstsHF3p+lXlwYnS6KIIBoCbMr5gobNTth2is+8vQ6N sKWYW67ikwMOEMzHkMwrorYgnZdHs8hNpgWuaIg8kNpjTaPV6jHHwN1w5PUxkD4uWiq0 n8HA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=bahG2UVJ; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-181519-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-181519-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id d9443c01a7336-1ef0c038fc4si159429715ad.339.2024.05.16.12.17.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 May 2024 12:17:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-181519-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=bahG2UVJ; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-181519-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-181519-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id B095F2882FD for ; Thu, 16 May 2024 19:12:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6C80F15990C; Thu, 16 May 2024 19:07:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bahG2UVJ" Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41672158D99; Thu, 16 May 2024 19:07:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715886468; cv=none; b=I6OUnz5XAWaAEBCNonPd1X6SahW5MR9vpaLhwTFuC+iNHTYv083CuwZ2g3BUvjhDdULcgHxMc7nvfDK4YvKXooy9fAXb6UlvmBO9jX1hiP9u4+Yc4l3xr8OfQSEZCBJ/A/NgquzTnaZTNfOgCEAHTmjzLKC8QygmNiHcCmdU23c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715886468; c=relaxed/simple; bh=vdVstfTJWRr25JayXKawfEg+DKVNWLVsJwrCAWHBcOA=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=FAc3L1mpoIu8pdOx1Ss2CBG8RFaqUz5XQu6FHrXMqHskWLtflz31Jc2r4bU4hkx+tGV+sVTO94ZqWcx6i5Tt6KD+5N9GiINLbKBcw5rvXsgWLWTp2HxGi7kZJQdYsKyW/yxqnBxgexUcYNrE57h4MVhbLog3wx26iKPboxKcD3U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bahG2UVJ; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-6f44dd41a5cso616940b3a.0; Thu, 16 May 2024 12:07:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715886465; x=1716491265; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vdVstfTJWRr25JayXKawfEg+DKVNWLVsJwrCAWHBcOA=; b=bahG2UVJCKX+3QRk3oG2AYqTxI0QSQ2+XGfGkCUkzc9KxIATJ3iHcv+D1f0Mh/8aAM bkqyavgGVwThMSKTTU4uuOebbuvp32rGIilN1TGan10uEbf3FOATWm1Dpc3vFZXIlLHN utqaaMUnmluVq7puXz9e8cFrAe+UZpEvSUtRcI7ZOue8wIiR9L3E7TlkqJ0g/4p7YmIP +W94DvX1MsImlKwWwNVRMAGJZWw8tYjdyx6lTJHKZjuWmvxYx7RT/YIEocd7YFl+nBPW tT0g9JQbDfcwQBL3B1PBLAeaccBHHWp0zNoC0wQwomZhZl4dhshsJD9uMABim5vhoulg fHTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715886465; x=1716491265; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vdVstfTJWRr25JayXKawfEg+DKVNWLVsJwrCAWHBcOA=; b=XusfDbOwq/kFNmasErAVdMxlYVzFuRxZ/8INMPs8i3+xwjqRBbd7pU4CjQcg7AW45I OxdmgZE3I8kaNqARRYaUlWK7vxYKObk1LICPkfjmBU7qY5tfPKllxLqA2arVY0U1Wy1J 3J0lJDbjsMKjxR1mZzfXKRsjvcHQaFVMkRpji2k6fMpW8mdHmlcdINsNnfFgvU6usRj1 dWqYV0Hm0fj3PWSWUoQncTcwFSzqX5NrlQoagdo+BNwX+QCqj2Q9CIB3kPW5SqB5NPoT x0D23V7oFX4LUDHAgX0iIIhlYAF3ejTAXZbhHjYCCsF7dbblKy8TEgMNiUtGU7rxrltp HP7g== X-Forwarded-Encrypted: i=1; AJvYcCVNE8wOpX/qc8ydb/k3w6A0vs5MCmatt9MBXq6WoJQ2hYBoWFZM+Kxv69efkgDmtwdJwIXxkv30JI9zAMlDMR+J6GSRlzihsJzC1Yx71WPaqXFAwJEImMNpHFWk0M/97QRawPFt/BDuiZTT/Vn6+Hl4LzYW79AWaPIG3d9c9QMe8Q== X-Gm-Message-State: AOJu0Yyp9P7W+Q1jFvzAtcuci2CC5OMss2zgNbLhO2pzpOaz42VC3hkq wLbRZeyvXqLwfLacIdj/w0QxuGFfvhHUEMncakUWSj4YwZ2EqdrKtbLiCa11cAuVVt4OBIOuFON nM1z3n4IijSpGR1F0QjmxIEf7cTE= X-Received: by 2002:a05:6a20:9498:b0:1af:c5b9:273b with SMTP id adf61e73a8af0-1afde1d824cmr19019205637.54.1715886465298; Thu, 16 May 2024 12:07:45 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240515125342.1069999-1-haakon.bugge@oracle.com> <20240515125342.1069999-4-haakon.bugge@oracle.com> <82bf9e5f-b798-4d29-8473-c074a34f15b0@linux.dev> <236B9732-8264-454C-94BF-7C9D491D3A37@oracle.com> In-Reply-To: <236B9732-8264-454C-94BF-7C9D491D3A37@oracle.com> From: Greg Sword Date: Fri, 17 May 2024 03:07:34 +0800 Message-ID: Subject: Re: [PATCH v2 3/6] RDMA/cma: Brute force GFP_NOIO To: Haakon Bugge Cc: Zhu Yanjun , OFED mailing list , open list , netdev , "rds-devel@oss.oracle.com" , Jason Gunthorpe , Leon Romanovsky , Saeed Mahameed , Tariq Toukan , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Tejun Heo , Lai Jiangshan , Allison Henderson , Manjunath Patil , Mark Zhang , Chuck Lever III , Shiraz Saleem , Yang Li Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, May 16, 2024 at 11:54=E2=80=AFPM Haakon Bugge wrote: > > Hi Yanjun, > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree= /Documentation/process/maintainer-netdev.rst?h=3Dv6.9#n376 > > > > " > > Netdev has a convention for ordering local variables in functions. > > Order the variable declaration lines longest to shortest, e.g.:: > > "Infiniband subsystem" !=3D netdev, right? All kernel subsystems should follow this rule, including the network and rdma subsystems > > > Thxs, H=C3=A5kon >