Received-SPF: pass (google.com: domain of linux-kernel+bounces-181422-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 16 May 2024 19:53:21 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Frederic Weisbecker <frederic@kernel.org>
Cc: Yun Levi <ppbuk5246@gmail.com>, Joel Fernandes <joel@joelfernandes.org>,
	Vineeth Pillai <vineeth@bitbyteword.org>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	anna-maria@linutronix.de, mingo@kernel.org, tglx@linutronix.de,
	Markus.Elfring@web.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] time/tick-sched: idle load balancing when nohz_full
 cpu becomes idle.
Message-ID: <20240516175321.GN22557@noisy.programming.kicks-ass.net>
References: <CAM7-yPRHp3tiZjuBTesdRQoU8WJNg1scon_txS_6R-pZq9MXHw@mail.gmail.com>
 <20240516084911.GF22557@noisy.programming.kicks-ass.net>
 <ZkXtHv+fHUD2+lFJ@lothringen>
 <CAM7-yPTSq0CSmRsTpeXwzhFk77gfwUK_LZKnbgo4NPk5zPCaAg@mail.gmail.com>
 <20240516140003.GJ22557@noisy.programming.kicks-ass.net>
 <ZkYW48dTX2FH5NaD@lothringen>
 <20240516144504.GL22557@noisy.programming.kicks-ass.net>
 <ZkYgG9KYMpUPeJsM@lothringen>
 <20240516151953.GM22557@noisy.programming.kicks-ass.net>
 <ZkYnKAd1Qy+yvjDY@lothringen>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZkYnKAd1Qy+yvjDY@lothringen>

On Thu, May 16, 2024 at 05:32:56PM +0200, Frederic Weisbecker wrote:
> On Thu, May 16, 2024 at 05:19:53PM +0200, Peter Zijlstra wrote:

> > Yes, but stronger, as long as the CPU is part of a load-balance domain,
> > it must not disable the tick while running anything.
> > 
> > that is, NOHZ_FULL must not become active unless it's running on a
> > single CPU partition.
> 
> I like the idea but I'm afraid to introduce regressions while doing so,
> with people currently using nohz_full without proper partionning...

There is no regression, if this is possible today it is utterly broken.

This should never have been possible.