Received-SPF: pass (google.com: domain of linux-kernel+bounces-181595-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 16 May 2024 16:34:34 -0500
From: Ira Weiny <ira.weiny@intel.com>
To: "Fabio M. De Francesco" <fabio.m.de.francesco@linux.intel.com>, "Davidlohr
 Bueso" <dave@stgolabs.net>, Jonathan Cameron <jonathan.cameron@huawei.com>,
	Dave Jiang <dave.jiang@intel.com>, Alison Schofield
	<alison.schofield@intel.com>, Vishal Verma <vishal.l.verma@intel.com>, "Ira
 Weiny" <ira.weiny@intel.com>, Dan Williams <dan.j.williams@intel.com>,
	<linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>
CC: "Fabio M. De Francesco" <fabio.m.de.francesco@linux.intel.com>
Subject: Re: [PATCH v2] cxl/events: Use a common struct for DRAM and General
 Media events
Message-ID: <66467bea7cc40_8c79294d4@iweiny-mobl.notmuch>
References: <20240516102116.3512377-1-fabio.m.de.francesco@linux.intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240516102116.3512377-1-fabio.m.de.francesco@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?cuT6wT7Ao0p5b/Xn1BmfLnWi0TVkuXrkBgQuAubG77/GMHrY9CKv4zJJCDFF?=
 =?us-ascii?Q?xmnfTyXD5/IZz5bVmqhn/CaLdvpIT/jztZLeB1EirLliFkclRu9SL/Nf8Ei/?=
 =?us-ascii?Q?D3Gk0+s2hDkZdm6gfOHjJtIioPV4qxVZiKTWZadueL4aQn12XhclA7/xOWBz?=
 =?us-ascii?Q?gK4sAlrNFxlrZGVRtC54Rc7huuIhKC1sTPnk0RrGgJDeRYnCysUChWTE1CYK?=
 =?us-ascii?Q?ZSUgDqLy2DHzglJE3rck2KSfwGwwHO/nJuSX9MpgJE9gX6lO6hhjPcAd5UQ0?=
 =?us-ascii?Q?VNmetAoLI4NAr+0mIVG0w1RT4HXMSdAStIrYkS4yP9fFrwLSQe7yfZhNLJDp?=
 =?us-ascii?Q?wkVPQ6smaojyiNwMqCvfh8merlEVZoY8CWmgcU3FvU8LkHonStDIT6o80E8q?=
 =?us-ascii?Q?h9yVIf7IIfvhTJyO+XD2T+HjbT6WDxuHsOgq1871F+4fxflGRLS9SPJSbJD1?=
 =?us-ascii?Q?Q9wIyDlqAB6czBSc5S65WsSmNL47kVf9cofCQ+SsIgl8UkHE63FedL2+tpZs?=
 =?us-ascii?Q?2IgDCQ8KJWuEFhZsYsjCHZBGCl9mhJpWFMwlH8ctjuCXPvziDPMU3d1SP7c8?=
 =?us-ascii?Q?I0qwsKsKgX8VLu5gZIZeGw1e99BZfL5SmtD+J1ARMsHUzt/UDvpjcNOyYuJ/?=
 =?us-ascii?Q?BEl5GuodAnovsDG/V3J7ENR4lW2+xtX5qXyDSznvpripHrHluwRUYTuPZyP2?=
 =?us-ascii?Q?npi9r9yE39AVfDu0JgEaEv+NexNU3xrvb9BLF7Fu0dKpgo7Th7HbWHyczlWl?=
 =?us-ascii?Q?aC74RCf5vT6Dy5SdveOZXBZNdNUAqhJ2TP/PEWsJjljDLDzFLSv7YvzVs0/D?=
 =?us-ascii?Q?AjyHP7Kt2rZtCaBOVQVjcsgtMVNPeFUJeyLJkAiYRLQvRjagKK1MltYgMjNV?=
 =?us-ascii?Q?rhVlYvdBW0a+9DKxEtT9JZc5mnwZEL6MMJh5m/9mqcj9C5BIxfuNHBQSFwz9?=
 =?us-ascii?Q?D9yx7p2L0uIt12WnLiSB/e51YmoCWC+ekWotXPIDVUlDfXWMzzJh4AIkTqSa?=
 =?us-ascii?Q?aS01exn0kroWFcIS7eRSZtdM3zUOSgi/sJiZmlzUhLEr5D7FRjKcmDmiB+ZZ?=
 =?us-ascii?Q?fYBy6v9GJWoQNj47mag0lUCIHICoOvPmum1qRzyJdwTDUEq9PKfwl5Oa3ag/?=
 =?us-ascii?Q?NG7OT8zEOiVPXhEB2i4sQ2qw+nj3cLTtBf71fastzcm8G4yctfy9oUj+4hKz?=
 =?us-ascii?Q?Au1VjQjcv/qeG19vyQR0S6TcOYit6foKWOYaZ5c5tmL2UXHBDX7CPaDhNWQR?=
 =?us-ascii?Q?GBnG4YP1LToyN7M9OlGZE2YD0jLXZUtdgj1bVQ+fhUPl/qQpn55742s9e5+r?=
 =?us-ascii?Q?m1UDeNBS85VN1Tl3+VzWpLngac+8HfMutpGrIzdMNwaTXXqMRrNPvyrgbQbs?=
 =?us-ascii?Q?tLG+2YeQHsiY5qwTm2i2Ljagc5wc35PkqqQ1YdzWmnkROnmpmsPEdyTKieA4?=
 =?us-ascii?Q?AKl7ZsNjnOdReq/pQ9EHvkAvEqW+OulXCQLj8Xev6JPve1FlXsNeDPQEPRK9?=
 =?us-ascii?Q?YVPLNPy8ogZTwL2JKGrwVbymE7+745cCcgCtgd6V42X8aLMgZh3+yh5EbOG7?=
 =?us-ascii?Q?pibEPK03HGgjB+Ogy9dhgxMjhh4cHr0SBD2vNIkiBXy6rF630R404lgA1mxb?=
 =?us-ascii?Q?Az/QDAhqVnpjuN9GtbQbHPQ=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: afef4e29-8e5a-40aa-8660-08dc75effc8a
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2024 21:34:37.5813
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RMK4+uUbwq4pgD8XsajG4nGfZQ/iuLziTyC21BAgTqhI+ndKdXK0j2oqIVTDNnzJ4uJDhUJtaq1PrzQGlWicaA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6557
X-OriginatorOrg: intel.com

Fabio M. De Francesco wrote:
> cxl_event_common was a poor naming choice and caused confusion with the
> existing Common Event Record.
> 
> Use cxl_event_media as a common structure to record information about DRAM
> and General Media events because it simplifies handling the two events.
> 
> Suggested-by: Dan Williams <dan.j.williams@intel.com>
> Fixes: 6aec00139d3a ("cxl/core: Add region info to cxl_general_media and cxl_dram events")
> Signed-off-by: Fabio M. De Francesco <fabio.m.de.francesco@linux.intel.com>
> ---
> 
> Changes for v2:
> 	- Extend the commit message (Alison);
> 	- Add a "Fixes" tag (Alison, thanks).
> 
>  drivers/cxl/core/mbox.c      |  6 ++--
>  drivers/cxl/core/trace.h     |  4 +--
>  include/linux/cxl-event.h    | 70 +++++++++++++++---------------------
>  tools/testing/cxl/test/mem.c |  4 +--
>  4 files changed, 36 insertions(+), 48 deletions(-)

Still not convinced this is worth the churn.
Ira

> 
> diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
> index 2626f3fff201..ad4d7b0f7f4d 100644
> --- a/drivers/cxl/core/mbox.c
> +++ b/drivers/cxl/core/mbox.c
> @@ -875,16 +875,16 @@ void cxl_event_trace_record(const struct cxl_memdev *cxlmd,
>  		guard(rwsem_read)(&cxl_region_rwsem);
>  		guard(rwsem_read)(&cxl_dpa_rwsem);
>  
> -		dpa = le64_to_cpu(evt->common.phys_addr) & CXL_DPA_MASK;
> +		dpa = le64_to_cpu(evt->media_common.phys_addr) & CXL_DPA_MASK;
>  		cxlr = cxl_dpa_to_region(cxlmd, dpa);
>  		if (cxlr)
>  			hpa = cxl_trace_hpa(cxlr, cxlmd, dpa);
>  
>  		if (event_type == CXL_CPER_EVENT_GEN_MEDIA)
>  			trace_cxl_general_media(cxlmd, type, cxlr, hpa,
> -						&evt->gen_media);
> +						&evt->media_general);
>  		else if (event_type == CXL_CPER_EVENT_DRAM)
> -			trace_cxl_dram(cxlmd, type, cxlr, hpa, &evt->dram);
> +			trace_cxl_dram(cxlmd, type, cxlr, hpa, &evt->media_dram);
>  	}
>  }
>  EXPORT_SYMBOL_NS_GPL(cxl_event_trace_record, CXL);
> diff --git a/drivers/cxl/core/trace.h b/drivers/cxl/core/trace.h
> index 07a0394b1d99..2c7293761bb2 100644
> --- a/drivers/cxl/core/trace.h
> +++ b/drivers/cxl/core/trace.h
> @@ -316,7 +316,7 @@ TRACE_EVENT(cxl_generic_event,
>  TRACE_EVENT(cxl_general_media,
>  
>  	TP_PROTO(const struct cxl_memdev *cxlmd, enum cxl_event_log_type log,
> -		 struct cxl_region *cxlr, u64 hpa, struct cxl_event_gen_media *rec),
> +		 struct cxl_region *cxlr, u64 hpa, struct cxl_event_media *rec),
>  
>  	TP_ARGS(cxlmd, log, cxlr, hpa, rec),
>  
> @@ -413,7 +413,7 @@ TRACE_EVENT(cxl_general_media,
>  TRACE_EVENT(cxl_dram,
>  
>  	TP_PROTO(const struct cxl_memdev *cxlmd, enum cxl_event_log_type log,
> -		 struct cxl_region *cxlr, u64 hpa, struct cxl_event_dram *rec),
> +		 struct cxl_region *cxlr, u64 hpa, struct cxl_event_media *rec),
>  
>  	TP_ARGS(cxlmd, log, cxlr, hpa, rec),
>  
> diff --git a/include/linux/cxl-event.h b/include/linux/cxl-event.h
> index 60b25020281f..e417556cc120 100644
> --- a/include/linux/cxl-event.h
> +++ b/include/linux/cxl-event.h
> @@ -32,41 +32,38 @@ struct cxl_event_generic {
>   * CXL rev 3.0 Section 8.2.9.2.1.1; Table 8-43
>   */
>  #define CXL_EVENT_GEN_MED_COMP_ID_SIZE	0x10
> -struct cxl_event_gen_media {
> -	struct cxl_event_record_hdr hdr;
> -	__le64 phys_addr;
> -	u8 descriptor;
> -	u8 type;
> -	u8 transaction_type;
> -	u8 validity_flags[2];
> -	u8 channel;
> -	u8 rank;
> -	u8 device[3];
> -	u8 component_id[CXL_EVENT_GEN_MED_COMP_ID_SIZE];
> -	u8 reserved[46];
> -} __packed;
> -
>  /*
>   * DRAM Event Record - DER
>   * CXL rev 3.0 section 8.2.9.2.1.2; Table 3-44
>   */
>  #define CXL_EVENT_DER_CORRECTION_MASK_SIZE	0x20
> -struct cxl_event_dram {
> +struct cxl_event_media {
>  	struct cxl_event_record_hdr hdr;
> -	__le64 phys_addr;
> -	u8 descriptor;
> -	u8 type;
> -	u8 transaction_type;
> -	u8 validity_flags[2];
> -	u8 channel;
> -	u8 rank;
> -	u8 nibble_mask[3];
> -	u8 bank_group;
> -	u8 bank;
> -	u8 row[3];
> -	u8 column[2];
> -	u8 correction_mask[CXL_EVENT_DER_CORRECTION_MASK_SIZE];
> -	u8 reserved[0x17];
> +	struct_group_tagged(cxl_event_media_hdr, media_hdr,
> +		__le64 phys_addr;
> +		u8 descriptor;
> +		u8 type;
> +		u8 transaction_type;
> +		u8 validity_flags[2];
> +		u8 channel;
> +		u8 rank;
> +	);
> +	union {
> +		struct_group(general,
> +			u8 device[3];
> +			u8 component_id[CXL_EVENT_GEN_MED_COMP_ID_SIZE];
> +			u8 gen_reserved[46];
> +		);
> +		struct_group(dram,
> +			u8 nibble_mask[3];
> +			u8 bank_group;
> +			u8 bank;
> +			u8 row[3];
> +			u8 column[2];
> +			u8 correction_mask[CXL_EVENT_DER_CORRECTION_MASK_SIZE];
> +			u8 dram_reserved[0x17];
> +		);
> +	};
>  } __packed;
>  
>  /*
> @@ -95,21 +92,12 @@ struct cxl_event_mem_module {
>  	u8 reserved[0x3d];
>  } __packed;
>  
> -/*
> - * General Media or DRAM Event Common Fields
> - * - provides common access to phys_addr
> - */
> -struct cxl_event_common {
> -	struct cxl_event_record_hdr hdr;
> -	__le64 phys_addr;
> -} __packed;
> -
>  union cxl_event {
>  	struct cxl_event_generic generic;
> -	struct cxl_event_gen_media gen_media;
> -	struct cxl_event_dram dram;
> +	struct cxl_event_media media_general;
> +	struct cxl_event_media media_dram;
>  	struct cxl_event_mem_module mem_module;
> -	struct cxl_event_common common;
> +	struct cxl_event_media media_common;
>  } __packed;
>  
>  /*
> diff --git a/tools/testing/cxl/test/mem.c b/tools/testing/cxl/test/mem.c
> index 6584443144de..0a8fd145c391 100644
> --- a/tools/testing/cxl/test/mem.c
> +++ b/tools/testing/cxl/test/mem.c
> @@ -378,7 +378,7 @@ struct cxl_event_record_raw hardware_replace = {
>  
>  struct cxl_test_gen_media {
>  	uuid_t id;
> -	struct cxl_event_gen_media rec;
> +	struct cxl_event_media rec;
>  } __packed;
>  
>  struct cxl_test_gen_media gen_media = {
> @@ -402,7 +402,7 @@ struct cxl_test_gen_media gen_media = {
>  
>  struct cxl_test_dram {
>  	uuid_t id;
> -	struct cxl_event_dram rec;
> +	struct cxl_event_media rec;
>  } __packed;
>  
>  struct cxl_test_dram dram = {
> -- 
> 2.45.0
>