Received-SPF: pass (google.com: domain of linux-kernel+bounces-181601-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <c52a87c6-048b-497a-aa1e-bb3efbf2147c@oracle.com>
Date: Thu, 16 May 2024 14:59:25 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] mm/hugetlb: Drop node_alloc_noretry from
 alloc_fresh_hugetlb_folio
To: Oscar Salvador <osalvador@suse.de>,
        Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        Muchun Song <muchun.song@linux.dev>, Peter Xu <peterx@redhat.com>
References: <20240516081035.5651-1-osalvador@suse.de>
Content-Language: en-US
From: Sidhartha Kumar <sidhartha.kumar@oracle.com>
In-Reply-To: <20240516081035.5651-1-osalvador@suse.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?a3ZjaEY1RTdWM0NkU1hjL2dCMG5YN3NGc3k2MjR3cko5RFNhK3dKa2xocUpZ?=
 =?utf-8?B?Vkl4SGl6MmlsbFJnNmZ4T05laTc5TU96VkJvek10QnhIREg2YlZsNHdwSThu?=
 =?utf-8?B?Zld0YVVVZk1aR3FGWU1IVEJtQTBIRzFGemJaVUoxRVpWL0p0VGdJSVpudkN4?=
 =?utf-8?B?WStZSVQxMThTenVZai9PWXNPSzlTanRPNEpPNFprQWJyd1NDSjRMQklLNm9M?=
 =?utf-8?B?STRuZXlTaVM3TC9lakdQWXYyV0phV1UwRFZrc2RDbzEyV3djSXE5eUgxbzly?=
 =?utf-8?B?NmRzTEhPeFEybVBUK3c2SWZSZUxyekpXWjJjenRMcndrM1QvR0VjeFVmWWpD?=
 =?utf-8?B?S2FuOUoySTJCZ0xYeG1mTWd1T2w0MFI3YUZaa0RJZXdueU5KVmpPMi96SFRt?=
 =?utf-8?B?UWVkMERINFF2MnlZOWVPYTBWRkNnbjJJYUs0aFgwTEY3cTFQUlBUKzdxdC9S?=
 =?utf-8?B?UG9yR2hObnExb0MxYWV4Tm5xWllZWFczS3BrQlIySkhjc01kbWhROVRZRVIv?=
 =?utf-8?B?NitNSXJSZFMvNnZ1b2tBU0JDWVRsZmtwOW1IdUJ4Q0pMUWR4Z3BUa1R1bFYr?=
 =?utf-8?B?MDJPT2JnODUrN24vWlBwdStIL3hNSlovSEh6STBnT29TN1N3YWdGbGhHT1Jx?=
 =?utf-8?B?QmZmMFVGUGtQZ2lBcUx4NHVYQ2xBUVFGc0NURDNYdU51clgyRE9PNWN6ZlF0?=
 =?utf-8?B?bE4xbFk3b0NxaElFTVpwSUtPWlFBamZqYlUyZ0RWVXNsT1EzeEtJbTJSWWVK?=
 =?utf-8?B?VTZOMEp1NUVPZm9NcUFiK3p0ZHc3TFBILzN4T3J1OE9Dc2JtMks2U3JXTHIz?=
 =?utf-8?B?N2MyVXU2b0V6c3gzV1hzM2R0RFd0UHBoVFRSUVNVQ2ExMmNraG0rV0VMbHU5?=
 =?utf-8?B?U1RGVkV2NGlyOC80czNUaDRucmxTSnpzQ2x5bCs2bDdjVzExR2lNRTlOeHdS?=
 =?utf-8?B?K05KTUFjc2NFN1BZV20vYWlyRFk1STNySkQzQm1QRGZYRTg4QmxDaFFrS3NW?=
 =?utf-8?B?UTloUEIxS0tKd2Y4a25mOGd5T1RpMktLU3ZpN1I0Q3l1ZFdPY3RJcnEyUW1t?=
 =?utf-8?B?QksrSjRFTU9qNDlxSmk4NCtFQ3ptWXZUMVdRdWt5Vk50RTdYMTZ6OUp2cWZl?=
 =?utf-8?B?cEpHSzdvNmozNmg2Sm9kRjdsT2t3Z0svVmtWazRLbmVwN2ZCa2FyeDNrTmJL?=
 =?utf-8?B?QXA2RFk3cTZvZnpOWjQ0SWVEd3JQVTM3K3FickpEVXhSRGxxRHcydDRNcENJ?=
 =?utf-8?B?WFhUUCtYcGJIYzR1L1orREloQ25JVGIvTmlZbDJ6b2ZIZEphcUg3Y3BleWVh?=
 =?utf-8?B?SUJ2L29MSUs0QTllSDI5d2tDMGs5Smd1aExHQW5yQjFYbzlzTHFEWHphcEQ4?=
 =?utf-8?B?TTIyTzhGR1BOb04vUXUwWkdEcHZFOTI1MDNQVE8vdTNpWElBVno3cWNxM1dP?=
 =?utf-8?B?ZEp6UXNGTXNQT0xxaWQrNjZHNE8xVU8zVlF5YnB6d2REVC93K1hHczVwZTZ0?=
 =?utf-8?B?b3ViR0pNdnRtbzIySHNNTTFoNExqRlN4d2NqcDhVcWRBaHFoQlZwc2x2dHNW?=
 =?utf-8?B?dWJWcVdhaXFzMUE5TGtZSW1VZFdwYTFDbzFPRGVxRHptQ3dPUy9XZHAzWHVY?=
 =?utf-8?B?LzhTQUUzWjArOFZVdnlIOU1qVFJHWWZxYkxTd1FvUXBGejVnMHl1Yjl2dUo3?=
 =?utf-8?B?L21hVEM2L2xHRWVLV2hkL0Rsb0dzKzQ3dXVqVWNWTVZnaTlwVk1nblJxNGdn?=
 =?utf-8?B?ckhkaUlsVmszRXZld1dWWmp6YUNsUFVyOWs4Z05TTDBNWG1LV25ZVUJWZGx6?=
 =?utf-8?B?eWtvZGpFTDlUa3ZGYXlVeERuRDRQMktvdk10Tmp5d1I2cWlOWXlvODBJcHJq?=
 =?utf-8?B?QkVDYjNGaHFYYk4zclNtb1YxVlpGTDY2WE0yQTdCVDNTcmh4L2MzMjBhcXJF?=
 =?utf-8?B?RWl3KzhXVGo1bGRrT3V6N2ZKVHlTSUZSVDFsYzZzUVM2VmE0bW52ZXZ3WTFY?=
 =?utf-8?B?Y21IUDlKSko4ZEgybkJQUWxsUjlyQ0xsTGp4cThieGo1YnlDZEl0U09DL0NU?=
 =?utf-8?B?MlpldFZPL0NzdEVENEJ0MDY5MVl2U0prMVhadExnSjVBN3RkaEsvUnhmUVdD?=
 =?utf-8?B?OGdyQVZEekhKZ3d1UnMyRnNVc1RabHJYTkhCNmZyVkpuTHdvL0FzTnd4VHph?=
 =?utf-8?B?MHc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	i/MQveUek5Q3LRpkfk32Pigq/nGH/AFoZhaPAP0eDwdPFuYKnJquNCFIpdPOZVSmBH53VR7iuXKrTwBU/izam27XuoXc3NKnxEd+FwPx/DIwMIhJy2xN0QRHmYDl7hFrIW9SstKltTN4xl/yN4IHo6dyRpLjTzHGEXiD6XEJWjzcRpa9KJDw7NcF94OApefdORVBjfvgyb/fw78FBE3vGJ+5+CNyd2oSs0DEHq0sMka3XiTAjqJcPhviCJsx39KqZeK2nK4fGezkCVr0AIOY2tpc+PuOa7c0JMFiumRHk+vTZ4Ygicm0znYJVCbvS43CNreBju8H1Vp2Ywb36uaDJCCP+tI7O4nTFhe7OHZYlrXSHqRyz8HtyIbj9m/iQ5g4Zvtc5lpkYQyty+UXTvwS2aIBb0ipA3nnGlUe41xR3+8MybBTPDPWpDQstE43s82oz0k1Jgjec4PFcGFnEsf9xVOyT4hrW+WavHwcDayUgVY6X39sR3s8jM6zHMrls2yRv8Lw7fJ2uwRYL3Xn+9S3UTaTxUWieJu6ekh1It0XCSHZmxsHL7tjXo1EFsU1kNwz6FHmri5GPzoq35mxiGtFsYfNc78fMmRABDZJhBfZR70=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 933334b8-7a88-4850-d6d9-08dc75f37517
X-MS-Exchange-CrossTenant-AuthSource: CH0PR10MB5113.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2024 21:59:28.3768
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KNIJWWRQVkl1FhvJBFNEb0supz7kleCudNGAXY7hkb3W8s8KsXOogjenXphUdJsmaZMGOnUZsHeYgfRJAFQQM7IGZU/U85mJ9Qam362EXoE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB7261
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-05-16_07,2024-05-15_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999
 adultscore=0 mlxscore=0 spamscore=0 suspectscore=0 phishscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2405010000 definitions=main-2405160162
X-Proofpoint-ORIG-GUID: twspQ7SmGi4NjzdFjMtyr8RhHYjBJeij
X-Proofpoint-GUID: twspQ7SmGi4NjzdFjMtyr8RhHYjBJeij

On 5/16/24 1:10 AM, Oscar Salvador wrote:
> Since commit d67e32f26713 ("hugetlb: restructure pool allocations"),
> the parameter node_alloc_noretry from alloc_fresh_hugetlb_folio()
> is not used, so drop it.
> 
> Signed-off-by: Oscar Salvador <osalvador@suse.de>
> ---
>   mm/hugetlb.c | 12 +++++-------
>   1 file changed, 5 insertions(+), 7 deletions(-)
> 
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 6be78e7d4f6e..fedce00ff839 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -2289,13 +2289,11 @@ static struct folio *only_alloc_fresh_hugetlb_folio(struct hstate *h,
>    * pages is zero.
>    */
>   static struct folio *alloc_fresh_hugetlb_folio(struct hstate *h,
> -		gfp_t gfp_mask, int nid, nodemask_t *nmask,
> -		nodemask_t *node_alloc_noretry)
> +		gfp_t gfp_mask, int nid, nodemask_t *nmask)
>   {
>   	struct folio *folio;
>   
> -	folio = __alloc_fresh_hugetlb_folio(h, gfp_mask, nid, nmask,
> -						node_alloc_noretry);
> +	folio = __alloc_fresh_hugetlb_folio(h, gfp_mask, nid, nmask, NULL);
>   	if (!folio)
>   		return NULL;
>   
> @@ -2513,7 +2511,7 @@ static struct folio *alloc_surplus_hugetlb_folio(struct hstate *h,
>   		goto out_unlock;
>   	spin_unlock_irq(&hugetlb_lock);
>   
> -	folio = alloc_fresh_hugetlb_folio(h, gfp_mask, nid, nmask, NULL);
> +	folio = alloc_fresh_hugetlb_folio(h, gfp_mask, nid, nmask);
>   	if (!folio)
>   		return NULL;
>   
> @@ -2549,7 +2547,7 @@ static struct folio *alloc_migrate_hugetlb_folio(struct hstate *h, gfp_t gfp_mas
>   	if (hstate_is_gigantic(h))
>   		return NULL;
>   
> -	folio = alloc_fresh_hugetlb_folio(h, gfp_mask, nid, nmask, NULL);
> +	folio = alloc_fresh_hugetlb_folio(h, gfp_mask, nid, nmask);
>   	if (!folio)
>   		return NULL;
>   
> @@ -3474,7 +3472,7 @@ static void __init hugetlb_hstate_alloc_pages_onenode(struct hstate *h, int nid)
>   			gfp_t gfp_mask = htlb_alloc_mask(h) | __GFP_THISNODE;
>   
>   			folio = alloc_fresh_hugetlb_folio(h, gfp_mask, nid,
> -					&node_states[N_MEMORY], NULL);
> +					&node_states[N_MEMORY]);
>   			if (!folio)
>   				break;
>   			free_huge_folio(folio); /* free it into the hugepage allocator */

Reviewed-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>