Received-SPF: pass (google.com: domain of linux-kernel+bounces-181631-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <1fe263c0-d6f5-417b-8819-c24dba3dee69@intel.com>
Date: Fri, 17 May 2024 11:16:26 +1200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 08/16] KVM: x86/mmu: Bug the VM if kvm_zap_gfn_range() is
 called for TDX
To: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>, "kvm@vger.kernel.org"
	<kvm@vger.kernel.org>, "pbonzini@redhat.com" <pbonzini@redhat.com>,
	"seanjc@google.com" <seanjc@google.com>
CC: "Zhao, Yan Y" <yan.y.zhao@intel.com>, "sagis@google.com"
	<sagis@google.com>, "dmatlack@google.com" <dmatlack@google.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"isaku.yamahata@gmail.com" <isaku.yamahata@gmail.com>, "Aktas, Erdem"
	<erdemaktas@google.com>
References: <20240515005952.3410568-1-rick.p.edgecombe@intel.com>
 <20240515005952.3410568-9-rick.p.edgecombe@intel.com>
 <aa8899fd3bba00720b76836ec4b4eec3347d43dc.camel@intel.com>
 <e5d163ea-63ca-4c4f-9e69-6d1686be92c3@intel.com>
 <00d2cfe84f67dde1d9cbdcb2a2d907354e2d704a.camel@intel.com>
Content-Language: en-US
From: "Huang, Kai" <kai.huang@intel.com>
In-Reply-To: <00d2cfe84f67dde1d9cbdcb2a2d907354e2d704a.camel@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VEdReU9nTXIxejd5WmJWQVFnbXFaYnpCMngxN2FGeWlzeDI4OVFIZzhRSEM2?=
 =?utf-8?B?blVTK2RyZ3hoMFNKYVhMRGNlZjRPRGR6YzdIeXRyZlpHcVFHWkc0bFRRM2ti?=
 =?utf-8?B?T0VtVzIya0lMU3AzOENtNndIY05PanlDTWZvc1ZxQis0TjgyNjgxZ2RFd3Yr?=
 =?utf-8?B?SzJwNWEydlZOQWNtVy83U0lBMkhlUnFmUlBUU0hicXMrOGd2SmVFbm5lQ1Nv?=
 =?utf-8?B?V3FDNnhybFNEVjErT3ovTHZwemNLUHdjL0JadDgrdUpkZktOemxveE9IcjRY?=
 =?utf-8?B?QlV5dlJiWFVRZll3UWhPU2VxRnhTRVN0U0pQSUVOaU9qRENDVEl2ZGhORlgr?=
 =?utf-8?B?bXdOdjNhTjFDNXlUeFpyWGVMT1BzVk1PUUc2V0Q1SlIvdFVEQjNXQ3NrMFU2?=
 =?utf-8?B?S3N0TTZJVUtYdTFpQmpQY2NRZEZMRnNRUzBINlFoVTJvUUtoWU9Xb1VEcW9K?=
 =?utf-8?B?ZEdRMXNDeXZxQnhmSjViT0xTUDlPaFozQ3BjQVVTc29meTJyUk91UHNIZXNJ?=
 =?utf-8?B?NGczWHYwQ285djBuVUZvdUtNdDJOcG9hZkYwUmdtQkU0eW5qSjJ6amZvbk1P?=
 =?utf-8?B?NkRZZUlpK1VoaHJLaHhITFdPc2VqVlpyVnV1dXB1eU9ocWd5OU1HTG9UMlEx?=
 =?utf-8?B?djRnTitCb3RVd1h4SzdQYjJSWHBoVGVsNVRyMmVyeEtsbUwvYWZsWUtmSldx?=
 =?utf-8?B?STZIenpVV1RaVm9pVGQ1SFFkUzEzUVAzaFg1bFZkbW9mMDF3L0sreWJsUmRN?=
 =?utf-8?B?MEMvTXUyczEvL09WdlFGUyszaEp0MDZjdUsxMlhZdFUxMXUrQThReTB6eis5?=
 =?utf-8?B?OEk1a3BvMFd3QzR2UU04ZTVlcjNacmJXVy9lQWlWZmVEMDlwa0t0cExZUDlz?=
 =?utf-8?B?bFF6Nk9aWDE3aWZDOTZ6KzB1MForQVJ0ZlpnN3l1ZzMzU2tkOTBXQ0NVME5K?=
 =?utf-8?B?T1AyMTkyUTVoeDFRUktUWGR0OWxobWlwM2NDOHQyeVVzRCtLV3Y2cUFlbzVr?=
 =?utf-8?B?a3VvM21NcWgwa01FK3hUNmxaWTlTN2dGYnc0bHEwUDMxdndVdjNKZ1RwMzdq?=
 =?utf-8?B?Zzk0eGFyL2FSVHZHcC85QkgvTUszUUJjK3FseWZORVh2N2VhalN0bUF3OWJh?=
 =?utf-8?B?a041Mm5SYStzREJpZmFmV3hXZ25wTmxhR01TSnlXVHRkOWRMVlN1UTltSVBO?=
 =?utf-8?B?Yk5EazFNRGJYMTF0TUpZRjVNRGlibDc4QU4vRE0veGZoa1pIRXJBbVRUdlFH?=
 =?utf-8?B?cXFiYjU2Rlg0Rmo2a2RSb0dVY0twK3hyUFpMOHhrOWI4cG94Ykxaek9yQlg5?=
 =?utf-8?B?QzRhVmQ1K01mNjVMTkJhNnltTWtobzVCNHJVdVREaitWNjlqS05zUWNQaGtF?=
 =?utf-8?B?RVNzclZiK25pcmdxQ3dqV3E5WGdSVFgvaEJjWjR1b0tVMHZXY0p5UUhXYk05?=
 =?utf-8?B?YURVakgwOENtWG1Yblg4SEdnbGZTVEZGS3FVcjFCNlRnbWpzakRMNHVnWWVO?=
 =?utf-8?B?dXgvdEJ5YXk0S0drWG5WY0F1eVJTdWhPc1EvMWN1c1R0aFFuYzJmbnF5K2ZI?=
 =?utf-8?B?WTlyOGFHeG9SZ2lxT1AyVHVHc0ZiejI4aTNWQ25qUmVLb2FYU0JoUlQ5MjN1?=
 =?utf-8?B?NGFvVWMxd2l3VnBCUXB6OUVDditoUEpQVTl6MlBEYStrdG1USnQrc1JCeFhG?=
 =?utf-8?B?Mm5DUEtTaDJsdEpEamZHZFZSaENLaWpJQlZBZmN2QTQ0c1VWODJjbSszcE5V?=
 =?utf-8?B?RHZ6R0V3U2JNK29nay9lN0J0N1RRZkVmNG9mNkpCSmdReUZtVHdCSGdTb1hz?=
 =?utf-8?B?c0ZBUnArWjQvSGNSYzNMbDlUZGxZUk1XekdFZTZCMytDUnZZcWQzQTVIUzN2?=
 =?utf-8?B?N1Vka0xRWUlPd3hMS0QvdkNIOEpuUlJEbVhwLzdaTXg1R0hlMlErZmNOVFUv?=
 =?utf-8?B?Y2pCa0pwQWIxNmRRS1JQLzNSd3Z5T3Era1E1UHdCSmlWZlNxWGJ6dUxlSjNl?=
 =?utf-8?B?bkNjKzVxNU1rSllZdmVnNFlrd1pmTmNDU2hjTmVTYVF0cmZXaHd1dWxwbHpl?=
 =?utf-8?B?YVUrcXFTS08vdHhMQWlpem82TFJpTllyVmJsKzh0R3NTdmszN0d1MWo2WkNj?=
 =?utf-8?Q?iSFLk129xbPO0QfRTXoJa89Hy?=
X-MS-Exchange-CrossTenant-Network-Message-Id: faddbfe8-69ad-4197-a76c-08dc75fe3b7d
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5978.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2024 23:16:36.1054
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VZdinBdHCQFPXpzdvpTh/PFVYDzUZsmPpVDXvVKYqEOlToWfnmnRrmTqJ6FhDoGRdukeb57B6CnXI70mBVHsdA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB8472
X-OriginatorOrg: intel.com


On 17/05/2024 10:38 am, Edgecombe, Rick P wrote:
> On Fri, 2024-05-17 at 10:23 +1200, Huang, Kai wrote:
>> On 17/05/2024 9:46 am, Edgecombe, Rick P wrote:
>>> On Tue, 2024-05-14 at 17:59 -0700, Rick Edgecombe wrote:
>>>>
>>>> For lack of a better method currently, use kvm_gfn_shared_mask() to
>>>> determine if private memory cannot be zapped (as in TDX, the only VM type
>>>> that sets it).
>>>
>>> Trying to replace kvm_gfn_shared_mask() with something appropriate, I saw
>>> that
>>> SNP actually uses this function:
>>> https://lore.kernel.org/kvm/20240501085210.2213060-12-michael.roth@amd.com/
>>>
>>> So trying to have a helper that says "The VM can't zap and refault in memory
>>> at
>>> will" won't cut it. I guess there would have to be some more specific. I'm
>>> thinking to just drop this patch instead.
>>
>> Or KVM_BUG_ON() in the callers by explicitly checking VM type being TDX
>> as I mentioned before.
>>
>> Having such checking in a generic function like this is just dangerous
>> and not flexible.
>>
>> Just my 2 cents, though.
> 
> As I said before, the point is to catch new callers. I see how it's a little
> wrong to assume the intentions of the callers, but I don't see how it's
> dangerous. Can you explain?

Dangerous means when "a little wrong to assume the intentions of the 
callers" actually goes wrong.  In other words, a general intention to 
"catch new callers" doesn't make a lot sense to me.

Anyway as said before, it's just my 2 cents, and it's totally up to you.