Received-SPF: pass (google.com: domain of linux-kernel+bounces-181653-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <5cceccdba7297d84e948a85f533f3189.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <73a9d56c-9e8d-4859-b3a2-dba1531b57e5@foss.st.com>
References: <20240419152723.570159-1-gabriel.fernandez@foss.st.com> <20240419152723.570159-3-gabriel.fernandez@foss.st.com> <332c845c17e24e2eb660e18680f2626f.sboyd@kernel.org> <73a9d56c-9e8d-4859-b3a2-dba1531b57e5@foss.st.com>
Subject: Re: [PATCH 2/4] clk: stm32mp2: use of STM32 access controller
From: Stephen Boyd <sboyd@kernel.org>
Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
To: Alexandre Torgue <alexandre.torgue@foss.st.com>, Conor Dooley <conor+dt@kernel.org>, Gabriel FERNANDEZ <gabriel.fernandez@foss.st.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Michael Turquette <mturquette@baylibre.com>, Philipp Zabel <p.zabel@pengutronix.de>, Rob Herring <robh+dt@kernel.org>
Date: Thu, 16 May 2024 17:34:41 -0700
User-Agent: alot/0.10

Quoting Gabriel FERNANDEZ (2024-05-14 23:41:17)
>=20
> On 5/8/24 00:02, Stephen Boyd wrote:
> > Quoting gabriel.fernandez@foss.st.com (2024-04-19 08:27:21)
> >> diff --git a/drivers/clk/stm32/clk-stm32mp25.c b/drivers/clk/stm32/clk=
-stm32mp25.c
> >> index 210b75b39e50..a37ee9f707e3 100644
> >> --- a/drivers/clk/stm32/clk-stm32mp25.c
> >> +++ b/drivers/clk/stm32/clk-stm32mp25.c
> >> @@ -4,7 +4,9 @@
> >>    * Author: Gabriel Fernandez <gabriel.fernandez@foss.st.com> for STM=
icroelectronics.
> >>    */
> >>  =20
> >> +#include <linux/bus/stm32_firewall_device.h>
> > I don't have this include. I either need a signed tag or this needs to
> > wait until next merge window.
>=20
> Sorry for the delay, i was off.
>=20
> I was based on tag next-20240419
>=20
> >>   #include <linux/clk-provider.h>
> >> +#include <linux/of_address.h>
> > What is this include for?
>=20
> yes #include <linux/io.h> is more appropriate.
>=20

Ok. Please resend after the merge window.