Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp669638lqo; Thu, 16 May 2024 19:30:39 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWzuPGysBRtFbxCeWlrciPZEGN8by/+zgmgWrCtgeHgXmgj/VNbD+It3B+ibBxctYVzxjO8jDYqI++0JsADKqBbE1qv4O1748Mffof2ag== X-Google-Smtp-Source: AGHT+IEq45LeOd6vEIlUaPJ2q1O9y/7jUf+jUsdXJScpdtiBBBTS7N+DvHBXrGSpj/zr2AeJGgrY X-Received: by 2002:a05:6a20:5527:b0:1af:d647:3108 with SMTP id adf61e73a8af0-1afde0af5c2mr18005691637.2.1715913039464; Thu, 16 May 2024 19:30:39 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715913039; cv=pass; d=google.com; s=arc-20160816; b=rbZGhqFH8gm5zh2CT4h+qjBOdiwgDLUMzuUmD7oIkKa+Mm0hHOswjNBVd1QpjNBsMv hotLUResHa+iVM56bSUGf4eEAF41dORNVpJ7rBfmJojMIPwZscX47PQtPzBUbDTc5Iy3 REN4PzxgsbdXy5wDm5ksLp/imDHWcd6fKKCEMb37Fz8LdYd2PbFbfyAYIbdngXFcrMYk 6d6jBIPumDFxa18yqniyvFbjCrta6QdNaVM3IlZliaWNChWPgs5UHP6HC9nRGniw/EW6 Z2KzxOdiiTZpFUd5hUgIBLt2Gsqzxpglg3Iy9h9Us9XaGiV0cb/YDyLI5MyM8WYCkF5f sk0g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=bAaTm4i8GbKAujXZw/Nj794uuuDBMkfyY62rPnCcTt4=; fh=wPbc7c0Q4O1yTw1K7Z4qH1E6UMYiXU7iaBEwjwHU8ss=; b=jun/D+PcSWbpCYF57dIkeGEOjjOe2rx0MWOloScnIqMCfJ0HBIOcBaUhlPIKvG97cy 92b9U2CtRhHE4biWmIPzK8lpJewWorJ0VxxhvbvcLCK4G5BGDty57Gjsps+pSEgSTsjr DpwZb20BXykVbNXY7cOMmocZlb7SMROgutT69c6gh9lnHc6x4d9SE39oSMLKuM3kbcQf vRot2ZhwpC35OSrTp6lBmUFxnepje/hjE+MIvaPgYDN+HeEIGoHpz+aGfIeKIhSf2GBN VB6BvihZNDzPNauG7pJip7L2imCI8thbDtYqZ/FJ4y+VMs9/9QQQxBopAHYRs0hFwg0p 73fg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=A7704XwV; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-181669-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-181669-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id d9443c01a7336-1ef0c26a4besi162770755ad.606.2024.05.16.19.30.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 May 2024 19:30:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-181669-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=A7704XwV; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-181669-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-181669-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 4B622282A89 for ; Fri, 17 May 2024 01:13:50 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 68D8B17FD; Fri, 17 May 2024 01:13:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="A7704XwV" Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79073622; Fri, 17 May 2024 01:13:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715908421; cv=none; b=CPo26vxIWBBQIDBCczBkdb0kmKFHsiI+sh3cz2EOg++e+qRD1I6iuFYUHUc2gcUu+TYYcYAPo2afsTryaisTcV+3ZFQdFQUfTl55gV501aQdfpPhAQVIXiyQKnFeXQJBVUXw8JbSXIuJnySSPvAzUPGdFpGZhxFB1IGS5Zn3Q+g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715908421; c=relaxed/simple; bh=/vvsswAoAmgw2yBWUNu63T1F+yzlmKWlMthqEIrZGhg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dRviwlOHwYfAov46QCIfGVBHyuqNUHdKk0f3ZwTsqowpsi66iEUFbbGOa0c/3Yv8YoGr4K2/baDrbBTGbG1LsqtRfHJ6bvC8MVJWPcKJjHvfsmUHcXzWH2ABkJjWMvaNRCyivTf9JcuBGqpoTGCZdkFy3tkZCuHKnzG/7nSWDus= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=A7704XwV; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=bAaTm4i8GbKAujXZw/Nj794uuuDBMkfyY62rPnCcTt4=; b=A7704XwVQCJKlO1iLZQaTR2qje EiMO3ljg1j6WybniFFv/rcE8vASAIHIhyyHefq4J3zxkct5KzEbth8Huy7neQoSfIjxpyyif1c/lp eHBV0OS/yk8sWPrm/TfbZ+1n17Yl2ZNwCok56KL5MulmWYGI6EJNYlIrRG2mVXEmikpODYJDl/NUl ATNntx+hFn1MQfqUDKsSONlTGnEwiXVSN1RaNzXCo19AUpMkWKuBLH7XB7CHj5h5j+47EKAahS1qf iEpTdS+FCwQMQij6LjOcxrncpS94Z1a/TB6uphrr954Va2B3fAdKCrTYtP5Jq9JbK+n9iW8wteePr HhONV66w==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s7m9y-0000000CRRv-2uiS; Fri, 17 May 2024 01:13:22 +0000 Date: Fri, 17 May 2024 02:13:22 +0100 From: Matthew Wilcox To: Justin Stitt Cc: Christian Brauner , Jan Kara , Nick Desaulniers , Nathan Chancellor , Alexander Viro , Bill Wendling , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-hardening@vger.kernel.org Subject: Re: [PATCH v3] fs: fix unintentional arithmetic wraparound in offset calculation Message-ID: References: <20240517-b4-sio-read_write-v3-1-f180df0a19e6@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240517-b4-sio-read_write-v3-1-f180df0a19e6@google.com> On Fri, May 17, 2024 at 12:29:06AM +0000, Justin Stitt wrote: > When running syzkaller with the newly reintroduced signed integer > overflow sanitizer we encounter this report: why do you keep saying it's unintentional? it's clearly intended.