Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp671921lqo; Thu, 16 May 2024 19:37:32 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXEYysK42KHcCRMm2FyLcmotX2keUqOCFdW2niermcZ2Nh3V8dSnIZcZoqqI6pGvI7EUVjurCTmXZYK/P0+nUZhho9CDSH+fi3co+p4AA== X-Google-Smtp-Source: AGHT+IEkggc2zcxnqsQZwcYQlOJX9q2CNYW/sNW8NNXkF/GyHUHknMP95wk5U5goja3bSW+QWKmj X-Received: by 2002:a17:906:459:b0:a59:db0f:6bd7 with SMTP id a640c23a62f3a-a5a2d6763efmr1296918666b.71.1715913452196; Thu, 16 May 2024 19:37:32 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715913452; cv=pass; d=google.com; s=arc-20160816; b=upIL91pgqkuyPb6PcT1Qa0nnwOsqi1K2M+eB/o/+i2iW2VPuXS9uzM2O93Pxlgzfyw qlwB+7f3jD3dfcQLA+5c8xwVZmzdOUrHDxgJBrR1bpJAYFDuXQAMhuNI5nLNkoPMdVMS gN6YBjbgo3BuQQloakMC1waRd+652n7X0QqiJyGpHEZGhwM17E0S36bpxyq7GhtoQjK+ zfs5ooqsJuckFJmI73bPfKA1g6zOkR6VkfJHaUlncLhOaSI1fP4BuwelFn/+jnFSihmA AUUM6L5JzIDdMB2gwGQEFZQMBSEIooLkz5K0FqwDq24+FiwHk6NHvkueHWmkgPON+E5w 1ouA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=TNGBFcHSG2LF2Efws8oQ6/eC3FbDHEKkaEShA3Iva3k=; fh=aLY+W9n/n9ZWfrv4HqQdcp9h6HTZnumOjtCkNtQ9bb0=; b=DeaHKrLyD693KpywhkrEUQ+Ur51eyVPUXCjy5vwBt2albFzPaWeXQ+Xj9Q3azvSqJP o1U6meCB3QTV1sOMn5nHPGUFWn8EkD+jJ6qMp0pYqQVcrOZjmsa3YKiBhybOmUPHc1bB Y+plMuzlzVm4Ym0jpKRQIXnvIVgolzAIAxs95lkVPtfCjZ0MOAQZR2NYJX2TinoMTRrY hXgJRP/IS71HZqtJ/HsxkMODLoBvIpnwiy4senT0QxoAWq6eGG0TZb9BSbzisBOpin4Y BZtkFIVq9tR8wmZWTfwY2U2bHHGvZMGGIi+0qhGDRF5pA8S1r5JjQT+j0G3IT+D9iVRT m1KQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=O7xex74P; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-181703-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-181703-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a640c23a62f3a-a5a534bfc5dsi669449466b.757.2024.05.16.19.37.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 May 2024 19:37:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-181703-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=O7xex74P; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-181703-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-181703-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id DB9CC1F22832 for ; Fri, 17 May 2024 02:37:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 39686D266; Fri, 17 May 2024 02:37:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="O7xex74P" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51ADD8BEA; Fri, 17 May 2024 02:37:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715913429; cv=none; b=Tzu/bVxUmFzCtdmqkiwuCVX3QLGhTJMGwk1oQt4CM2gKY4h4HzeFrnqERdb0iRGreCcPiquTEcgbEdZRFTd4RXx+aPwI2r5TKGTcGp7G+syA5hkAJ4IhnuCRRBP8ZPfnTdEt+gE/Qg6Dk/7QA9etJTupG2XseVt0vHWKPfDN490= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715913429; c=relaxed/simple; bh=vK6hDEZj6iw56d+EQlyUthdBpd/wO6dYjpHajJrlOns=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=b1uybVqfAG73MYqQlyITSdLjMQOWiHGQCI0MmQdEKCTx9p/xSaTYFk8sAxpkV2gCN5gcz7SOEhQxKitwuhZLtVoyomjU6TekI6TSohRJoDiMV8yqCzJL0gdQjyPBjpiAoq54fnji/LT0r4JeSIvh95thTFh0LISBhrywOaT9Nys= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=O7xex74P; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2EB0BC113CC; Fri, 17 May 2024 02:37:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715913428; bh=vK6hDEZj6iw56d+EQlyUthdBpd/wO6dYjpHajJrlOns=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=O7xex74Pnf+wd1PKZW5ptyd9v1xDWGMwCTRYYlZJ/Op33bcy/GD9XbvBOelyZr3/v UTDixV625kRJV/rGW+G1jH/8iQ5MmooVbGnncQGhysFKL/L+VPR0DC8iZGIV3p205h rkYs5c6c4fnTWf8+wjVX1mY5N6+O0BB0qgsc6jAGpP6Qi8UQd6HPzVwwy2wUijIyP4 GBdWBQVsozeg0wNRjdNYFYQmFjyNtHFhEZRYwyv00B1fn3eewduowtkcteVG7ih4Xi LBYMMmgwLLr7HqAwfsu2Xo7tfuzYN3kfr6M50Qs3NqbPpeqJQU3kXoml+NOHdJ6JNH B3VtYF7d0jhAA== Date: Thu, 16 May 2024 19:37:07 -0700 From: Jakub Kicinski To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, syzbot+6c21aeb59d0e82eb2782@syzkaller.appspotmail.com, Jeongjun Park , Arseny Krasnov , "David S . Miller" , Stefan Hajnoczi , Stefano Garzarella , Jason Wang , Eugenio =?UTF-8?B?UMOpcmV6?= , kvm@vger.kernel.org, virtualization@lists.linux.dev, netdev@vger.kernel.org Subject: Re: [PATCH] vhost/vsock: always initialize seqpacket_allow Message-ID: <20240516193707.676ed88f@kernel.org> In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 15 May 2024 11:05:43 -0400 Michael S. Tsirkin wrote: > There are two issues around seqpacket_allow: > 1. seqpacket_allow is not initialized when socket is > created. Thus if features are never set, it will be > read uninitialized. > 2. if VIRTIO_VSOCK_F_SEQPACKET is set and then cleared, > then seqpacket_allow will not be cleared appropriately > (existing apps I know about don't usually do this but > it's legal and there's no way to be sure no one relies > on this). Acked-by: Jakub Kicinski -- pw-bot: nap