Received-SPF: pass (google.com: domain of linux-kernel+bounces-181763-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Fri, 17 May 2024 08:27:24 +0200
From: Frank Wunderlich <frank-w@public-files.de>
To: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= <arinc.unal@arinc9.com>,
 Frank Wunderlich <linux@fw-web.de>, Rob Herring <robh@kernel.org>,
 Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
 Matthias Brugger <matthias.bgg@gmail.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
CC: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org,
 Daniel Golle <daniel@makrotopia.org>
Subject: Re: [PATCH] arm64: dts: mt7622: fix switch probe on bananapi-r64
User-Agent: K-9 Mail for Android
Reply-to: frank-w@public-files.de
In-Reply-To: <a29dd7d1-40a8-4c88-99aa-651a3305b640@arinc9.com>
References: <20240516204847.171029-1-linux@fw-web.de> <a29dd7d1-40a8-4c88-99aa-651a3305b640@arinc9.com>
Message-ID: <5AEE5668-0C8E-4EE4-A398-66CB99DF5650@public-files.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:lA743/OJgs4=;r/sYu7nzWZ3+S01iYf5EWePZiH3
 bCW2LwckE9ONLkbibSk6ZQeva9RYiL7nJ23nCVr7LTGRxa9Jl9sl+aZw9uhfw+PxAh23XIlhA
 WShhBbq7qTJEHBLELZmBolmbFIjbPdu/tA3rQQTdoALCTlmjgwsDVEWUZRCO3uhDmjJdu32e9
 TZQlK9gDqQ52Q/bxx7kxRQhHYW/tMLHhuXFUtIudW79l9dBppnCMVFYDALT6XpIVrYZwyG4Gl
 6RAcps6WSvrduK21eKGK9AISI4LZ/oGYhLWGHk8GKq5Nqh4dgSOmz1iregZgSd24okIeNPSZW
 mjeJi+oD54cMWU8ytubZs8QGVuGSp504pCxf297v/+ITcmTB96xKQFhrDSYXR4FSB11sY0TJk
 Hx9WseiXQgxXbVr+ls+h5/sz+NWYjaIW9Y6Dl6rtdgtAuovq6EooUy90cZHcx7mfVAvHS4zvx
 9DNdJ8qKOm6EsoblygiBeV2z0KXCwiMihVu+En3uf4hVZBw6wfSx8uuagoE9zp3KNNDV5mG//
 nRrLdllnEq8O2RN9dpKEoFgnlRPBNP3QGsRKUIZc9ZRCcm4phfb6Wcoe5+WoU2oCzC6lbt4OQ
 tQvRAPWashvtNtCv9T+Atv41R39pN0j5s5Xhlqrcw8+7ynUlBIYnrXdzRNCF5pL6q2Jl48LwI
 bK4hsYoumvsy3364WSQfjgXAdeTq7y6njwLFutRdlSXzCF6BVihTDvSgPGTUf+qOXeFPZCaaP
 A4SNPd6NA94ChFkcS5GK8PNxk6cTf2FRo5201g2FNj9jLVzmGZdskzi6nGC9tHszAlbeP9SCD
 PV+VKLMUaNMo7rZd/yBFPbf+HdLbe7FFYwpoW7SUG1VBU=

Am 17=2E Mai 2024 04:17:47 MESZ schrieb "Ar=C4=B1n=C3=A7 =C3=9CNAL" <arinc=
=2Eunal@arinc9=2Ecom>:
>On 16/05/2024 23:48, Frank Wunderlich wrote:
>> From: Frank Wunderlich <frank-w@public-files=2Ede>
>>=20
>> After commit 868ff5f4944a
>> ("net: dsa: mt7530-mdio: read PHY address of switch from device tree")
>> the mt7531 switch on Bananapi-R64 was not detected=2E
>>=20
>> mt7530-mdio mdio-bus:00: reset timeout
>> mt7530-mdio mdio-bus:00: probe with driver mt7530-mdio failed with erro=
r -110
>>=20
>> Fix this by adding phy address in devicetree=2E
>>=20
>> Signed-off-by: Frank Wunderlich <frank-w@public-files=2Ede>
>
>I don't like the mention of the Linux kernel driver on the patch log=2E W=
hat
>you're fixing is the incorrect description of the switch's PHY address on
>the DTS file=2E Whether or not any driver from any project is actually
>reading it from the DTS file is irrelevant to this patch=2E That said, I
>already have a patch series I've been meaning to send the next version of
>that already addresses this=2E Please wait for that=2E
>
>Ar=C4=B1n=C3=A7

Hi arinc,

From=20my PoV it is a regression in next/6=2E10 because the driver change wa=
s merged (without "broadcast" fallback) and the dts patch [1] is not=2E

I agree that my patch can be dropped because there was already one=2E

regards Frank

[1] https://patchwork=2Ekernel=2Eorg/project/linux-arm-kernel/patch/202403=
14-for-mediatek-mt7531-phy-address-v1-1-52f58db01acd@arinc9=2Ecom/