Received-SPF: pass (google.com: domain of linux-kernel+bounces-181799-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 17 May 2024 07:32:03 -0000
From: "tip-bot2 for Nathan Chancellor" <tip-bot2@linutronix.de>
Sender: tip-bot2@linutronix.de
Reply-to: linux-kernel@vger.kernel.org
To: linux-tip-commits@vger.kernel.org
Subject: [tip: x86/urgent] x86/boot: Address clang -Wimplicit-fallthrough in
 vsprintf()
Cc: kernel test robot <lkp@intel.com>, Nathan Chancellor <nathan@kernel.org>,
 Ingo Molnar <mingo@kernel.org>, Justin Stitt <justinstitt@google.com>,
 x86@kernel.org, linux-kernel@vger.kernel.org
In-Reply-To: =?utf-8?q?=3C20240516-x86-boot-fix-clang-implicit-fallthrough-v?=
 =?utf-8?q?1-1-04dc320ca07c=40kernel=2Eorg=3E?=
References: =?utf-8?q?=3C20240516-x86-boot-fix-clang-implicit-fallthrough-v1?=
 =?utf-8?q?-1-04dc320ca07c=40kernel=2Eorg=3E?=
Precedence: bulk
MIME-Version: 1.0
Message-ID: <171593112323.10875.12795745055609386229.tip-bot2@tip-bot2>
Robot-ID: <tip-bot2@linutronix.de>
Robot-Unsubscribe:
 Contact <mailto:tglx@linutronix.de> to get blacklisted from these emails
Precedence: bulk
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

The following commit has been merged into the x86/urgent branch of tip:

Commit-ID:     82110ae235e0560d1f952f74f9fd991587b0e3a7
Gitweb:        https://git.kernel.org/tip/82110ae235e0560d1f952f74f9fd991587b0e3a7
Author:        Nathan Chancellor <nathan@kernel.org>
AuthorDate:    Thu, 16 May 2024 07:03:41 -07:00
Committer:     Ingo Molnar <mingo@kernel.org>
CommitterDate: Fri, 17 May 2024 09:22:56 +02:00

x86/boot: Address clang -Wimplicit-fallthrough in vsprintf()

After enabling -Wimplicit-fallthrough for the x86 boot code, clang
warns:

  arch/x86/boot/printf.c:257:3: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
    257 |                 case 'u':
        |                 ^

Clang is a little more pedantic than GCC, which does not warn when
falling through to a case that is just break or return. Clang's version
is more in line with the kernel's own stance in deprecated.rst, which
states that all switch/case blocks must end in either break,
fallthrough, continue, goto, or return. Add the missing break to silence
the warning.

Fixes: dd0716c2b877 ("x86/boot: Add a fallthrough annotation")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Acked-by: Justin Stitt <justinstitt@google.com>
Link: https://lore.kernel.org/r/20240516-x86-boot-fix-clang-implicit-fallthrough-v1-1-04dc320ca07c@kernel.org

Closes: https://lore.kernel.org/oe-kbuild-all/202405162054.ryP73vy1-lkp@intel.com/
---
 arch/x86/boot/printf.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/x86/boot/printf.c b/arch/x86/boot/printf.c
index c0ec1dc..51dc14b 100644
--- a/arch/x86/boot/printf.c
+++ b/arch/x86/boot/printf.c
@@ -254,6 +254,8 @@ int vsprintf(char *buf, const char *fmt, va_list args)
 		case 'd':
 		case 'i':
 			flags |= SIGN;
+			break;
+
 		case 'u':
 			break;