Received-SPF: pass (google.com: domain of linux-kernel+bounces-181890-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 17 May 2024 14:33:26 +0530
From: "Gautham R. Shenoy" <gautham.shenoy@amd.com>
To: Perry Yuan <perry.yuan@amd.com>
Cc: Mario.Limonciello@amd.com, Ray.Huang@amd.com, Borislav.Petkov@amd.com,
	rafael.j.wysocki@intel.com, Alexander.Deucher@amd.com,
	Xinmei.Huang@amd.com, Xiaojian.Du@amd.com, Li.Meng@amd.com,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 02/10] cpufreq: amd-pstate: remove unused  variable
 nominal_freq
Message-ID: <ZkcdXuHjnLzgSCnq@BLR-5CG11610CF.amd.com>
References: <cover.1715356532.git.perry.yuan@amd.com>
 <eafcb44942942f2a4489980066712b9e505a76a1.1715356532.git.perry.yuan@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <eafcb44942942f2a4489980066712b9e505a76a1.1715356532.git.perry.yuan@amd.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?9c4SXRMyyTOGXGNV3nkBQEYrg6CBoVZVnwFNisuwAteym9eDo8QMq0y09H/j?=
 =?us-ascii?Q?SkttP9pc+aDVuJ2iQr3d3gcOwwqARIuBCqyIPhd6jgCELMb9yagXGGZsaP81?=
 =?us-ascii?Q?4kdK6kfw6FDL1obh29Wyj8oBHGeL6wQgE88DA6wpdbiSF9CXK+fuTheMXtMy?=
 =?us-ascii?Q?qS4idTMRR1Kk7ReuC9bSztgBwYof2yOq2C135y22YHr2S5QtqRIH2luZ2wel?=
 =?us-ascii?Q?LKN4zuPJ/DkBQ5HoIOjD0pqbxg+ZgS5pVDqFjloi5FWLrilmJuOX0KOUWCHk?=
 =?us-ascii?Q?U6fADmTRPV2irPwpahdp+CMj/Afru1HNrfQnTfuDGF//b5N2ZyiuZggGmFBH?=
 =?us-ascii?Q?xD4vEJuufT1JTW07PP7QmYO5ANa5+cjgyEPccPoEgCswpsoTIxsq/k7n3HfH?=
 =?us-ascii?Q?0Cxg01RPLbsDpCno/segUWAAma3/cpwORXx91wOx/mzmi0vcEtyZcI5lOpME?=
 =?us-ascii?Q?/qeZeP0vlyWSKj6AsQcNGsxhdgHqM9tx3AbP4op1RLkySxcRaJeDjO6pCHBB?=
 =?us-ascii?Q?CAoNd7zf/6EHiKPH/l83XbVozBWAHZ++WlIN5Uw7yjZATeO8cGvmtOrLTMty?=
 =?us-ascii?Q?xK2c6+Jy5B+C37JyOiMWUQPV3n7rd3JUeGGfjbV1dFQGUyxyYHQjfSvoNwdk?=
 =?us-ascii?Q?QVLyXxxhHAm6ZmDbrtzmgM5klvWDhs74UaLpzVtz20G/UaKaA2QXfKr/JXyN?=
 =?us-ascii?Q?lRFzBqV4uXtbwKNruzm6+TRgYvwfIWMSXpl1u6SxzdmtTzIsoqQoGyhf1Xk2?=
 =?us-ascii?Q?z661PxAnt/yR3QWs80Z4ivvpdidAgJTp/EEBhOIBvhv066T4uSnSV0rbSJYU?=
 =?us-ascii?Q?vZjjtsoqMasLwC7v7Zs+fy3YBcd18RxLrjnL42j+yEP9SIQDIQtpw9tWIjc8?=
 =?us-ascii?Q?/uaXzSDFJc/1pkqaqn/lSAXetaETDyxbxcvMmTmV7bQno8lAm01tHtl/PRg8?=
 =?us-ascii?Q?XzR+nRbFbbjRWJ3EMX9u6K+hg8NCgQg6SvQ0S9U64e6OwOGrSlbAEX7yJzJs?=
 =?us-ascii?Q?Vkr/artNZoUs3Zb1wwNcg1xOQMevskUoNVejNBbad4hUiHCZhGeaZMgAn4PB?=
 =?us-ascii?Q?WSWzoy56ShAStXiM3LT+TriuAMbulLeClBqYBxSWSFPmc5VOvcK1LAK+ieUo?=
 =?us-ascii?Q?8lRLTCMJWfz7lJDPw/rqo8E1RXARBxCbc55cLvjoC90IrvaFpt+GjkuxbyZq?=
 =?us-ascii?Q?918kOcxvLeQNdi9K7wjp7BM3ocGNgC7Hqrc+Bot4Qi6dJHQk5lQ4F7nxtcAP?=
 =?us-ascii?Q?3yTG5VXtoK54mK5A3ljwoho0s9Ef9GJZHrAozU3Jafo1KIWx1kPIQFAqnRYT?=
 =?us-ascii?Q?Lpo3l4hsTxoZhdeMC3YCOSEwHRR2UhbB3cfretzN/PxZX/jX228T/rhACQoO?=
 =?us-ascii?Q?5L2M+rZkeJJPypSNX3bAt1/KUzdC/ISfn4+Zd8RD/29oR6xVnHdlxiz1eIRd?=
 =?us-ascii?Q?AXOwZ7KDrcgfSkafnOl77iOZb9CRDrl39XGyYxNqkq4/psFXYD5rIJwJYrdb?=
 =?us-ascii?Q?e8spdghsHTuLNIkDyXJzAFYedoywzfCwIYJu8BG6+GM27r9LiJvuP6e4XKmG?=
 =?us-ascii?Q?AAdiLXuJbxG9FssDk3tw2fbA5Enjn5k59TV8bA95?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 558d0b94-81c2-40ac-137e-08dc76503e79
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB8252.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2024 09:03:40.0644
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iKV70TgC3tQJykyuwn0KFMkPu3MX2urCBCGaQQCXrbQHr34dCfodrVRpwxyGxVA8gkDLulPJtmieos2HGRy3nA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6681

On Mon, May 13, 2024 at 10:07:20AM +0800, Perry Yuan wrote:
> removed the unused variable `nominal_freq` for build warning.
> This variable was defined and assigned a value in the previous code,
> but it was not used in the subsequent code.
> 
> Closes: https://lore.kernel.org/oe-kbuild-all/202405080431.BPU6Yg9s-lkp@intel.com/
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>

Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com>

> ---
>  drivers/cpufreq/amd-pstate.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 614f6fac0764..9ca22e94f3f3 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -912,7 +912,7 @@ static int amd_pstate_init_freq(struct amd_cpudata *cpudata)
>  
>  static int amd_pstate_cpu_init(struct cpufreq_policy *policy)
>  {
> -	int min_freq, max_freq, nominal_freq, ret;
> +	int min_freq, max_freq, ret;
>  	struct device *dev;
>  	struct amd_cpudata *cpudata;
>  
> @@ -943,7 +943,6 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *policy)
>  
>  	min_freq = READ_ONCE(cpudata->min_freq);
>  	max_freq = READ_ONCE(cpudata->max_freq);
> -	nominal_freq = READ_ONCE(cpudata->nominal_freq);
>  
>  	policy->cpuinfo.transition_latency = amd_pstate_get_transition_latency(policy->cpu);
>  	policy->transition_delay_us = amd_pstate_get_transition_delay_us(policy->cpu);
> @@ -1363,7 +1362,7 @@ static bool amd_pstate_acpi_pm_profile_undefined(void)
>  
>  static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy)
>  {
> -	int min_freq, max_freq, nominal_freq, ret;
> +	int min_freq, max_freq, ret;
>  	struct amd_cpudata *cpudata;
>  	struct device *dev;
>  	u64 value;
> @@ -1396,7 +1395,6 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy)
>  
>  	min_freq = READ_ONCE(cpudata->min_freq);
>  	max_freq = READ_ONCE(cpudata->max_freq);
> -	nominal_freq = READ_ONCE(cpudata->nominal_freq);
>  
>  	policy->cpuinfo.min_freq = min_freq;
>  	policy->cpuinfo.max_freq = max_freq;
> -- 
> 2.34.1
>