Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp815822lqo; Fri, 17 May 2024 02:22:51 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU9Wmoq85yIOeNh0Vgjtwuv+e5qHDQMbDej6S6iF8ZiLugZ9G3hFySnDiRJq/GtZIzounZQH8LDDfSvrl7tuWVbSOEn+P3b3lfRax01Cg== X-Google-Smtp-Source: AGHT+IFW27hIVWkGeReCYnpS4O2WB4cm5AnudL3Gal14dDW5XqaJ2CvEtocFPs/IG1whyu6c1sg0 X-Received: by 2002:a17:902:f693:b0:1ea:f921:61db with SMTP id d9443c01a7336-1ef4404a7efmr229487255ad.58.1715937770795; Fri, 17 May 2024 02:22:50 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715937770; cv=pass; d=google.com; s=arc-20160816; b=LESUV2HobEyejTs8CAqxj0PTSo4Pai4V7Rl3zfH2bzGCbpKCTHWjUkLCf8v0HlBtJP aB+Ul7l+KTg+ciNS11zZARYoTtANm6FBjWIm6mYZUNxX0/YnYTUcdgMzoMY8dLP68ITL SE7urZPreDC5hapq2vtiJgS7j0pCv6psjIDoLkDsKhN3un/ehbJJ5nqzKVuli3Ua6iQC aCajOBETog1FVYJ5XwFovfrNDws1rN/ptf6SRjL5/IFmdwYGUI4dRJ1MXhWQZV4kpKE1 UjW/3Hn1hwMCl5R4Q/gEMSYIEWEI3ynwzG/RvL96g7csIUaiD42lXSKfRSnT4Xw+Gb/7 uAgA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=6H5QqjfnbzXi38Mhan1b/OhNz0VkiYrd/rdH/mh5vbs=; fh=ABd84OJQRUrD+A12QMz3wVb/zHQYobBaZgm1K44zlcc=; b=QNB8BssusBKTyeA0hk0wsIJKU1isJXDaHZRhLT47pMdvUQSXgwHRuBBSHvm4jjiNRb vB83IY0Bz+lWWfxDMpDAKTgBuWbU3hQ+5UzqavtpLbyAXQRl9m9SopFbmy7+CLxTAd8G 3OVxxgYwATpilMVEX/iHI/QDiw3dddo6x6Ev+mfV890i6VFm38SZ8hUY2PUjfTToyZPo rU3vsW8jboZptMQ4sbyz5N9NZRVZdT9BcbkJzCEm2vqIct969aHS4Ci2LBqIq9TqrZrm tB0XqNl4nsu8gNKUgdXtaJ04NpGMNlQi/xB69d4vNRpWoqN1nHRzs8fQaAxTEFHes8IE klDQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=xtDel+lG; arc=pass (i=1 spf=pass spfdomain=ti.com dkim=pass dkdomain=ti.com dmarc=pass fromdomain=ti.com); spf=pass (google.com: domain of linux-kernel+bounces-181912-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-181912-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id d9443c01a7336-1ef0c138684si177247155ad.449.2024.05.17.02.22.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 May 2024 02:22:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-181912-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=xtDel+lG; arc=pass (i=1 spf=pass spfdomain=ti.com dkim=pass dkdomain=ti.com dmarc=pass fromdomain=ti.com); spf=pass (google.com: domain of linux-kernel+bounces-181912-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-181912-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id B750D282C3A for ; Fri, 17 May 2024 09:22:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E673920313; Fri, 17 May 2024 09:22:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="xtDel+lG" Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8EF12C1A3 for ; Fri, 17 May 2024 09:22:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.19.142 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715937743; cv=none; b=jvKOqct3NEtS4cWUB0rVcVH+o6TeGXdbZfrucU300xuUWuTHPt9P+he0/MQccduptIMscUtiXoDQmxPHUhMLDeXWQepGGzdiRMYLGo69sdgpMw4fEpz4odrJzSHYGPEFd1T2gumdokXUGIkVjGFRHza+1MCiV/HMjf3T8rqGYyg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715937743; c=relaxed/simple; bh=ToAwIbvzHG0YYLRGugwY07ZmC28i54igLPITw5CgNEo=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=B6d+Na5GWvKpGgLH90X3RNhakMGMMDCfTrqLYtrKp7hePC2iKrv6nCfGmHz1cyCb8qpWLRcGL05YbiEMWmvVqnlJy4Y2SEnwOl/mra67MkY1IsRn771v85gNcDQiH9tkTASeMQbbP/dlMhpsmxTgauKv8MtysLaxKLzvdl/Ksa4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=xtDel+lG; arc=none smtp.client-ip=198.47.19.142 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 44H9L3aY103227; Fri, 17 May 2024 04:21:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1715937663; bh=6H5QqjfnbzXi38Mhan1b/OhNz0VkiYrd/rdH/mh5vbs=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=xtDel+lGQgGKOPIJyHlrl3/9jSJjiVQ2c8DSUkT3FlG198EWf3tf27+n3PcQYyQV1 gZI9tkm9oQEUoEN+WeGRjInF+2nAuPzYjXsmcoK5w6wtq4gJCR99UPozdCM+39Mwp7 wyN5wipbdAaTxv9tkb3HNMmpOkUCR+G3grXiykR8= Received: from DFLE100.ent.ti.com (dfle100.ent.ti.com [10.64.6.21]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 44H9L3eI090552 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 17 May 2024 04:21:03 -0500 Received: from DFLE115.ent.ti.com (10.64.6.36) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Fri, 17 May 2024 04:21:02 -0500 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Fri, 17 May 2024 04:21:02 -0500 Received: from LT5CG31242FY.dhcp.ti.com (lt5cg31242fy.dhcp.ti.com [10.85.14.114]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 44H9KhXs036740; Fri, 17 May 2024 04:20:57 -0500 From: Shenghao Ding To: CC: , , , , <13916275206@139.com>, , , , , , , , , , , , Shenghao Ding Subject: [RESEND PATCH v5 3/3] ASoC: tas2781: Fix wrong loading calibrated data sequence Date: Fri, 17 May 2024 17:20:38 +0800 Message-ID: <20240517092039.688-3-shenghao-ding@ti.com> X-Mailer: git-send-email 2.33.0.windows.2 In-Reply-To: <20240517092039.688-1-shenghao-ding@ti.com> References: <20240517092039.688-1-shenghao-ding@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Use the API with correct sequence instead of the wrong one. Fixes: ef3bcde75d06 ("ASoc: tas2781: Add tas2781 driver") Signed-off-by: Shenghao Ding --- v5: - correct changelog has no much relationship with the patch v4: - Use the the culprit of the bug itself as the fixes tag v3: - No changes. v2: - In the Subject, fixed --> Fix - dsp --> DSP - Add Fixes tag - Changed the copyright year to 2024 in the related files v1: - Download calibrated data after loading the new DSP config params - Call tasdevice_prmg_load instead of tasdevice_prmg_calibdata_load, it is unnecessary to load calibrated data after loading DSP program. Load it after loading DSP config params each time. --- sound/soc/codecs/tas2781-i2c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/tas2781-i2c.c b/sound/soc/codecs/tas2781-i2c.c index b5abff230e43..9350972dfefe 100644 --- a/sound/soc/codecs/tas2781-i2c.c +++ b/sound/soc/codecs/tas2781-i2c.c @@ -2,7 +2,7 @@ // // ALSA SoC Texas Instruments TAS2563/TAS2781 Audio Smart Amplifier // -// Copyright (C) 2022 - 2023 Texas Instruments Incorporated +// Copyright (C) 2022 - 2024 Texas Instruments Incorporated // https://www.ti.com // // The TAS2563/TAS2781 driver implements a flexible and configurable @@ -414,7 +414,7 @@ static void tasdevice_fw_ready(const struct firmware *fmw, __func__, tas_priv->cal_binaryname[i]); } - tasdevice_prmg_calibdata_load(tas_priv, 0); + tasdevice_prmg_load(tas_priv, 0); tas_priv->cur_prog = 0; out: if (tas_priv->fw_state == TASDEVICE_DSP_FW_FAIL) { -- 2.34.1