Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp828160lqo; Fri, 17 May 2024 02:51:49 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWuBWenU95V900lcyK6+nc6gMetRRymiqK6QdOfvCaPq90puzh6QthpEW5SGU0cixSgHMCSXP+xhZ0USjvg1lXg3mpFzu1BqLYeLXe7jA== X-Google-Smtp-Source: AGHT+IGNUxa+7iAIri37svhobqf7eCuKhhXozbsCkaS/1E/ipslSqMXX63psdIPYVguI/THCZbwr X-Received: by 2002:a17:902:9a4b:b0:1eb:5b59:fab9 with SMTP id d9443c01a7336-1ef4404a1admr211915565ad.53.1715939508834; Fri, 17 May 2024 02:51:48 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715939508; cv=pass; d=google.com; s=arc-20160816; b=HkD1fXlPWEti/KqBeEFOKn8MxY/jSqDn8uCicYMbF37tCnvn2Z3RKYHcEOpEkwMEOt dScnCqmsB37wthR0GbuNNr0Sc3kjE4gfFpMgBKkuCWN7YDkaeVrP0oJtmwTE9opyZEs+ n6Vdx/ipNpenYItbuINN/EJ9geYPCFGR34TIpEHstMpoo2D4U4oBfC1gLgScGP7kTlkz 1ayNk2/wBmouQAGu80FMRK3x0K84sH4kz6v0XjBjxq1rH7p7HiwEhxKTig3nD3NbagZH fZpCaK4/j+vDGgOUp1cAqcyXJeiErGNRgH7HpZ2YglB91k9NrK3xBRnyF8Lr0bwg6CRa PPwA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=2L8RSK1UXgr12jXF9ubAdgAxLZaIH1liHhgWTNSlMsQ=; fh=Yq1qB4XyvaRICdjP2RHIF+hUUxZk+6eiXpceg4ZM6rY=; b=q6QD3SBmYyLMfA7pPEuIbh1zfDTJey6C6HbvMJJBIuqSb/qXGixUvYoPfVk5uhK5/+ gt7OV42ysHGCcYJftFTGKClOyC3vQBXgAVvbJHx6Z7AZD0wkqokPlqJJUkocyKkS+BQJ j2H9ATfdNGLT7hUbwtxQLhGCpvS/Tf1VlG/Vh0qkQC6L2/OnJuT+YHyNuflf8TIhJaZ6 6U8hgk5MqB081lUOmrdRXkUM4kzSzw6S9WSW8gJvE9PwdmQA0oXLqNHTxxKypAfq026i x0ZCbnwqP3/6DyJX/aBW/7ARPX649Rhd/kCE1Ely5i3CuqNOYWcM3mt9F3NVAzLGBcrR iZTQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rTPI1yah; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-181957-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-181957-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id d9443c01a7336-1ef0c14c52esi33115195ad.487.2024.05.17.02.51.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 May 2024 02:51:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-181957-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rTPI1yah; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-181957-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-181957-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 6A7A3280D4C for ; Fri, 17 May 2024 09:51:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CBC4A2C861; Fri, 17 May 2024 09:51:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rTPI1yah" Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5B792C68A for ; Fri, 17 May 2024 09:51:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715939466; cv=none; b=FyTRPI72C1hG5yFmJ3iXDfuX7cO4TMWVScWuXDp8CRrW44TUe7U+I6dAV5L6a1L/9UONQ9V/HS5FMBA4vcSwTtrAwfPDpHWU5XiXvei9K+kd7jz2XmRYw03u0rS8/04VnoUazNV1ba8NAMKxfO7wQuz8NmdZZOm37C1ol8dCUxs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715939466; c=relaxed/simple; bh=umr6x9k3m9I3EaMQpZAla3HYIuVCB+b9qLGvmHWWLBg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hV54yHlkLs3uTSlJ2wzmA1uurm/BOgNKLR3iVr04oMAD18eOBYWdusiU2gh599lYFv1AboJNyW74/BhWyZrJmJW5omJBe6hQcVp4Z0i9hNAt0xsD0iBzkbD4xl8Eg73ai45Wmp7Uu7DqrI2sW7jpjjOxd5rOFWKqp+qmaejiUe8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=rTPI1yah; arc=none smtp.client-ip=209.85.208.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-2e428242a38so23119521fa.2 for ; Fri, 17 May 2024 02:51:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1715939461; x=1716544261; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2L8RSK1UXgr12jXF9ubAdgAxLZaIH1liHhgWTNSlMsQ=; b=rTPI1yahKw340MOh4dMjhEOumBv0MWiuBtO2W5foCpzRzHU3y8UvXclEBXMugf3XrL Fr/y0bSFF4gcc9doIAFEQG+I0yY7iH7UUVgtF+c9qSp2UeMgFJQ3dlGQXiO6XFJbeZG+ t4YnbNLaNsQt8+NMvQdQk1ik7Zrlo1A76KOnKbQ0sXdNhuteDIgfESCk0t8/+P0hB959 /Y31YEDuTIiPFjv5sjaei1Ev46H/PPnpTebcv7T3tAlK7wb3heAxJ/nc+Iz8R3NUyYgl 7stW1aM1gWNbjlPrDcYSJKU+UMvTyGzvNZ5cJAT/xexD3419pUI9QDVIR/fS+HUQkVkM F3dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715939461; x=1716544261; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2L8RSK1UXgr12jXF9ubAdgAxLZaIH1liHhgWTNSlMsQ=; b=vm/sZTXM/Skjgu7Zf9uKpIF/+F3kJxsgbLwa/t3BBwVLw+hIJ09s7Drn6Prufzgyhl /fhBM7j9dG+9ZZJwMgH1bJwkbA60j2pPBYNYqrppdzDOXbIADgfty+0rD17NN/sLazGR W+7JH9l7L9duTnLTyuzVHOhMTL0VmdDJn923wk4gzbSrxZXIXVqobu9PVAu8aQOdXpH+ cQG5rzUAk5agSY5wowayfButd16ElLlmwqbnq8+IZPkp119Rnk7u2kDbH0UgbSPXA2j/ rQO8XRZ+2aIw8FQ9jPkW00/XC4ED8QVJ9046ifPcsOzCSgVEjGR+RD0k+oQELADjhzEt sLeA== X-Forwarded-Encrypted: i=1; AJvYcCX8fZzq0S6fDemVI2kEHRUDwL607Mjpua019/+L5lg3yUT0IkHFNtZokbhWoZmAS3q5dDDNsEdtSkojecLcT4NjdBZVIbi4w7PdWjSl X-Gm-Message-State: AOJu0YxwKVyuXks+8OmHhw75FPVPdYdkNklDeXE4F7W0Ja8vDfsEV8SA P9RQPbSUPa9GCWP7mS4ISNXAS0WYYXaLyMTxnpLB1Lg2zjDf3+LDJN44VKGiq8w= X-Received: by 2002:a05:651c:546:b0:2e5:4c78:1227 with SMTP id 38308e7fff4ca-2e54c7812famr187118681fa.31.1715939460955; Fri, 17 May 2024 02:51:00 -0700 (PDT) Received: from localhost ([149.14.240.163]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a5cfbd73547sm147700966b.171.2024.05.17.02.51.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 May 2024 02:51:00 -0700 (PDT) Date: Fri, 17 May 2024 11:50:58 +0200 From: Dan Carpenter To: Daniel Lezcano Cc: Icenowy Zheng , "Rafael J . Wysocki" , Amit Kucheria , Zhang Rui , Matthias Brugger , AngeloGioacchino Del Regno , Kang Chen , Dongliang Mu , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 0/2] thermal/drivers/mediatek: fix a regression affecting other subsystems Message-ID: <6b643d19-bdd9-4c35-a775-b8e3c21b75f5@suswa.mountain> References: <20230529162056.3786301-1-uwu@icenowy.me> <40546a57-27ac-8bf9-a2d8-77f7d4ab4aad@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <40546a57-27ac-8bf9-a2d8-77f7d4ab4aad@linaro.org> On Tue, Jun 13, 2023 at 10:44:51AM +0200, Daniel Lezcano wrote: > On 29/05/2023 18:20, Icenowy Zheng wrote: > > In the commit I reverted as the first commit of this patchset, the > > of_iomap function call, which allows multiple mapping of the same > > physical memory space, is replaced to calling devm_of_iomap, which > > registers exclusivity, and on my system (mt8173-elm), preventing display > > from working. > > > > So I reverted it, and to really solve the problem that the original > > commit wants to solve, I read the source of auxadc-thermal and realized > > that the address of these two memory blocks are not saved after probe, > > and they're only used when initializing the thermal sensors. This leads > > to my final fix, which is the second commit here, that adds of_iounmap > > just to the probe function. > > > > Icenowy Zheng (2): > > Revert "thermal/drivers/mediatek: Use devm_of_iomap to avoid resource > > leak in mtk_thermal_probe" > > thermal/drivers/mediatek: unmap foreign MMIO after probing > > > > drivers/thermal/mediatek/auxadc_thermal.c | 46 ++++++++++++----------- > > 1 file changed, 24 insertions(+), 22 deletions(-) > > I'll apply only the revert and let you revisit the patch 2 which could be > improved. What's the issue with patch 2/2? It looks okay to me. regards, dan carpenter