Received-SPF: pass (google.com: domain of linux-kernel+bounces-181970-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Fri, 17 May 2024 13:04:25 +0300
From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, richardcochran@gmail.com,
	jacob.e.keller@intel.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net] net: lan966x: Remove ptp traps in case the ptp is
 not enabled.
Message-ID: <20240517100425.l5ddxbuyxbgx42ti@skbuf>
References: <20240514193500.577403-1-horatiu.vultur@microchip.com>
 <20240514222149.mhwtp3kduebb4zzs@skbuf>
 <20240516064855.ne6uf3xanns4hh2o@DEN-DL-M31836.microchip.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240516064855.ne6uf3xanns4hh2o@DEN-DL-M31836.microchip.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?xgMCs8YJJae1iiFOj9h1BNZhbOWzEZun8caIpKGYCZkE4b3H4tuEx6PPU4Qe?=
 =?us-ascii?Q?Vi++uXe5dO3M1u2obluSdAMcY/RSVUovTth1Gv9rn8XWNiysPg058SiX74eX?=
 =?us-ascii?Q?er8iTypWUv550IgPlOWjxgsOUpo+e7vBjhex2xfqhkhlzDKHVTcGNaiL9h1w?=
 =?us-ascii?Q?Yqt9bNiqTeOIOsPtYhrm7nfQkJHTtamVT5diWrB0ytrztcRCDjXnMcGYlsXR?=
 =?us-ascii?Q?6SjBadD/cRbGisNmiqN9aYRbW6fOOHUsPW/MMpIoH2j61fbRJMx82eKK5n0Y?=
 =?us-ascii?Q?dkT3wZRDhrVSy9li3R5C7Q4R37WJi0zS7iHUALJjv6RNz0qCtOu85S24Wxml?=
 =?us-ascii?Q?Qw4E+En+PnNv1m0bDupjkoX0MDlHYPTNrdltm+1kgc3EG9c0eYmqgt5yt62E?=
 =?us-ascii?Q?zTIp3vMt009LoD+YKXCTTZUW4VuIq+B6wHR/+YkujQAgUVb7SawzJXnlkaYZ?=
 =?us-ascii?Q?Uw9LLPymXnLeCxCc+CUyXSI/dbLmjeiqu/p9vJleFipGbWy9EBYYnqov1aUc?=
 =?us-ascii?Q?F9WT/JWgFP2O/ns5vg2wjZ6sKcV0OWWoQor00rHbcy1ecaVzdiOc3pzfTeA/?=
 =?us-ascii?Q?8bgptf4zA6d43LhsuxOj0I9fqfqvxayLXm6DdJCj78qx+9Tt2OtJ/pikCwzg?=
 =?us-ascii?Q?CjYhARFc4BTDobh6qdtwLHWl9DRnCwga5aEN/PoMllRDXOhg7EsarCKbrplx?=
 =?us-ascii?Q?UluFntW+q6j3V/9zvy6RacjO1QV7eqk9HvhAvvtxvpuXPpJax9TinKPAmUNl?=
 =?us-ascii?Q?r2RL453CHEs5KdgcCNk3Drf51l8+XLc23Gxx5zGSmXvQKpLPidSWaZXWN/UA?=
 =?us-ascii?Q?bvW3RKbNq72YnUa5qsRNoZbWAfiRjjhCDE+tlXWTIfD3dRASU9d3+OVEw6rr?=
 =?us-ascii?Q?OHv/KYAhgKc1S2h7qzKt3gvKDk+Eaq6Upe/K2DpVGwiVFIHTfeqk0Y1dxZzk?=
 =?us-ascii?Q?PFl5k13XYv1fKbuSoRTERvvWX4UDFS+BkaRT1G7qtZP3n/KEXvXWg04F5Beq?=
 =?us-ascii?Q?E7Pd876g+pByOnHu1lRUKzNj/MIqUTAAObmYxREUHZqbRi5vrgLhKdDO80Xl?=
 =?us-ascii?Q?PVEuv6lR6EnR0Yl3ZmvNPJP/6CXj5laweScK+14WedGKI88V5P9EkdWR/NX2?=
 =?us-ascii?Q?2/0nQeqlMzTL3ZBQN+lJtkuT1c1390dWFnXTFH1TjWkdWpgvdtQWKWQiHpdY?=
 =?us-ascii?Q?TQwr3x0G8TCJpBj3ozJg4R/F9H5izcmnPlXiTN4xjigf8WUlBp3onq+HDrKd?=
 =?us-ascii?Q?+0VA3SA1IkZLfp+jEb/f2b3rhYw+87AyofgtYrN3bjNlbL9zcc71m8nE6tVo?=
 =?us-ascii?Q?sU/9C6YecD+NQ+DROpFiEEnlfjnKD7ZLiwHWrQVxOfGubwFxdkV3yK8wbSfR?=
 =?us-ascii?Q?K8PQigsiaX+yQ7LwRPqjgdYWFLtDVf28s7vIFhCOWvZDaTzMNhFsinbaE9Ii?=
 =?us-ascii?Q?RxZs5tSaQjHC/elOwnNKpdTevsLdyVejXc7Rl80/P4iGxHHXlFgsiLLs0B8S?=
 =?us-ascii?Q?ptJLEJcjbpdBMbuH/x+TG7aWUdYs0KtoJNZiMwf4xfsdh8bR95fXHraXz9d+?=
 =?us-ascii?Q?2P5qbgQap35Wul7omg1HYDvjvgQCEkSD+H8B7DWiMEbS87y6QOVzZVE2r6jy?=
 =?us-ascii?Q?7Q=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 01046b81-83da-4d51-c3c4-08dc7658bcf7
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB7374.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2024 10:04:28.3443
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GXOf0/B6gfpjDL/nGMzy0HR4O7dIIDqRy121nZRvodYEB3iqf9uimtDyBXazhmOLPkX4VE0ZNVSn9wrLTOnDVw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9694

On Thu, May 16, 2024 at 08:48:55AM +0200, Horatiu Vultur wrote:
> > Alternatively, the -EOPNOTSUPP check could be moved before programming
> > the traps in the first place.
> 
> Thanks for the review.
> Actually I don't think this alternative will work. In case of PHY
> timestamping, we would still like to add those rules regardless if
> ptp is enabled on lan966x.
> 
> > 
> > Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> 
> -- 
> /Horatiu

I don't understand why this would not have worked?

diff --git a/drivers/net/ethernet/microchip/lan966x/lan966x_main.c b/drivers/net/ethernet/microchip/lan966x/lan966x_main.c
index b12d3b8a64fd..1439a36e8394 100644
--- a/drivers/net/ethernet/microchip/lan966x/lan966x_main.c
+++ b/drivers/net/ethernet/microchip/lan966x/lan966x_main.c
@@ -474,14 +474,14 @@ static int lan966x_port_hwtstamp_set(struct net_device *dev,
 	    cfg->source != HWTSTAMP_SOURCE_PHYLIB)
 		return -EOPNOTSUPP;
 
+	if (cfg->source == HWTSTAMP_SOURCE_NETDEV && !port->lan966x->ptp)
+		return -EOPNOTSUPP;
+
 	err = lan966x_ptp_setup_traps(port, cfg);
 	if (err)
 		return err;
 
 	if (cfg->source == HWTSTAMP_SOURCE_NETDEV) {
-		if (!port->lan966x->ptp)
-			return -EOPNOTSUPP;
-
 		err = lan966x_ptp_hwtstamp_set(port, cfg, extack);
 		if (err) {
 			lan966x_ptp_del_traps(port);