Received-SPF: pass (google.com: domain of linux-kernel+bounces-181985-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Feedback-ID: ifd894703:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-456-gcd147058c-fm-hotfix-20240509.001-g0aad06e4
Precedence: bulk
MIME-Version: 1.0
Message-Id: <2aec4e38-f596-47d7-9e2a-a99e628dff5a@app.fastmail.com>
In-Reply-To: <2245e750-0b5d-49d1-88f3-7c1c75f275e7@kernel.org>
References: <20240513-boston-syscon-v1-0-93ff557d3548@flygoat.com>
 <20240513-boston-syscon-v1-1-93ff557d3548@flygoat.com>
 <c7317ea0-fcd6-40e0-9d90-bb1ff349c0e0@kernel.org>
 <31769e8d-ab52-4f4c-84ca-2f546287d006@kernel.org>
 <61445fe0-9137-44a6-ab36-ffb8985254df@app.fastmail.com>
 <2245e750-0b5d-49d1-88f3-7c1c75f275e7@kernel.org>
Date: Fri, 17 May 2024 11:15:23 +0100
From: "Jiaxun Yang" <jiaxun.yang@flygoat.com>
To: "Krzysztof Kozlowski" <krzk@kernel.org>, "Lee Jones" <lee@kernel.org>,
 "Rob Herring" <robh@kernel.org>, "Krzysztof Kozlowski" <krzk+dt@kernel.org>,
 "Conor Dooley" <conor+dt@kernel.org>,
 "paulburton@kernel.org" <paulburton@kernel.org>,
 "Thomas Bogendoerfer" <tsbogend@alpha.franken.de>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
 "linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: mfd: syscon: Add img,boston-platform-regs
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable


=E5=9C=A82024=E5=B9=B45=E6=9C=8817=E6=97=A5=E4=BA=94=E6=9C=88 =E4=B8=8A=E5=
=8D=889:58=EF=BC=8CKrzysztof Kozlowski=E5=86=99=E9=81=93=EF=BC=9A
> On 15/05/2024 23:44, Jiaxun Yang wrote:
>>=20
>>=20
>> =E5=9C=A82024=E5=B9=B45=E6=9C=8814=E6=97=A5=E4=BA=94=E6=9C=88 =E4=B8=8A=
=E5=8D=8810:11=EF=BC=8CKrzysztof Kozlowski=E5=86=99=E9=81=93=EF=BC=9A
>>> On 14/05/2024 11:08, Krzysztof Kozlowski wrote:
>>>> On 13/05/2024 20:58, Jiaxun Yang wrote:
>>>>> This compatible has been used in arch/mips/boot/dts/img/boston.dts
>>>>> for a while but never documented properly.
>>>>>
>>>>> Add it to simple syscon binding.
>>>>>
>>>>> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
>>>>> ---
>>>>>  Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
>>>>
>>>> It is documented in clock/img,boston-clock.txt. Please fix/convert/=
work
>>>> on that.
>>>
>>> No, that's different device.
>>>
>>> Anyway, this is wrong - does no work with your second patch. Please =
test
>>> them before sending.
>>=20
>> Hi Krzysztof,
>>=20
>> Do you mind telling dumb as me how to test bindings properly?
>>=20
>> I tried to run make check_dtbs after applying this patch and that's a=
ll
>> the warnings I got:
>> ```
>> arch/mips/boot/dts/img/boston.dtb: Warning (interrupt_map): Failed pr=
erequisite 'interrupt_provider'
>> /home/flygoat/linux-next/arch/mips/boot/dts/img/boston.dtb: /: 'model=
' is a required property
>>         from schema $id: http://devicetree.org/schemas/root-node.yaml#
>> arch/mips/boot/dts/img/boston.dtb: /: failed to match any schema with=
 compatible: ['img,boston']
>> arch/mips/boot/dts/img/boston.dtb: /cpus/cpu@0: failed to match any s=
chema with compatible: ['img,mips']
>> arch/mips/boot/dts/img/boston.dtb: /system-controller@17ffd000/clock:=
 failed to match any schema with compatible: ['img,boston-clock']
>> /home/flygoat/linux-next/arch/mips/boot/dts/img/boston.dtb: uart@17ff=
e000: $nodename:0: 'uart@17ffe000' does not match '^serial(@.*)?$'
>>         from schema $id: http://devicetree.org/schemas/serial/8250.ya=
ml#
>> ```
>>=20
>> I think there is no new warning introduced by this patch.
>> Did I miss anything here?
>
> Indeed there might be no warning for this, because syscon allows a lot,
> including children. You need custom binding anyway.

Hi Krzysztof,

I really don't understand the reason behind having a custom binding for
such device. It even doesn't have a driver and purely rely on generic
syscon regmap to work.

I can see devices like mediatek,mt8365-syscfg being described by simple
binding have a similar nature, they all describe a register bank and with
serval sub nodes to describe devices being instanced under that register
block.

What makes img,boston-platform-regs special here?

Thanks
- Jiaxun

>
> Best regards,
> Krzysztof

--=20
- Jiaxun