Received-SPF: pass (google.com: domain of linux-kernel+bounces-181990-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Fri, 17 May 2024 13:23:07 +0300
From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, richardcochran@gmail.com,
	jacob.e.keller@intel.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net] net: lan966x: Remove ptp traps in case the ptp is
 not enabled.
Message-ID: <20240517102307.7we5psrgbf56mden@skbuf>
References: <20240514193500.577403-1-horatiu.vultur@microchip.com>
 <20240514222149.mhwtp3kduebb4zzs@skbuf>
 <20240516064855.ne6uf3xanns4hh2o@DEN-DL-M31836.microchip.com>
 <20240517100425.l5ddxbuyxbgx42ti@skbuf>
 <20240517101811.vsqcg7moapixlfpj@DEN-DL-M31836.microchip.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240517101811.vsqcg7moapixlfpj@DEN-DL-M31836.microchip.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?IduCMwFrPAwbWHYy+3VxWdrlkG9ZfE7/Eqm0oFzuafFCFxwVVU6H2xgRtmAB?=
 =?us-ascii?Q?1l2e1+IebAeCJFVrOKVlUL3ychEQ9jm99gWGe+IFGclm5ku/cvt/4jHT4Mib?=
 =?us-ascii?Q?6O5Ex1pT+lQUKp140n8bMKUva+/yNfrSbnBYpozzSgzf3nD2sxqwfbUNIT5g?=
 =?us-ascii?Q?j89J7QW0alJ21s/bqJzz+Mg7U6khYOd7Ahmn2LXZk2nKB9JaMvYGUiIRD2+4?=
 =?us-ascii?Q?UochIVsPsn03HPDEVH57iTDMEtqQ2cWmCjo2WpqS2BX+haPcw3mo9KcNfN5B?=
 =?us-ascii?Q?5Wn0at1c0Xk9mN5Yw3R915LqvqcbLDChiMYCZR5vFQqhDZfCVBGGeDOdTHGO?=
 =?us-ascii?Q?1v7OJBzAjezCFatJJaKpxjGULbS0CialdC1QZzgb32+RxbFZt57xbDcTyENf?=
 =?us-ascii?Q?NLC809KtWTrvwPz19ozNZhtrq4N42pwsSTQ1OHs86auh7lgKXOqCV7qJsfJ0?=
 =?us-ascii?Q?b4knH0M2qgS0NqTqp9YnU0tlGN+pHCgL9T5D6IYHXJCT076RWs2MUatXIzXs?=
 =?us-ascii?Q?3xahXFNIkFFWSYT9gVPmqiYr2sHRvPN3DTc/Q/7pBFKV63ER6bYFWKE+Xvh3?=
 =?us-ascii?Q?HxNdMLarXvr/NrwMx3A9DFIqtxoQ816j6nh8y6eEYdrKarda1YkML7+r7NFn?=
 =?us-ascii?Q?DOnuF1HhTaZSsisJJip7CqvaRoGIua5NuifkKAepuo+sQe1kyz5/c1tNfu8+?=
 =?us-ascii?Q?AkewVQNjATfqkEyyFCjWlEWY1QjkI3BZeTJTO1I3dRiKgY0eHfC3726NfaEi?=
 =?us-ascii?Q?utm/SrNRVt6QQwGxOXJd/wgL8elkMGLpy0NXKObWEsuf50kN07meF4jQ2kRo?=
 =?us-ascii?Q?TrmsNHKzZIaBfnv79Sm1YAJYraluZZwgaM78MsTDJscE38pfM5KO32MUAUFg?=
 =?us-ascii?Q?Ik5gXtAkaiKyjQbT9HBZtb+moJ19bIck5xhomd73HlLnuHO5Hltj8qOLWvhZ?=
 =?us-ascii?Q?A30HpWaiCN/meAETQKcYyK3UbNcHDgko5ItEK8cP8XlDmBvavQjGiaq0Vujg?=
 =?us-ascii?Q?yU77/NWm2hQJ8WENfnwfFPa3CwOFvqMriB5QoBRRPiG1oNSAcOSAcJJWoqi3?=
 =?us-ascii?Q?iBbIeKR1zuFtfEnXKAgZTegA/Jd+ue9BqA0dq2BnWrvtP8PWiKNKh3cbFUE3?=
 =?us-ascii?Q?55t7/iJejWsOmguo8VgVDe9Ol/P+gL99s5KP9e70uTNb1BTGkMcjO8vABm1V?=
 =?us-ascii?Q?HdaU7mbJD6a9Le04U6wTwfpFFbD+Y0X5G+c3i0RSAf2ZGsT1/mHJvB4ioWaO?=
 =?us-ascii?Q?GASCJKaZKrkrtsf9PWkWXgpOXNxkQcw+OHN/4Rv6umcG2di8NEuWd5CT1a9F?=
 =?us-ascii?Q?BqVj8Tt9khoFCjZs0WTkAKodUlIkIua7xX4U4T4jLd8y5WSqvnK2daFHbDLk?=
 =?us-ascii?Q?KLAeyQqG/WwpwGqa9eQCjm79/MF+32/XFFDG3u/iIeQKsjcTqXi3kuluGQtc?=
 =?us-ascii?Q?A44RIJwNZFMhGWHhme3Jqg7MWAN/q7roXU1Zfx+hgBoXJSRjv1kgeMq6BDah?=
 =?us-ascii?Q?r1nEtOdpVwimbxvUayqAOBDPzgOEpic44QX1g26smCIHrwmmR1uBcQqTArr9?=
 =?us-ascii?Q?5ZQ61cN09XUs8mohB9YatHo1OR1wJcVCVJdPrd/aR8dWO/0BoFAPTmuNwqsS?=
 =?us-ascii?Q?kw=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: af451ed2-83ec-448a-a0e4-08dc765b5a22
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB7374.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2024 10:23:10.7136
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WzxiOubDommI0lq05iKZrLTkHNUkeONi6wvtf7DfaW/L/pkRk3vfGOuR7JbXwwUIE/8m37l9/wEVpqC8cpYkyg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI2PR04MB10666

On Fri, May 17, 2024 at 12:18:11PM +0200, Horatiu Vultur wrote:
> The 05/17/2024 13:04, Vladimir Oltean wrote:
> > 
> > On Thu, May 16, 2024 at 08:48:55AM +0200, Horatiu Vultur wrote:
> > > > Alternatively, the -EOPNOTSUPP check could be moved before programming
> > > > the traps in the first place.
> > >
> > > Thanks for the review.
> > > Actually I don't think this alternative will work. In case of PHY
> > > timestamping, we would still like to add those rules regardless if
> > > ptp is enabled on lan966x.
> > >
> > > >
> > > > Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> > >
> > > --
> > > /Horatiu
> > 
> > I don't understand why this would not have worked?
> > 
> > diff --git a/drivers/net/ethernet/microchip/lan966x/lan966x_main.c b/drivers/net/ethernet/microchip/lan966x/lan966x_main.c
> > index b12d3b8a64fd..1439a36e8394 100644
> > --- a/drivers/net/ethernet/microchip/lan966x/lan966x_main.c
> > +++ b/drivers/net/ethernet/microchip/lan966x/lan966x_main.c
> > @@ -474,14 +474,14 @@ static int lan966x_port_hwtstamp_set(struct net_device *dev,
> >             cfg->source != HWTSTAMP_SOURCE_PHYLIB)
> >                 return -EOPNOTSUPP;
> > 
> > +       if (cfg->source == HWTSTAMP_SOURCE_NETDEV && !port->lan966x->ptp)
> > +               return -EOPNOTSUPP;
> > +
> 
> This should also work.
> Initially I thought you wanted to have only the check for
> port->lan966x->ptp here. And that is why I said it would not work.

Ok. I see the patch was marked as "changes requested". I think the
second alternative would be better anyway, because a requested
configuration which cannot be supported will be rejected outright,
rather than doing some stuff, figuring out it cannot be done, then
undoing what was done. Would you mind sending a v2 like this?