Received-SPF: pass (google.com: domain of linux-kernel+bounces-182028-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Subject: Re: [PATCH 3/3] arm64: dts: qcom: sdx75-idp: add SDHCI for SD Card
To: Krzysztof Kozlowski <krzk@kernel.org>, <ulf.hansson@linaro.org>,
        <robh@kernel.org>, <krzk+dt@kernel.org>, <conor+dt@kernel.org>,
        <andersson@kernel.org>, <konrad.dybcio@linaro.org>,
        <bhupesh.sharma@linaro.org>
CC: <linux-mmc@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>
References: <20240515120958.32032-1-quic_nainmeht@quicinc.com>
 <20240515120958.32032-4-quic_nainmeht@quicinc.com>
 <a5833628-65f3-493d-9de5-33ba87a18875@kernel.org>
 <2ed5326a-b2ea-220a-2a9b-0478df0c6f12@quicinc.com>
 <743c2a10-0ce6-4b84-8127-f3d762976366@kernel.org>
From: Naina Mehta <quic_nainmeht@quicinc.com>
Message-ID: <7a8e4e2d-8ab6-53cc-f98e-285ed22eca1e@quicinc.com>
Date: Fri, 17 May 2024 16:39:31 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.0
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <743c2a10-0ce6-4b84-8127-f3d762976366@kernel.org>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit


On 5/17/2024 2:22 PM, Krzysztof Kozlowski wrote:
> On 16/05/2024 07:21, Naina Mehta wrote:
>>
>>
>> On 5/15/2024 7:53 PM, Krzysztof Kozlowski wrote:
>>> On 15/05/2024 14:09, Naina Mehta wrote:
>>>> Enable SDHCI on sdx75-idp to support SD card.
>>>> Also add the required regulators.
>>>>
>>>> Signed-off-by: Naina Mehta <quic_nainmeht@quicinc.com>
>>>> ---
>>>>    arch/arm64/boot/dts/qcom/sdx75-idp.dts | 45 ++++++++++++++++++++++++++
>>>>    1 file changed, 45 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/sdx75-idp.dts b/arch/arm64/boot/dts/qcom/sdx75-idp.dts
>>>> index f76e72fb2072..6f94278cf837 100644
>>>> --- a/arch/arm64/boot/dts/qcom/sdx75-idp.dts
>>>> +++ b/arch/arm64/boot/dts/qcom/sdx75-idp.dts
>>>> @@ -41,6 +41,29 @@
>>>>
>>>>    		vin-supply = <&vph_ext>;
>>>>    	};
>>>> +
>>>> +	vreg_sd_vccb: sd-vccb {
>>>
>>> Please use name for all fixed regulators which matches current format
>>> recommendation: 'regulator-[0-9]+v[0-9]+'
>>
>> Did you mean that vreg_sd_vdd should be updated according to the
>> suggested format because vreg_sd_vccb is not a fixed regulator?
>>
> 
> Yeah, it should be about sd-vdd, but then this one should be named as
> well with a similar prefix to have it consistent.

Sure, I will update in next revision.

Thanks,
Naina