Received-SPF: pass (google.com: domain of linux-kernel+bounces-182029-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 17 May 2024 11:09:42 +0000
From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: Frank.li@nxp.com, vkoul@kernel.org, linux-arm-msm@vger.kernel.org,
	dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dmaengine: qcom: gpi: remove unused struct 'reg_info'
Message-ID: <Zkc69sMlwawV8Z7l@gallifrey>
References: <20240516152537.262354-1-linux@treblig.org>
 <39b66355-f67e-49e9-a64b-fdd87340f787@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <39b66355-f67e-49e9-a64b-fdd87340f787@linaro.org>
User-Agent: Mutt/2.2.12 (2023-09-09)

* Bryan O'Donoghue (bryan.odonoghue@linaro.org) wrote:
> On 16/05/2024 17:25, linux@treblig.org wrote:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > 
> > Remove unused struct 'reg_info'
> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > ---
> >   drivers/dma/qcom/gpi.c | 6 ------
> >   1 file changed, 6 deletions(-)
> > 
> > diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
> > index 1c93864e0e4d..639ab304db9b 100644
> > --- a/drivers/dma/qcom/gpi.c
> > +++ b/drivers/dma/qcom/gpi.c
> > @@ -476,12 +476,6 @@ struct gpi_dev {
> >   	struct gpii *gpiis;
> >   };
> > -struct reg_info {
> > -	char *name;
> > -	u32 offset;
> > -	u32 val;
> > -};
> > -
> >   struct gchan {
> >   	struct virt_dma_chan vc;
> >   	u32 chid;

Hi Bryan,

> More detail in the commit log please - is the structure unused ? What is the
> provenance of it being added and becoming dead code.
> 
> More detail required here.

If you look at the V1 I had
''gpi_desc' seems like it was never used.
Remove it.'

but Frank suggested copying the subject line; so I'm not sure
whether you want more or less!

I could change this to:

'gpi_desc' was never used since it's initial
commit 5d0c3533a19f ("dmaengine: qcom: Add GPI dma driver")

Would you be OK with that?

Dave


> 
> ---
> bod
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/