Date: Thu, 31 Jan 2008 22:18:17 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Adrian Bunk <bunk@kernel.org>, tglx@linutronix.de, hpa@zytor.com,
       torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: x86: Why have __copy_from_user_ll_nocache* been exported?
Message-ID: <20080131211817.GA21210@elte.hu>
References: <20080131201430.GA9375@cs181133002.pp.htv.fi> <20080131130529.b0e17815.akpm@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080131130529.b0e17815.akpm@linux-foundation.org>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1093
Lines: 27


* Andrew Morton <akpm@linux-foundation.org> wrote:

> > A commit that does nothing except for adding two unused 
> > EXPORT_SYMBOL's.
> > 
> > Without any rationale why they should be exported.
> 
> Don't look at me.  This has been sitting in my tree for nearly two 
> years as part of the reiser4 patchset.  It may not even be needed any 
> more.  I guess Ingo went on a fishing expedition and liked the change.

yes, i picked it up from -mm (as can be seen from the SOB line), and i 
agreed with that change regardless of the reiser4 patchset. (which might 
never see the light of upstream acceptance)

there's nothing more annoying than incomplete and inconsistent APIs. I'm 
trying to fix them up everywhere i see, and this is one of those cases. 
Adrian still has not given any rationale about why he wants to see the 
export removed.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/