Received-SPF: pass (google.com: domain of linux-kernel+bounces-182175-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 17 May 2024 10:16:13 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Linux trace kernel
 <linux-trace-kernel@vger.kernel.org>
Subject: Re: [PATCH] tracing/treewide: Remove second parameter of
 __assign_str()
Message-ID: <20240517101613.0584c291@gandalf.local.home>
In-Reply-To: <87eda0c3uk.fsf@intel.com>
References: <20240516133454.681ba6a0@rorschach.local.home>
	<87eda0c3uk.fsf@intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 17 May 2024 10:08:51 +0300
Jani Nikula <jani.nikula@linux.intel.com> wrote:

> On Thu, 16 May 2024, Steven Rostedt <rostedt@goodmis.org> wrote:
> > There's over 700 users of __assign_str() and because coccinelle does not
> > handle the TRACE_EVENT() macro I ended up using the following sed script:
> >
> >   git grep -l __assign_str | while read a ; do
> >       sed -e 's/\(__assign_str([^,]*[^ ,]\) *,[^;]*/\1)/' $a > /tmp/test-file;
> >       mv /tmp/test-file $a;
> >   done  
> 
> Try 'sed -i' ;)

I've always been nervous about trusting -i ;-)

> 
> >  .../drm/i915/display/intel_display_trace.h    |  56 ++++-----  
> 
> On i915,
> 
> Acked-by: Jani Nikula <jani.nikula@intel.com>
> 

Thanks,

-- Steve