Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp996353lqo; Fri, 17 May 2024 07:50:20 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW0facygvROTAQ4/w83wdWD0AcJGGJaognrJJ8HkM7LnO0AV8ZCu10kF0tdon1sO4Tae3svsDSIBwznkAZKKgHgkFIyqDYZojRZYaVSxA== X-Google-Smtp-Source: AGHT+IEbSfBETOY/sjz1/p/IJDBFcVulb2mEDAJdWo2gRFYr4jo43DHwhxh+kPlKP+Grwzj/vOus X-Received: by 2002:a05:6214:3b87:b0:6a0:e381:daaf with SMTP id 6a1803df08f44-6a1692dabf9mr404327236d6.18.1715957420024; Fri, 17 May 2024 07:50:20 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715957420; cv=pass; d=google.com; s=arc-20160816; b=g/kl3MIOv+ZDBjVip4Tq2AYkjf1AOp5+HyyQ5485aZFBVV+gFi67Wp9RNwmwx/gcin x1OuqAJ2Pr02Equo/xke8wV/RDrA2jXRp51OBkMVONoNN0I9sdVRFTltDoTBDRNH0BZD eExdtQi/YzDU7WETG5d5w49khf9/AIPE7YvgTcGRyLg4BEtJTxEbrQfZx7UmHXEUK2PJ ogH14ncPmJF6bnT1V87q7MzR/LnGbpQtpz8unG57f8A1B1JSEFkH30yaae8um4fXx5bU GXpMYZTauiAG1ethn6bLvJPzSmV+ZrkWkSbOKNwuji/jyTf0P6YTGaOkdTuwsFgXVtCp nJHQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:mail-followup-to :message-id:subject:cc:to:from:date:dkim-signature; bh=ZLjMTcq7/ZFNTdNivNN26gmdDNwnrL40lhfEgqQilyA=; fh=oURRkDDYE8Tg8skqeY+q4cXBP2Ru5FuzW8EMtF6WQLU=; b=ZVIiERfz7snk13eEUWzAcMVYteRYG6fVps1Gb9BX8B7WmQZE8pm2hEzsBQEi5p6O41 Hs7D9U0Wl0sKoLg9H/zV4dUN3swgMWEinLUpZw62C+++dU4eDvUWmRinrq/XqXJP+Ivn CkTZXpsHS5dQEy+EpMksuUWfMe9uzEXKJfSBIde2hXg4ZSo4qP5MKjZPAl1SUE2KNw+K RMajf3LaUyw0q5j5u1ao0TNwN9SsmhI6NUfqVdb6H/9forXaXAw+x4ul1lxpQiYxxvLG YsKtAQZ0qfOrTlwMhZldBwIgMEVjPhrIs3Ze8LWCL8y/AV9ttAWiEy+pmoEtiqHPzMiG TdrQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@sang-engineering.com header.s=k1 header.b=T6OLDccb; arc=pass (i=1 spf=pass spfdomain=sang-engineering.com dkim=pass dkdomain=sang-engineering.com); spf=pass (google.com: domain of linux-kernel+bounces-182233-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-182233-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id 6a1803df08f44-6a365026ccasi38030186d6.231.2024.05.17.07.50.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 May 2024 07:50:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-182233-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@sang-engineering.com header.s=k1 header.b=T6OLDccb; arc=pass (i=1 spf=pass spfdomain=sang-engineering.com dkim=pass dkdomain=sang-engineering.com); spf=pass (google.com: domain of linux-kernel+bounces-182233-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-182233-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 3E4211C245AE for ; Fri, 17 May 2024 14:49:38 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 71BCF65194; Fri, 17 May 2024 14:49:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="T6OLDccb" Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77528846B for ; Fri, 17 May 2024 14:49:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715957370; cv=none; b=ncBxkqaVPosnTwBgK3XdciyO7sIxTfZ8TI9vJt0//rJpRbnUN6F5VIMQWqGBbzkqhEo/TeUTAOxZ9GceTnCluUm7sWIPlKM8KSDjbwHN/rbc7NF9t1AaUgbTUTiO3zhI8iFdaOePfsG9AcGpiAMYkgeNDse26VgconV+fXoOR4k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715957370; c=relaxed/simple; bh=Oxw+nuKA9rnYPKRIGfenJc3ay8ovsXLycrgw3KYUz34=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iy8IGMwnbQjzTRK6DjrmPmGGtill6PR6906FRAai6NmsisGspupwTXgrzV6K4VbgrRwmohcYUDbuf6L3i6blsG5zCVBp62ad4KfkBF3fsSggyFjp+x/ujXOXZdFD8NgiWUnYfXiZsJ4LF2FMvlJvOss1hicArcGgJCVA8KJQiWI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=T6OLDccb; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to; s=k1; bh=ZLjM Tcq7/ZFNTdNivNN26gmdDNwnrL40lhfEgqQilyA=; b=T6OLDccbTOBPHNx85Yb3 7LHMIiuVJHeHnrh438m6msQG/HAx8iQFzcLrd6zD7Dzk5c1Sr0+y+DVpBqTqjmHL FieA/7DcfMK77UgOq+bP+5HOj/CU0zuOEYYA4fPHGZuFBtOBwwCJpFYFT7ljhi00 SwFWhtStET0DVJoPDhZM8S3RdwyYhrJordDhjjznT1+85Y4/4uUWTpVRMphrCZX1 dkF9RyBmt/iBlNWeZtF+ecjSN9umVrMplQBo75rhBI6Q9eTcdT4QewNodO0NbVS0 Dx5rFr1bjjKUKUQkyQIDJE2tAFfERuKgQHqFxdntzgqYzBkPiKS3DxHFadJWflyI PA== Received: (qmail 3527947 invoked from network); 17 May 2024 16:49:20 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 17 May 2024 16:49:20 +0200 X-UD-Smtp-Session: l3s3148p1@At/tdKcYlqVehhtP Date: Fri, 17 May 2024 16:49:20 +0200 From: Wolfram Sang To: Alvin =?utf-8?Q?=C5=A0ipraga?= Cc: Mark Brown , Greg Kroah-Hartman , "Rafael J. Wysocki" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Bartosz Golaszewski , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Michael Turquette , Stephen Boyd , Andi Shyti , Saravana Kannan , Emil Svendsen , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-sound@vger.kernel.org, linux-clk@vger.kernel.org, linux-i2c@vger.kernel.org, Alvin =?utf-8?Q?=C5=A0ipraga?= Subject: Re: [PATCH 04/13] a2b: add AD24xx I2C interface driver Message-ID: Mail-Followup-To: Wolfram Sang , Alvin =?utf-8?Q?=C5=A0ipraga?= , Mark Brown , Greg Kroah-Hartman , "Rafael J. Wysocki" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Bartosz Golaszewski , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Michael Turquette , Stephen Boyd , Andi Shyti , Saravana Kannan , Emil Svendsen , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-sound@vger.kernel.org, linux-clk@vger.kernel.org, linux-i2c@vger.kernel.org, Alvin =?utf-8?Q?=C5=A0ipraga?= References: <20240517-a2b-v1-0-b8647554c67b@bang-olufsen.dk> <20240517-a2b-v1-4-b8647554c67b@bang-olufsen.dk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dorvg4mucua5ph6e" Content-Disposition: inline In-Reply-To: <20240517-a2b-v1-4-b8647554c67b@bang-olufsen.dk> --dorvg4mucua5ph6e Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > + /* > + * Enforce some basic assumptions this function makes about the > + * transfer. If this proves insufficient, some more complex logic will > + * be needed. > + */ > + if (num > 2 || (num == 2 && msgs[0].addr != msgs[1].addr)) > + return -EOPNOTSUPP; As you populated 'ad24xx_i2c_adapter_quirks' in the I2C driver, you can drop this. The I2C core will do the checks for you. --dorvg4mucua5ph6e Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmZHbnAACgkQFA3kzBSg KbZ4cw//UnCNrCAjv+QHEiqmbznWqnH2N8ZbotvveAWo1o9CG2q5H7qtEMABxRJM Ga0FDhpW815gVCjjjeMQ4d3e7g3rE3kutQOSqPXquB6BbOzYMU2NI3MRnNyuZ4GU vi8VQ0LO4fpUtK4VimfSXF60MeI2M6dSf7KYx9vd5GG30nlfv3Uru82dzxi4b0WV bk6tIaViAK4sNvKAnK+WDZnEhptZ3Fpzi0TNjAuqvPWoL61SAAZCvwzrFcbnlenY Nia81UoDvKT8vi3I9ckhi0QUV6gU8xec4DmkUZDRhi8W4pmBtfto2Lo+nQcLkpVH UcDB2ZDKfjlRvoIDuPLOhdL2vkl5l5weVVU0X9/cQ9Ej8Iv+KiNhNep5GfMisCw0 I0MUtQEtvxr7O3Pa4J+AEVfDPojmY1pSPMidxrVwmrClN11LQQmroplAbyFBLDER lziCL5EkExgbguvmWsZpDPzTJUCmanXrvTJiFnAOptbzkShNNvpCnvj/HALU4T1d biP5v5CMroDnOQZNK5RwrPVj0fKp1gYnkW/CAd15Hl/YzIcfjvpR+qeBozJsxSAP s+2EgsMRGyDpAkm0Y7S5eSAzYdfFq4qAzYarLMCq2PNWFFkmBVltklW5VF1kneXG o4b1vZNEfzEu1+RlbOF9UcKRpti0s4s8Qp4lc1bpgfozWNh86S0= =x2If -----END PGP SIGNATURE----- --dorvg4mucua5ph6e--