Received-SPF: pass (google.com: domain of linux-kernel+bounces-182245-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <bf67346ef623ff3c452c4f968b7d900911e250c3.camel@gmail.com>
Subject: tpm_tis_spi takes minutes to probe
From: Vitor Soares <ivitro@gmail.com>
To: linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: jgg@ziepe.ca, jarkko@kernel.org, peterhuewe@gmx.de,
 vitor.soares@toradex.com
Date: Fri, 17 May 2024 15:53:22 +0100
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu2 
Precedence: bulk
MIME-Version: 1.0

Greetings,

I'm using the tpm_tis_spi.ko module and it is taking several minutes to pro=
be on
kernel:
 - commit ea5f6ad9ad96 ("Merge tag 'platform-drivers-x86-v6.10-1' of
git://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86")

root@verdin-imx8mm-07317726:~# time modprobe tpm_tis_spi=20
[   57.534597] SPI driver tpm_tis_spi has no spi_device_id for atmel,attpm2=
0p
[   57.560684] tpm_tis_spi spi2.1: 2.0 TPM (device-id 0x3205, rev-id 1)
[   57.584943] tpm tpm0: A TPM error (256) occurred attempting the self tes=
t
[   57.591797] tpm tpm0: starting up the TPM manually
real    8m6.438s
user    0m0.007s
sys     0m0.013s

..And after probing, sometimes the system becames unresponsive.


I did the same test with kernel:
 - commit a38297e3fb01 ("Linux 6.9")

root@verdin-imx8mm-07317726:~# time modprobe tpm_tis_spi
[   53.643744] SPI driver tpm_tis_spi has no spi_device_id for atmel,attpm2=
0p
[   53.668404] tpm_tis_spi spi2.1: 2.0 TPM (device-id 0x3205, rev-id 1)
[   53.692997] tpm tpm0: A TPM error (256) occurred attempting the self tes=
t
[   53.699879] tpm tpm0: starting up the TPM manually

real    0m2.809s
user    0m0.001s
sys     0m0.022s

I tested on kernel v6.8 and same it takes same time. Do you know anything a=
bout
this?

Best regards,
Vitor Soares