Received-SPF: pass (google.com: domain of linux-kernel+bounces-182220-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Fri, 17 May 2024 15:42:31 +0100
From: Mark Brown <broonie@kernel.org>
To: Alvin =?utf-8?Q?=C5=A0ipraga?= <alvin@pqrs.dk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Andi Shyti <andi.shyti@kernel.org>,
	Saravana Kannan <saravanak@google.com>,
	Emil Svendsen <emas@bang-olufsen.dk>, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-sound@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-i2c@vger.kernel.org,
	Alvin =?utf-8?Q?=C5=A0ipraga?= <alsi@bang-olufsen.dk>
Subject: Re: [PATCH 02/13] regmap: add A2B support
Message-ID: <49cd7b8e-d104-4136-bf7d-7eb45725c596@sirena.org.uk>
References: <20240517-a2b-v1-0-b8647554c67b@bang-olufsen.dk>
 <20240517-a2b-v1-2-b8647554c67b@bang-olufsen.dk>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Qt8EKyDk+1Qw4HPv"
Content-Disposition: inline
In-Reply-To: <20240517-a2b-v1-2-b8647554c67b@bang-olufsen.dk>


--Qt8EKyDk+1Qw4HPv
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, May 17, 2024 at 02:58:00PM +0200, Alvin =C5=A0ipraga wrote:

> +static int regmap_a2b_write(void *context, const void *data, size_t coun=
t)
> +{

> +	for (i =3D 0; i < count - 1; i++) {
> +		ret =3D bus->ops->write(bus, node, reg + i, d[i + 1]);
> +		if (ret)
> +			return ret;
> +	}

Just force single_read and single_write (looks like you'll need to add
the hook for the bus there).

> +struct regmap *__devm_regmap_init_a2b_node(struct a2b_node *node,
> +					   const struct regmap_config *config,
> +					   struct lock_class_key *lock_key,
> +					   const char *lock_name)
> +{
> +	return __devm_regmap_init(&node->dev, &regmap_a2b, node, config,
> +				  lock_key, lock_name);
> +}
> +EXPORT_SYMBOL_GPL(__devm_regmap_init_a2b_node);

Should there be validation of val_bits?

--Qt8EKyDk+1Qw4HPv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmZHbNcACgkQJNaLcl1U
h9DP5Af+OAUcNbSUZNsBiGMNoWWL9BqTN9x5hsblj8pit+bjIa6k4Un5NW4To/Tz
lpxrs+5G210GiKB/Pce3ysC61iSyxxAEtYi+WxNbUTNgMXcEcxXlA7REku4GaqUB
aBg6LevsX756RuU7lTJaIyYZigD0X5a8s1MOqFbRVsTI9cMRvDM/65Gxvp61+ea3
IrLkn49TOwHAfk66W7il6diBi4ZLseiGII8I+i0wanPqNauRyXFN9l4pnZW4AtLt
HI64kfng1cRujCp9NSDUwYoo5xabgTY1129pRNHsy+qr0alqiTt0GMabpNRqiAxl
pqz9+CYAZjxgLgtP7zyeEuFFmao9wg==
=hWRE
-----END PGP SIGNATURE-----

--Qt8EKyDk+1Qw4HPv--