Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp1017216lqo; Fri, 17 May 2024 08:20:09 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW3LtEt+awacksjvIgnrWxXVQhTUdAnNqkAhN4fh6Y1DBPnllMAvwyJUZ7JRMTrWqPMfPsaie0VImQgmbWLIEbsbB7EujJQdQvTN91GeA== X-Google-Smtp-Source: AGHT+IGKo2h5xduUeHLbOzHd6F+xyG2KfF7Pop+6IvceB8BMDnss17UYTZupZ0EpaIWZvrdUaqpf X-Received: by 2002:a92:cd82:0:b0:36c:5efe:9bf3 with SMTP id e9e14a558f8ab-36cc14bd744mr350451295ab.23.1715959209552; Fri, 17 May 2024 08:20:09 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715959209; cv=pass; d=google.com; s=arc-20160816; b=ecbPIu8EBBBpZWUriBJQmLBACB3+PO3MUJLwyNSKeh+o/4PgPJG0BjatWVE5GnQSc9 58Ws+X3ZupFKMOn+AwGma9BOYn2zK20dAC4a87jojZHFpIatpPIY4HR8WZeAlhcv3c0G UYMotUUT5uGHmhoA64dSvcELR7Hf26lxpwZ7dcBoma3EbUk6oInKMbhvyCEr6DWtQU1J ZffgnQHzHMwHRI8jXHMYMtreBrneipd15ZbobZpQ8XiBjmIJ/6ytIeCq5vCkNXbNH5T0 GXkxcJ2vJtnaDTk9IDWVNjGFqq+J4jPHE7RLBMn6GyQpK3wHeXE0f0BFiNR6ST6ujjpM pw6g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=FRfY7PNsNolLHVPebXBFIt39vi3+YTyqUPo6nMh5ub0=; fh=kxj3FgmpbGW9owB1VqUdlVzWwNMG2usRYhSXFsLAAIY=; b=NNfwAjYSFSufbYrpPx8uOdX46fYfwxAtdioGQ24RwVWKQdUyACdSOz1bp0jkJqJYbk aURfbUOAXEDuMoNjev9aHT0utWA2Iu2BoZuo19wdCR0rEAZ01fj9tAdK5XMbPdQNEM2Z fe7HVp/1sTbVIYnnS6kD8l1LghCjkWpIvEau+P76gILhEiCJSHpwVnNf6c+eRcGnboOQ EeSLysBhDginQAk+o4+bdR1R6MEVC7lmOOJdANpB0uiAksG2L0/bfany+obD6yKD/jii yh6Va4taxOc8TgXajPfl0gpRiWZKG+hxJpW3orsQBlj2tALkxws97qpNR6Vo/MJbqjZG FxUA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=aEZEz9sT; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-182281-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-182281-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id 41be03b00d2f7-6340a632530si17613769a12.83.2024.05.17.08.20.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 May 2024 08:20:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-182281-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=aEZEz9sT; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-182281-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-182281-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 7941C2860E5 for ; Fri, 17 May 2024 15:18:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A23BA12D755; Fri, 17 May 2024 15:18:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="aEZEz9sT" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC29512D1EF; Fri, 17 May 2024 15:18:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.15 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715959113; cv=none; b=imcqxGbTTxegakOIo6lMi+GaXUP2HPI//WY9bkTZBGeQ3nU7Aj5JKuqLKP+gLXlgEahbrd5B9rFVSknC7mBczL3Ym/RNsYO+EyCRiijOCUi4t9SciiGH9Cu8oyNMUFc+SB6XxhfwvfCWdAxq/jC0rYbM9JhR9FoGiyRFAl+oLA0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715959113; c=relaxed/simple; bh=T9GQWbhT4UmQtK64OZ6UxRaZXk6G7MbRm/XQXvD53qA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tc8EbJDsdWY7XBaSTzUXDOGP34/jDpX0JIio90hLBHN4GDpzvDBSAJcNiv8nnkKzQwKZ6Au4RtJhtFm1w71AF5KLReIANBHjz+87yWNG+cjJXiOi3OS/zcQnKyK9aphA9Dc5Ev0UCnuYcyP6gj3ar36b1s9lLs53kobFHEHaDD0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=aEZEz9sT; arc=none smtp.client-ip=198.175.65.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1715959112; x=1747495112; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=T9GQWbhT4UmQtK64OZ6UxRaZXk6G7MbRm/XQXvD53qA=; b=aEZEz9sTV0TRB2moW0d7hvSYM1qI9b0pvZiKtTW5gGpx84Y6QFlN3gMQ ZimssA9OvEdgcx/EOISabVaTpXJkH1WJ00cW0y7DbL6vIYW4Mz28XxrbE kk/cLB903S2DLn9aHdHhZt9pddHwUF4JKL3b9v60STBDWhFpvTjdLlB4z KCYEi7QQSOtStANPhDc8vG2VsaZC8lWhmJemhH55q8BSl8e06LQL+Rv00 jEkWNrjkVyXErqT1+Ixx+YcS7ISa7kHJGj738iVhp9EayB+Sw5ekHNfuw Tfe8kjimAtdK0qucPn54DH4uoSTfqDExkSCGpjkLFlNcSp0CBG8q3D7uE Q==; X-CSE-ConnectionGUID: nTI3+mSNRnGd3rDZVqMVCg== X-CSE-MsgGUID: Y0P/8gjgS8Wl0wS6iVUPqg== X-IronPort-AV: E=McAfee;i="6600,9927,11075"; a="15930212" X-IronPort-AV: E=Sophos;i="6.08,168,1712646000"; d="scan'208";a="15930212" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2024 08:18:31 -0700 X-CSE-ConnectionGUID: 4LzS0qkVTx+ojVmtkWESEg== X-CSE-MsgGUID: Y9Q0YWuySzqYwbFEYozPDQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,168,1712646000"; d="scan'208";a="36236912" Received: from kinlongk-mobl1.amr.corp.intel.com (HELO [10.125.108.204]) ([10.125.108.204]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2024 08:18:31 -0700 Message-ID: Date: Fri, 17 May 2024 08:18:29 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/20] x86/tdx: Rewrite TDCALL wrappers To: "Kirill A. Shutemov" , Sean Christopherson , Paolo Bonzini , Dave Hansen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Josh Poimboeuf , Peter Zijlstra Cc: linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org References: <20240517141938.4177174-1-kirill.shutemov@linux.intel.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20240517141938.4177174-1-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/17/24 07:19, Kirill A. Shutemov wrote: > arch/x86/boot/compressed/tdx.c | 32 +--- > arch/x86/coco/tdx/tdcall.S | 145 ++++++++++----- > arch/x86/coco/tdx/tdx-shared.c | 26 +-- > arch/x86/coco/tdx/tdx.c | 298 ++++++++---------------------- > arch/x86/hyperv/ivm.c | 33 +--- > arch/x86/include/asm/shared/tdx.h | 159 +++++++++++----- > arch/x86/include/asm/tdx.h | 2 + > arch/x86/virt/vmx/tdx/tdxcall.S | 29 +-- > tools/objtool/noreturns.h | 2 +- > 9 files changed, 322 insertions(+), 404 deletions(-) I was going to grumble about this being a waste of time, but it looks like this gives smaller binaries and less code. Looks promising so far!