Received-SPF: pass (google.com: domain of linux-kernel+bounces-182284-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <dd7d2f53-3b58-401f-81b1-1690d5d88e51@intel.com>
Date: Fri, 17 May 2024 17:17:43 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net v2] net: Always descend into dsa/ folder with
 CONFIG_NET_DSA enabled
To: Florian Fainelli <florian.fainelli@broadcom.com>
CC: <netdev@vger.kernel.org>, <stephenlangstaff1@gmail.com>, "David S. Miller"
	<davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski
	<kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Vladimir Oltean
	<olteanv@gmail.com>, Florian Fainelli <f.fainelli@gmail.com>, "Alexander
 Lobakin" <alobakin@pm.me>, open list <linux-kernel@vger.kernel.org>
References: <20240516165631.1929731-1-florian.fainelli@broadcom.com>
From: Alexander Lobakin <aleksander.lobakin@intel.com>
Content-Language: en-US
In-Reply-To: <20240516165631.1929731-1-florian.fainelli@broadcom.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZUI2dzM2Y2FXOVhVWlRRbjVlcHI3Wm5xYVFrL0EwTCtyYnJ1NnNHTXZSQ0Mv?=
 =?utf-8?B?UnhPVVJ4Mm9yamg5RFppTWhkajVTY2h4S2F0U3ZFN1pTdkFWblVsamZHNlEx?=
 =?utf-8?B?Q1RYT1NZMllFbjBVNllkeWh0TStsbkN3OXdtZENRd2IrWEdzT05PekYwZGNB?=
 =?utf-8?B?ZStzSmxUTUxVNjVrbmFpSVdwdzlzUXppdkVmUkZFVmdzT0g2WDZBb2twc0Ew?=
 =?utf-8?B?eGlWZHVsNkFwclUxMGx4dmkrWnFDMVNZQlZEVThtWGxzNTJtUTZzYWlOcHYw?=
 =?utf-8?B?WS9hNFVJdnpuQjJoaWJSR3NNcGtuSWQ1SGFqYkFKL3hQUWE5MGd2VFJGdUNU?=
 =?utf-8?B?N3BMNnp4dUpuTHk5RjBURGVvaU54TVF5Si95Q2FFdlpyVWUrQkoyd2MyTHR0?=
 =?utf-8?B?VE10cnB4c2h4WVhIQ0c2dW9FTklMeEFPMkNXNGkrNjg5Tlc5d0NpbS9LaGho?=
 =?utf-8?B?c3BITkFEZDE0UURuenNMNFNYVDNnYTA0Z3lhcHdBWjFDdHc3bVE1QVpscnRD?=
 =?utf-8?B?K29BZVFNUjVCa1pBQnhXRkFFU0pURFpFZldDZnJLa1diMGxVaFgrK2lmbDlF?=
 =?utf-8?B?VTdsWFcxVzBRM1dlNTg4MjJZSHQ1TlFqNDFHWGVnS2c2bTJBTnpFa2FhN21M?=
 =?utf-8?B?Wk9xZFlDcHdvNWFpeTh5YlUvREZMSHpwMGxFNHU2czdxdk9YZHBYRlFuWW9C?=
 =?utf-8?B?TzhlaThwMVhIU1MveUFVbU10U2pwVkhhQWRMN0dCRUM2TnRPNzZaYjNrNjJO?=
 =?utf-8?B?TndzVkN1Y0kyUklYTTBhSWNlNEJHaStScTdPSGl6a2NaNmhFdUY2cVRWczlC?=
 =?utf-8?B?dGh2aVhGckpneGJQZEZGTENWME80b2hNRllQTlVIekxJUC9POGlncEduSEEx?=
 =?utf-8?B?akR1UXdxNW1lMlV2Z3NyUDdIaTdMd1VnV3ZSOFYydHdqNGUyVlhXWTJKWWM0?=
 =?utf-8?B?M0dReE1kVUFkRjdhYnI4VVUvRWdPUE9GVXRmN09mVy9ydktGVmhwU1pEQnFQ?=
 =?utf-8?B?ZmJmSVNCU1dQTFh5ZSt3Um80aCtVTmQvQjRQelhQRGl5MkxWaXFsTEtMMlBM?=
 =?utf-8?B?MUxrbjV5blBRRkRDOFVPLzIvc3RjLzdGVE9uaEhPWEFLWnJWOHRST0gvZ05Y?=
 =?utf-8?B?RXp1T3ZwTk5QU3pEUWMvSXR3UnRvdk1mcmNiVHQySHB4bHczWnYzUTJrU1gw?=
 =?utf-8?B?VFpFVDdVZ2pNOEVJcDRnN2NMMHk3Ky8xclJNOXZJSTJpT1VBbFBzNm9WbzlZ?=
 =?utf-8?B?ME1Nbk5UaHFnUE1hL0JzSXdZWlNoMmdIVzN2TUxIWm5aVU9HUTdLQW9QdUdR?=
 =?utf-8?B?VGl0R1lvVGVmR1RTQitRUU5LeUxwQU82N0VTaG1ySG83T28zc0o3YTBSQU1V?=
 =?utf-8?B?ZnZvcFBDb09OUUZtREthdW02UHZGSFEvZjZHUVFpUkNpOHNuYkZOMHJmLzVG?=
 =?utf-8?B?ZHFTMzhuMWZ4K1VEb0YvRzBoMU43MkJSZytvV1o4YUZWamNyRkU4SlVvUnZv?=
 =?utf-8?B?STRXV3BIWWd5YjE0NXJyZFk0VXRueG5EWE5XMXF6aFRFanBZNHBWNmNNY3JH?=
 =?utf-8?B?MmhLMU1jSW1UOGsxbzhxWENMTjJSOFpLc3Z2U1VRcE9tOWloazlVelB2blFP?=
 =?utf-8?B?WUFhdFlKZnRPWWhpK0FudFhFdCswTWU0bWFzZHJrVm5OOERGL2JhS0dVcXcv?=
 =?utf-8?B?S3YrL21EbkYyZzROQU9QaE00OWFwZk43Y1g2NDhBYkNrU3QwSEs4Y3pUdUVi?=
 =?utf-8?B?NGxyTmxXb21nZ1dzWXBSZ3NXWTlMdkpScmFIVWdlc2l0RGQ5c2R0blZqMDFw?=
 =?utf-8?B?TmNFa2lxNEx1djBTMnlzK1d1b1djSlIzOGM0VzNYZzQ1ck53azI5Slg4Tzht?=
 =?utf-8?B?VEpaUXk5RzVEbnFCQlliQ1RidGlQS3ZJV3VaQ3h4dkZKbFJxeVRidTlWcnZl?=
 =?utf-8?B?VUl6am1lOWFvTjR1Ym1pZHB5eEIyYTNCS2FZVFdFWUd6MHl5R1A2b3hhMnYr?=
 =?utf-8?B?R3kxWDBNSFhsd3g4TnkrZ3JhQmcwYnpwdHIyUzg4MExQak15OUd0ZEloWDlC?=
 =?utf-8?B?MWhtY2NuOXpQR1hCWVQ0emliMGQzYjk1UHVNcWZxR0J2ZDhiWUNvRmxzbTNF?=
 =?utf-8?B?UEpGSjVEenBLRks2NkFHYW5FbWZyRitWTEhxSk9NN2RJUWU3dVptNDJOU2V2?=
 =?utf-8?B?Umc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8b06403b-c83a-47a0-f892-08dc7684ba6e
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB8718.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2024 15:19:21.7673
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6F0T2whEtapeccaloX0OBFS+7vxMJFaPmAulUNgerypjWizGlG2kA8Cblc651ug1RWTX5A+ejjkspENJFaDH5DN62dDLPKxj3IAV66QQFic=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB8422
X-OriginatorOrg: intel.com

From: Florian Fainelli <florian.fainelli@broadcom.com>
Date: Thu, 16 May 2024 09:56:30 -0700

> Stephen reported that he was unable to get the dsa_loop driver to get
> probed, and the reason ended up being because he had CONFIG_FIXED_PHY=y
> in his kernel configuration. As Masahiro explained it:
> 
>   "obj-m += dsa/" means everything under dsa/ must be modular.
> 
>   If there is a built-in object under dsa/ with CONFIG_NET_DSA=m,
>   you cannot do  "obj-$(CONFIG_NET_DSA) += dsa/".
> 
>   You need to change it back to "obj-y += dsa/".
> 
> This was the case here whereby CONFIG_NET_DSA=m, and so the
> obj-$(CONFIG_FIXED_PHY) += dsa_loop_bdinfo.o rule is not executed and
> the DSA loop mdio_board info structure is not registered with the
> kernel, and eventually the device is simply not found.
> 
> To preserve the intention of the original commit of limiting the amount
> of folder descending, conditionally descend into drivers/net/dsa when
> CONFIG_NET_DSA is enabled.
> 
> Fixes: 227d72063fcc ("dsa: simplify Kconfig symbols and dependencies")
> Reported-by: Stephen Langstaff <stephenlangstaff1@gmail.com>
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>

Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>

> ---
> Changes in v2:
> 
> - conditionally descend into the dsa folder based upon CONFIG_NET_DSA
> - change subject a bit to reflect the change
> 
>  drivers/net/Makefile | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/Makefile b/drivers/net/Makefile
> index 9c053673d6b2..13743d0e83b5 100644
> --- a/drivers/net/Makefile
> +++ b/drivers/net/Makefile
> @@ -49,7 +49,9 @@ obj-$(CONFIG_MHI_NET) += mhi_net.o
>  obj-$(CONFIG_ARCNET) += arcnet/
>  obj-$(CONFIG_CAIF) += caif/
>  obj-$(CONFIG_CAN) += can/
> -obj-$(CONFIG_NET_DSA) += dsa/
> +ifdef CONFIG_NET_DSA
> +obj-y += dsa/
> +endif
>  obj-$(CONFIG_ETHERNET) += ethernet/
>  obj-$(CONFIG_FDDI) += fddi/
>  obj-$(CONFIG_HIPPI) += hippi/

Thanks,
Olek