Received-SPF: pass (google.com: domain of linux-kernel+bounces-182294-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 17 May 2024 11:24:57 -0400
From: Frank Li <Frank.li@nxp.com>
To: Laurentiu Mihalcea <laurentiumihalcea111@gmail.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Lee Jones <lee@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Liu Ying <victor.liu@nxp.com>,
	Sascha Hauer <s.hauer@pengutronix.de>, laurentiu.mihalcea@nxp.com,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] dt-bindings: mfd: add schema for 8ulp's SIM
Message-ID: <Zkd2yQ02+VHs54zB@lizhi-Precision-Tower-5810>
References: <20240516204031.171920-1-laurentiumihalcea111@gmail.com>
 <20240516204031.171920-4-laurentiumihalcea111@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240516204031.171920-4-laurentiumihalcea111@gmail.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?fDeYoLNcXaPd2u3ddsj7nzc72ebw2GDuB2CqvxM/ETx9Q0lUt4tAzp9KAZvN?=
 =?us-ascii?Q?U8S8b6IcIpkDGTPuZdNoQPByze92B4RWyyuL6IsFLbb2EUs01HnWGW7jy2z+?=
 =?us-ascii?Q?vKh0J8rSv6pHiC3Yo9SIgEcLDfIc+cOg5lmAqMLJyu8TJuCgalkSyMSwKTb3?=
 =?us-ascii?Q?2ibH7+YUB39x8Apzs5CLHKCw8qiIHIS6EN1eZ3DpZFz8wCfv7JHiCPsg1mZO?=
 =?us-ascii?Q?OIOS7YdsM/HuwV0HoJuzfQEHCV5PyggKWchIgA53jOjeIgE7M+h054oab96/?=
 =?us-ascii?Q?8uuRHfGdrv4NG+EPQJnhxWNsvZgME96pnwult5NWkuRw9uqvtx/IovrFhzyS?=
 =?us-ascii?Q?onRiz0xEcs57obrcfnKi6CZcNLu9EWhaIWRzbGYeM8seL1BgFMu2XkbDRAQs?=
 =?us-ascii?Q?fZe1xYziQvENKbvYWGpibnFohKDKqrPPArgHq0CvyioTeFiL0oDR6zu1BfYY?=
 =?us-ascii?Q?DcWKxqt8Sifk6+YkHDWZC/Fxwyfhzv1iX/mufpPSb2KMk42mp1w5oe6nT8ov?=
 =?us-ascii?Q?e3iBzicPV6hVW2u9PxfudbW6QgtiNg1sAAAyZP26C/cu8SfZASPcoI09PkyM?=
 =?us-ascii?Q?0VQ6OlpZW01fHr21iOc8EaTkenX2vZbBIRKZS6qRSJVJ+t1rrVY1JLU1BdWB?=
 =?us-ascii?Q?dd882FTkQ0FeOSLergr7eikl3MNKgHBm7S+u2+vOA61VMa/ADHf9HqGRbkC5?=
 =?us-ascii?Q?/5bchBn8w8InvVIbZpXIm9lC5E0iYr2+LqrXW3SbN09lHf8Qj423CBChcMnR?=
 =?us-ascii?Q?SIawDCeJVU5Cg3EJRR+q/v12Qm8mU9bEF6jESYq+nVRJi/dPf+6G2UeRrCBw?=
 =?us-ascii?Q?epbTrZ/D8ZrVpmTITgKCWHAGT3LeCgkDz5xrs9ojdC1MIgUbnY/WCDF2Ac9p?=
 =?us-ascii?Q?ppFIOlnd4mIYJmc74w8EZmn5z3mfEthR0DvOd7BWGDhp2yWsZUBR8DCl+hgD?=
 =?us-ascii?Q?8oKo8ciuWwsjxcu1R6y5jabAJuXcxTUUaFOSdQzml5L23RyPCkd3m3yILC8t?=
 =?us-ascii?Q?N3W/zC8Uz92CkCIDUJ87FM2e5un4m3lVjoMXbI7KlKSz/s/5OJ9DInU+iXOJ?=
 =?us-ascii?Q?0XzwZM5+WuUSuz81TL6q+PsOh4crEbW1/bzgHgx/TADmeBxeHwWuDPJBCc6K?=
 =?us-ascii?Q?uWRasyzflsEcsoVmmhmrSArtQUTFZdIrHTBMs1UpKpHnlfVMr4SJHAVjm/si?=
 =?us-ascii?Q?xrCvb7fuK6ZGpS9XffJa8ZvSSwOi20ojxR69pxGOTiY2Z2WWvss/ICoVu63i?=
 =?us-ascii?Q?NMy0TFUzti4CQq0TbdyI3QmKQkVG4Ce52qxNVgd1RcUN728vM6HdtGjwnLFK?=
 =?us-ascii?Q?wSfWDnCopnh+HrjgSfwxmgDMuDT8D/tLd204xoDwkiaDMFdz+gPnu8zSva7N?=
 =?us-ascii?Q?yDHiYcLTrkWOQdUhgA+CD3yAkgZeoAzUbgmIGHYv9nwcdmVWdxHQFNiwxOET?=
 =?us-ascii?Q?HJrISBChhz9wj7uoJOXJrjviAZJRPFFq2tLcT3ZWFJZoytlfzUZ9OpERjsIZ?=
 =?us-ascii?Q?amkc7W6rQg8MNQhBwcqxRKHttyalQXTJqLfQLJXOqP8syfMeiQ8fCcFE5pVK?=
 =?us-ascii?Q?pe3CzlZdnU1kUNRtY8FY2dBMn3YRTaOXS7uiLm/s?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e5d57c66-8707-4673-bab8-08dc76858808
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2024 15:25:06.5739
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rVhwtgtEpWgvKGMOqzWWx/DeJK+iBYmfvHOGmJeRfVwdXpK9G/3s1o8VtEsJuYQfue57nroEmMJhdQ0cE5OvyQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8643

On Thu, May 16, 2024 at 11:40:30PM +0300, Laurentiu Mihalcea wrote:
> From: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
> 
> Add schema for i.MX8ULP's SIM.
> 
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
> Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
> ---
>  .../bindings/mfd/nxp,imx8ulp-sim.yaml         | 71 +++++++++++++++++++
>  1 file changed, 71 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/nxp,imx8ulp-sim.yaml
> 
> diff --git a/Documentation/devicetree/bindings/mfd/nxp,imx8ulp-sim.yaml b/Documentation/devicetree/bindings/mfd/nxp,imx8ulp-sim.yaml
> new file mode 100644
> index 000000000000..fbb17c06e3c0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/nxp,imx8ulp-sim.yaml
> @@ -0,0 +1,71 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/nxp,imx8ulp-sim.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP i.MX8ULP System Integration Module
> +
> +maintainers:
> +  - Liu Ying <victor.liu@nxp.com>
> +
> +description: |

Needn't "|"

> +  8ULP's SIM provides control and configuration options for
> +  some of the chip's components.
> +
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - nxp,imx8ulp-avd-sim
> +      - const: syscon
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  mux-controller:
> +    $ref: ../mux/reg-mux.yaml
> +
> +  reset-controller:
> +    $ref: ../reset/nxp,imx8ulp-sim-reset.yaml

I think we directly use reset-ti-syscon.c 

> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: nxp,imx8ulp-avd-sim
> +    then:
> +      required:
> +        - reset-controller
> +        - mux-controller
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/imx8ulp-clock.h>
> +    syscon@2da50000 {
> +      compatible = "nxp,imx8ulp-avd-sim", "syscon";
> +      reg = <0x2da50000 0x38>;
> +      clocks = <&pcc5 IMX8ULP_CLK_AVD_SIM>;
> +
> +      mux-controller {
> +        compatible = "mmio-mux";
> +        #mux-control-cells = <1>;
> +        mux-reg-masks = <0x8 0x00000200>;
> +      };
> +
> +      reset-controller {
> +        compatible = "nxp,imx8ulp-avd-sim-reset";
> +        #reset-cells = <1>;
> +      };
> +    };
> -- 
> 2.34.1
>