Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp1022250lqo; Fri, 17 May 2024 08:28:42 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWM1haK1fmSPqruYZcibxevrvcnDuuzj5Oi5DMiNIiYe1h1bKtNIYWZGLOdZ3gLnsiN88zyq07/SRt5cej2ALMAkjHQThhFpEhRf4wq7A== X-Google-Smtp-Source: AGHT+IHUTECVzMWQynOeOCTxDA30iYABuaPO3lePunqn/4VP9POWlX2N3Rol/tsJNbdC0cbOqYq/ X-Received: by 2002:ac8:5791:0:b0:43b:82d:d2cc with SMTP id d75a77b69052e-43dfdbb54fdmr251530781cf.55.1715959721787; Fri, 17 May 2024 08:28:41 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715959721; cv=pass; d=google.com; s=arc-20160816; b=prKHBCUdpczgwolPTp5nRU0/VkbMnwW99Rv/RjKk5Z0keG83xjmEAQ5g2DR2rb+clW p0WdCJCXiZAg2DBhLpWUKpptoukjLpq6G05p0nA/SR58X29mRkC4rd6cQnUL8/aLtcav 2YsG9DkIBiZHBJFzfnv4z94nFKCR8a657xrbsYQ02sC3kiPzbYoTrjiTT1ql6Ceg9ybS uOYevBj0rlmEMx+DpHHQjxFpvEeaiW20aHm2vnjrPO9S2tHtNJbprUKb5VgcOMVviPrz 6BFp9eC+VxMUFBARfy4dsU45d3aCmzm7jykn7qaBtqTweRP/r4L4DJtRi6Bu9me28ehI XEIA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=83KLT5mqh8csB6mmnlBwsrRWlocGeIj1GkS6nSuYPKI=; fh=kxj3FgmpbGW9owB1VqUdlVzWwNMG2usRYhSXFsLAAIY=; b=irlh3ID2gHXpUShsYs5XMCv4w0mw/p0ZqSRl0gVMBxKwh/VC5zdZd2PYS2W6Yb5ftY I2/9b7Ds2QE67hmcNc3PRdPqkjPN5ZaOxXYT+YX0bF9VWEVIUuVKCfqdCenNWTbW6hjX kEttevfFAmHtgCbWtBtk6PfG2EUpFihAtJxpueYuiWcIuucuQxmmpWrwNU0PoW1Y0V6H pAPchjnvnk+cTleb2azvldOuH4GW6ueaohWht3aPnq9HUk5kzIWfcSSAPeDH4n7AtNs9 GjpbccCPB2z2LPHST3sbPih0kCpGcedLv2NJ+0Td7nvqdYlij1jc9HxMkB+z9hirvRk2 zfpQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=NVt7EclR; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-182298-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-182298-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id d75a77b69052e-43df56ecd5fsi199714511cf.781.2024.05.17.08.28.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 May 2024 08:28:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-182298-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=NVt7EclR; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-182298-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-182298-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 7293D1C21E74 for ; Fri, 17 May 2024 15:28:41 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EF4DF12D219; Fri, 17 May 2024 15:28:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="NVt7EclR" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8172B8479; Fri, 17 May 2024 15:28:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.20 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715959713; cv=none; b=uGLCHfb055E8oUhf1GLdQWYK+ErqOBmVEHV9TG5ARQiLAZzVZD0qxi74WbS4vovyv69g8Lf+Sv1BYStcOMIGPZIEF1O6T4zfcAI0zkqQ4uuataIZU+EcekbO+R8ZUo46at3lr81+4QuEdtQYEkUcO1JUQj67OKYjMT8wjTjy2As= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715959713; c=relaxed/simple; bh=g8JS6bBoQYrQ2CsJAX04DJwH1PeKrgcCCBfxu8xCBA8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AjpuYyQruAFyScipJ2S+xMmkYlMUhgFvtRQPE+HXcT9XT4NiUpegrRGMVapVz1QbhCcQE+fd+98eN+/unhSojkE4Rrqs6jN0Kt0LlP43FoGA9uqIWwS0FWaGvN8zkMNeLp+kwXaiFcqrD8w7M6T/InziXMc1gpqEJ6o6kZ6hmW8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=NVt7EclR; arc=none smtp.client-ip=198.175.65.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1715959711; x=1747495711; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=g8JS6bBoQYrQ2CsJAX04DJwH1PeKrgcCCBfxu8xCBA8=; b=NVt7EclR2IrlUI6bbjxhlLF3IXtqyzUYiXkIwx7lXlR5QlAszXiQJXbF BuYJ1IokkmNld91//0D73JzE+wu6gvhvEoQ3mNuZuoAxUspzWEGGm030n Dt1CSQcoJTWS8aQhhg03K9Iw3gnxoT9Hp6t72I01Jh8E2cnrnAEu18eP6 W0gGBk/ynR63xz1FvF8L8futer8ZJ/q3RGBrZ3U4AQyvuRVKpyir4tft5 kSydgEhsGntAM279J5gS0A6xbJRbAyy+t42NggqjfEPBgcOrSnO1ccrjL 92hGc31MAFdtrYhBe0DDUedwIy//pDDGJh7rSuZhfSeNyGRy46sAFYQx6 A==; X-CSE-ConnectionGUID: dlSu8bw6RliwLqWfiNiLuQ== X-CSE-MsgGUID: oSLy/RXETM633nVlO5CRPQ== X-IronPort-AV: E=McAfee;i="6600,9927,11075"; a="11984201" X-IronPort-AV: E=Sophos;i="6.08,168,1712646000"; d="scan'208";a="11984201" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2024 08:28:30 -0700 X-CSE-ConnectionGUID: IkdWLzVWSdGak18HA6W0/w== X-CSE-MsgGUID: PmKCwDnNSUWuDUlsCzWl0A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,168,1712646000"; d="scan'208";a="31817188" Received: from kinlongk-mobl1.amr.corp.intel.com (HELO [10.125.108.204]) ([10.125.108.204]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2024 08:28:29 -0700 Message-ID: Date: Fri, 17 May 2024 08:28:28 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 03/20] x86/tdx: Convert port I/O handling to use new TDVMCALL macros To: "Kirill A. Shutemov" , Sean Christopherson , Paolo Bonzini , Dave Hansen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Josh Poimboeuf , Peter Zijlstra Cc: linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org References: <20240517141938.4177174-1-kirill.shutemov@linux.intel.com> <20240517141938.4177174-4-kirill.shutemov@linux.intel.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20240517141938.4177174-4-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/17/24 07:19, Kirill A. Shutemov wrote: > static inline void tdx_io_out(int size, u16 port, u32 value) > { > - struct tdx_module_args args = { > - .r10 = TDX_HYPERCALL_STANDARD, > - .r11 = hcall_func(EXIT_REASON_IO_INSTRUCTION), > - .r12 = size, > - .r13 = 1, > - .r14 = port, > - .r15 = value, > - }; > - > - __tdx_hypercall(&args); > + TDVMCALL_0(hcall_func(EXIT_REASON_IO_INSTRUCTION), > + size, TDX_PORT_WRITE, port, value); > } I actually really like the self-documenting nature of the structures. I don't think it's a win if this is where the lines-of-code savings comes from.