Received-SPF: pass (google.com: domain of linux-kernel+bounces-182266-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Fri, 17 May 2024 16:03:50 +0100
From: Mark Brown <broonie@kernel.org>
To: Alvin =?utf-8?Q?=C5=A0ipraga?= <alvin@pqrs.dk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Andi Shyti <andi.shyti@kernel.org>,
	Saravana Kannan <saravanak@google.com>,
	Emil Svendsen <emas@bang-olufsen.dk>, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-sound@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-i2c@vger.kernel.org,
	Alvin =?utf-8?Q?=C5=A0ipraga?= <alsi@bang-olufsen.dk>
Subject: Re: [PATCH 07/13] ASoC: codecs: add AD24xx codec driver
Message-ID: <e5782aef-d64d-46f3-ab5c-dc01285e08c2@sirena.org.uk>
References: <20240517-a2b-v1-0-b8647554c67b@bang-olufsen.dk>
 <20240517-a2b-v1-7-b8647554c67b@bang-olufsen.dk>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="skuonK/bS9x9MsEH"
Content-Disposition: inline
In-Reply-To: <20240517-a2b-v1-7-b8647554c67b@bang-olufsen.dk>


--skuonK/bS9x9MsEH
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, May 17, 2024 at 02:58:05PM +0200, Alvin =C5=A0ipraga wrote:

> +++ b/sound/soc/codecs/ad24xx-codec.c
> @@ -0,0 +1,665 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * AD24xx codec driver

Please make the whole comment a C++ comment.

> +static const char *const ad24xx_codec_slot_size_text[] =3D {
> +	"8 bits",  "12 bits", "16 bits", "20 bits",
> +	"24 bits", "28 bits", "32 bits",
> +};

Why is this configured by the user rather than via set_tdm_slot(), and
how would one usefully use this at runtime?

> +static int ad24xx_codec_slot_config_put(struct snd_kcontrol *kcontrol,
> +					struct snd_ctl_elem_value *ucontrol)
> +{

> +	} else if (priv =3D=3D &ad24xx_codec_up_slot_format_enum ||
> +		   priv =3D=3D &ad24xx_codec_dn_slot_format_enum) {
> +		if (val >=3D ARRAY_SIZE(ad24xx_codec_slot_format_text))
> +			return -EINVAL;
> +		slot_config->format[direction] =3D val;
> +	} else
> +		return -ENOENT;

If one side has {} both sides should, see coding-style.rst.

> +
> +	return 0;
> +}

This won't flag changes by returning 1 which will mean no events are
generated and break some UIs.  Please show the output of the mixer-test
selftest on new submissions, it will check for this and other issues.

> +	/* Main node must be BCLK/FSYNC consumer, subordinate node provider */
> +	if ((fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) !=3D
> +	    (is_a2b_main(adc->node) ? SND_SOC_DAIFMT_CBC_CFC :
> +				      SND_SOC_DAIFMT_CBP_CFP))
> +		return -EINVAL;

Please don't use the ternery operator like this, it just makes things
harder to read.

> +	val =3D bclk_invert ? A2B_I2SCFG_RXBCLKINV_MASK :
> +			    A2B_I2SCFG_TXBCLKINV_MASK;

Similarly, please use normal conditional statements.

> +static int ad24xx_codec_hw_params(struct snd_pcm_substream *substream,
> +				  struct snd_pcm_hw_params *params,
> +				  struct snd_soc_dai *dai)

> +
> +	/* Finally, request slots */
> +	ret =3D a2b_node_request_slots(adc->node, &slot_req);
> +	if (ret)
> +		return ret;

Note that hw_params() can be called multiple times before starting the
audio stream, will this leak?

> +				struct snd_soc_dai *dai)
> +{
> +	struct snd_soc_component *component =3D dai->component;
> +	struct ad24xx_codec *adc =3D snd_soc_component_get_drvdata(component);
> +	int ret;
> +
> +	ret =3D a2b_node_free_slots(adc->node);
> +	if (ret)
> +		return ret;

What if we close without having called hw_params()?

> +static const struct snd_soc_dai_driver ad24xx_codec_dai_drv[] =3D {
> +	[AD24XX_DAI_I2S] =3D {
> +		.name =3D "ad24xx-i2s",
> +		.playback =3D {
> +			.stream_name =3D "I2S Playback",
> +			.channels_min =3D 1,
> +			.channels_max =3D 32,
> +		},
> +		.capture =3D {
> +			.stream_name =3D "I2S Capture",
> +			.channels_min =3D 1,
> +			.channels_max =3D 32,
> +		},
> +		.ops =3D &ad24xx_codec_dai_ops,
> +		.symmetric_rate =3D 1,
> +	},
> +};

Why is this an array?

> +static const struct regmap_config ad24xx_codec_regmap_config =3D {
> +	.reg_bits =3D 8,
> +	.val_bits =3D 8,
> +	.cache_type =3D REGCACHE_RBTREE,
> +};

New code should use _MAPLE unless there's a strong reason to use
something else.

--skuonK/bS9x9MsEH
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmZHcdUACgkQJNaLcl1U
h9ABtwf9HncflXNFY8QIXgA4cSV8pllWbpngmZChE9+u+sfBWesth1fTKTC9ejk+
lvIb3qtIDq9BorlQlfdfX8/arFQYpgrXcEhDIpGccNO2OrNZXHSNxnbz90q70XNX
MEil8c3aa9ciM2+g8z3855vKmv+pRCB+GZNbfW/zlmr4pTyumWRIjWI+RWCa5CeV
7w5xGqfedug4xGxlplhyM8Yyu9YDbY5C9GELhAlz0zPBJ+W8yCclZJSsJNYI+jcs
pPPel76R4NsKy7UGqOLoDgFDUFs1Ps5N0wxkeXg3lTUpsLHdu0JH0uifkz8evQ9L
u9RBNxjmWhezCSsPkWCgUbwzjSdCTQ==
=QFB6
-----END PGP SIGNATURE-----

--skuonK/bS9x9MsEH--