Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp1028583lqo; Fri, 17 May 2024 08:38:50 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVr2kwzCHCwY29os96AjmvxSH3tHIct4c03obkmmktdWI0cBZ3aIidq0OOlRev2mPzC/d3xR70EkebWICDKgFNkhCflwOc/jl9b3eRKQA== X-Google-Smtp-Source: AGHT+IHe/CLmjjJYblDTy5LoaRPexLKm6fMXkFf9DULCedV5I6B5nzwAEpulHe02W21iclutaQEI X-Received: by 2002:a05:6a20:f391:b0:1af:d057:af96 with SMTP id adf61e73a8af0-1afd1444bd0mr31828131637.13.1715960330611; Fri, 17 May 2024 08:38:50 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715960330; cv=pass; d=google.com; s=arc-20160816; b=rqKHn6ITMMUiGQ6YIuyJ0gSlEVX/tSPElmkwzQ2jmfeezTPfYCzAVcIR01ePAw/vb9 +Nt1HtuAPazJYTLFf06zqCYcMs1pRlx3PFWf7HvrJf4a5Hv3fZScRw19+sdbTFBXMt86 OH1ejAt/v7CrSWrLkPT0fDs8OTGyu3QdjOR5tChvcpIEGgYeZet09brt7hsgnwAo8dtg E+GU3Tw05VeBxozVYoG1nnfyMnAMMi15Uxhk+JoKEvwAJNraZvis+PtLvwbShTwSAHVt JcjpzOXd3pGrFLpGe//T65bOZEK+jik0Nm2AoYewX8os8QRAen3YAFeRIjJdkZS9feyq 1sxQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=3fPU1fs2JUOtmc5eh1txj+k2TZGaYA4QjWNWwFOsBDU=; fh=R12YCcDtePpgN6f9KPVmf4Jqvdhi45FfYmJCn/RnD4k=; b=nhO9eirDsiQJu/ISclEuJSwfuL3YLptNglXSEEOw+LIri9VXlYDoMPIvMYbILPkBV/ 0v+Avhm8DMEhj/tzaiL4hH/lB7h5FbfpD9gdVoXoVRNw1uci9tG3orde/qZD7oXdbnkZ cNWtgPtcsgPNsVmtG2b7FlPMRAUcHFnz+RJOqwayvgSFPDzlPPVCNX+LPDj1xRugbFNQ 1wFR5xyfFa1tPXTHrm9Z+OIwa6u46MdmQA98XHyLOaj3OdpxJ9Iy8TW+bTVYgKogeZj6 pugDW4IZnm9KqZnQKT7+CYV8nvXBbZjWAefBvOXwn7Rf6wJ9gA2xKmFQxslIL6ok7sIh evEA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=HRWg4ABJ; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-182278-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-182278-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id 41be03b00d2f7-659ca0a4b55si3503967a12.755.2024.05.17.08.38.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 May 2024 08:38:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-182278-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=HRWg4ABJ; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-182278-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-182278-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 6530FB242F1 for ; Fri, 17 May 2024 15:16:46 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E0BA212CDBB; Fri, 17 May 2024 15:16:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="HRWg4ABJ" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DEBD12D768 for ; Fri, 17 May 2024 15:16:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715958993; cv=none; b=anlEX6Zk7XcZRDPfOlyJ9d/oR8k7fkqtlFh5yXzb83WuuRCcKV7oeyKNPjNwPogubY1xml9qAAvdA6frWqguyo2ReZR/f98IR9+gHqxgZURYfu5XVvbLlCMxYE/t4jk1BXKK1BDCc/M7B/XhS9gXgAtatBDlLmGJGhURpjl4jpA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715958993; c=relaxed/simple; bh=3fPU1fs2JUOtmc5eh1txj+k2TZGaYA4QjWNWwFOsBDU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MNbJyUcmubFbozf+c7lNEqVdOA3zdi2cA8VY3YEUeTh3PuZS2KchAygy5UoA1PHBcnbYh7ae3V1tZ3gGik3VxxUClMA4RXtFZh59jFccMKlpWZ6M8FOE/QD9WGQEPaZWAPVxn3jmoAtwTSZNaQJ5RFfTspKoSOCdtDRQmMXM2O4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=HRWg4ABJ; arc=none smtp.client-ip=192.198.163.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1715958991; x=1747494991; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=3fPU1fs2JUOtmc5eh1txj+k2TZGaYA4QjWNWwFOsBDU=; b=HRWg4ABJJz9BEJU0hocya+QyaUNBRgiG43qpy0WRhyErIpPnpYCbMwz6 OpKaN9cDeufjn13N0/r56B3p48HTemTIod4igoHmUKbHHWy/SJvFdR3/K bwkcozB38ZkWjvuc+LiOOHbPw7s/YYrZkikRTTFQNcdJ/N5VeKkrpBC9G +KSvvcSo0ChIQ+SaBiDTPwJ8qrMscOFeGRiR2YyyTgVA0hzJ5smwOSenx 7g8TKgtxY7NrtlFKEPjVJMA/K4s+7dV9G1w8Zq894WNLSfjSHcoE5rp6z cOxvpyczNPyEM6SNqh84F0DqVo7voXjHBkTFXUNxVvfhZcKkdO7o7oCWZ A==; X-CSE-ConnectionGUID: zgmi+7kdSIiA1hpR49bqkQ== X-CSE-MsgGUID: srCK3TFVSGKX2GPfZ7E0HA== X-IronPort-AV: E=McAfee;i="6600,9927,11075"; a="11983248" X-IronPort-AV: E=Sophos;i="6.08,168,1712646000"; d="scan'208";a="11983248" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2024 08:16:30 -0700 X-CSE-ConnectionGUID: mBEYuQawSGWknx11GzKz8Q== X-CSE-MsgGUID: sXjhf5psSKaqSPXJH8u3aw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,168,1712646000"; d="scan'208";a="36713213" Received: from kinlongk-mobl1.amr.corp.intel.com (HELO [10.125.108.204]) ([10.125.108.204]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2024 08:16:30 -0700 Message-ID: Date: Fri, 17 May 2024 08:16:29 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86/kvm/tdx: Save %rbp in TDX_MODULE_CALL To: Juergen Gross , "Kirill A. Shutemov" Cc: linux-kernel@vger.kernel.org, x86@kernel.org, linux-coco@lists.linux.dev, Dave Hansen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" References: <20240517121450.20420-1-jgross@suse.com> <2a2guben2ysyeb43rzg6zelzpa57o24ufai3mi6ocewwvgu63l@c7dle47q7hzw> <03d27b6a-be96-44d7-b4ea-aa00ccab4cc5@suse.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <03d27b6a-be96-44d7-b4ea-aa00ccab4cc5@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/17/24 07:44, Juergen Gross wrote: > Just another data point: Before using this machine I was testing on > another one with older firmware. That one really didn't support NOM_RBP_MOD > and I needed to build the kernel with CONFIG_FRAME_POINTER enabled to get > past the check you are mentioning above. For all intents and purposes, the modules that intentionally clobber RBP don't support Linux. If buggy modules are accidentally clobbering RBP, we can debate how much the kernel should bend over to accommodate them, but my preference would be to ignore them. I'd much rather put a deny list in the kernel than try to tolerate RBP clobbering universally.