Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp1031354lqo; Fri, 17 May 2024 08:44:10 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXjJ1xNrJmrjuXZUTJ3AVkFKK6gcMPUDZPdxQU0vhACMEqhS1/vDa6O8Kb48JdzXPBDKurS14R6xECjRCeQRNCPTMayEAf1sT1FG4awAA== X-Google-Smtp-Source: AGHT+IErbmx4vv7bz19b7VkT8mqejwdJDdgLswXE22uUPXZgbEK3Rp608COXJ+k/92PN6TC3MTIF X-Received: by 2002:a17:906:35d5:b0:a58:a0b8:2a64 with SMTP id a640c23a62f3a-a5a2d55a642mr1532000966b.5.1715960650203; Fri, 17 May 2024 08:44:10 -0700 (PDT) Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a640c23a62f3a-a5a17946638si976995366b.120.2024.05.17.08.44.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 May 2024 08:44:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-182310-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel.com header.s=Intel header.b=EIrv6BJd; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-182310-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-182310-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id C622D1F21267 for ; Fri, 17 May 2024 15:44:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B4B6312F58D; Fri, 17 May 2024 15:44:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=intel.com header.i=@intel.com header.b="EIrv6BJd" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C7C712F583 for ; Fri, 17 May 2024 15:44:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.20 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715960641; cv=none; b=O4vYY/1TqBjvh61iH2CVt+P1oggjuXD6hrVrQJKyYRbnhfMBQjQUpeR0tAx1eaIiqb69xsWqD3ky3dlQqEpM8Cb63/uz5UZ8+5QOdLORI2zsOs1n7DUrooEw+GsgFxJmYXYRnqQ8LJY0/Je7xn6Xscf6t0OzlzrH2O3h3FXFzPU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715960641; c=relaxed/simple; bh=nBdCzxcZ+QKo5XKE+Klf+3UK2UICBXxeAzGOW92QM5c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bDjfjwPhGlmClgd8P47HmkNhRrY/gjcgnWLntrmQQxBwq6xe33CbnUSRhkcE7s432RAw+bSH4ll+CHfDbeqQLEKpWL9hcd1OtcM1AByC9PjLtVO13y/Y0Um0aqtxrl74wLPW8MDmw1Ldmto7KOO7eVPJ29e/eB3LI+wAq4Nr8ZI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=EIrv6BJd; arc=none smtp.client-ip=198.175.65.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1715960640; x=1747496640; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=nBdCzxcZ+QKo5XKE+Klf+3UK2UICBXxeAzGOW92QM5c=; b=EIrv6BJdM0a2xdYCY/jawdRJEcV7Dvt4nuoxI9cBNqixxECVOqJsHlSn m4KoTyep0OsXFkM+S9CJrjsmTUZ+lKlTH72fn7scAjgbSTuZS1ROqNYZf fYwiB5325Zb1gfEXUh4bTN9cqfPSymcRKkNcgVY6MN0VetjFKB5LjN7QM R8etBnC6Gw7YO/8q5LhYRkRLTI2CrO2xDz0vpbwgs+k+AdP7NY4+ePZc/ Xznh8gJAagHKS0wcMwfYWN9Fp/8xUnXRS/vqsgiZk+sjwmUmgtJX8/qJt UZoqlQSqGe1z94aKzsNzdQbveuLKvP/GnnDB/XxhVRWP3fadviprSDX9F A==; X-CSE-ConnectionGUID: muo0OFzgTDSnF5Y3Dokudw== X-CSE-MsgGUID: DiDY7TcbTiu1baG5RIKHBQ== X-IronPort-AV: E=McAfee;i="6600,9927,11075"; a="11987004" X-IronPort-AV: E=Sophos;i="6.08,168,1712646000"; d="scan'208";a="11987004" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2024 08:44:00 -0700 X-CSE-ConnectionGUID: o3Z33PjkTtGF0XcFnIOi0A== X-CSE-MsgGUID: rdV4DVZYRrGRRcLLfWsfjQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,168,1712646000"; d="scan'208";a="36721729" Received: from kinlongk-mobl1.amr.corp.intel.com (HELO [10.125.108.204]) ([10.125.108.204]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2024 08:43:59 -0700 Message-ID: <6df4fb48-9947-46ec-af5a-66fa06d6a83b@intel.com> Date: Fri, 17 May 2024 08:43:58 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86/kvm/tdx: Save %rbp in TDX_MODULE_CALL To: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= , "Kirill A. Shutemov" Cc: linux-kernel@vger.kernel.org, x86@kernel.org, linux-coco@lists.linux.dev, Dave Hansen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" References: <20240517121450.20420-1-jgross@suse.com> <2a2guben2ysyeb43rzg6zelzpa57o24ufai3mi6ocewwvgu63l@c7dle47q7hzw> <03d27b6a-be96-44d7-b4ea-aa00ccab4cc5@suse.com> Content-Language: en-US From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 5/17/24 08:27, Jürgen Groß wrote: > On 17.05.24 17:16, Dave Hansen wrote: >> On 5/17/24 07:44, Juergen Gross wrote: >>> Just another data point: Before using this machine I was testing on >>> another one with older firmware. That one really didn't support >>> NOM_RBP_MOD >>> and I needed to build the kernel with CONFIG_FRAME_POINTER enabled to >>> get >>> past the check you are mentioning above. >> >> For all intents and purposes, the modules that intentionally clobber RBP >> don't support Linux. If buggy modules are accidentally clobbering RBP, >> we can debate how much the kernel should bend over to accommodate them, >> but my preference would be to ignore them. >> >> I'd much rather put a deny list in the kernel than try to tolerate RBP >> clobbering universally. > > Would you be fine with adding a new X86_FEATURE (or BUG?) allowing > to switch RBP save/restore via ALTERNATIVE, controlled by a command > line option? > > Or maybe by adding a new CONFIG_TDX_MODULE_CAN_CLOBBER_RBP (probably > using a shorter name) option? As a last resort maybe. > TBH I'm slightly puzzled that the firmware I'm using could make it > outside Intel. I'm fearing this might happen again. You're puzzled that the firmware is either old buggy or both? Huh. Intel ships all kinds of crazy pre-production stuff as development platforms. Let's make sure we know what you've got before we go tearing up mainline for it. Because if the options are: 1. Maintain code in mainline until the day I die^Wretire or 2. Get Jürgen a BIOS update so he stops sending patches .. it's kinda an easy choice. ;)