Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp1038893lqo; Fri, 17 May 2024 08:57:29 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWJSGpvq+0eXI840dNXeAlje9e87JZuVDgASEuRukiQ8So6/PNNyy/IFDGBOBZ1LnowfpdlBVelcqs91Vv6hKd8m34byGATiMpQfh7dfA== X-Google-Smtp-Source: AGHT+IFmVGeJtgGhzV9Y3f6uj6+N9sJKG6AbENODMtmFRyVjnbxzlrlq1mfZgrhQB6Rnd/em92bb X-Received: by 2002:a17:902:ce85:b0:1e5:11ac:a283 with SMTP id d9443c01a7336-1ef43d0ada2mr268565275ad.9.1715961448701; Fri, 17 May 2024 08:57:28 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715961448; cv=pass; d=google.com; s=arc-20160816; b=YxfyB03miYQeQiuwsIE6jqAmPWBWCBcwTC6DZLw/FL/XIOeCYpL2LmNv2Zj2vc38+x T6WvxKN+dZXttoCfJvKek/22diUV/DsKPyEPUucTncg6ULZAMz+3b6OyaPXuGe5II19t CAKstyZ85/W0hRGBJ0qI9vNpqwNLEeUzveA/i4HrvaRURXodjt4Fmf4aW3HFSxDtKD1c zCRb55ac9SLFQek3RNquKs7HpaQ/tl+h0l3J4ImcMNeBDN0gbtLA2xij1aCfj+yghJ9j Nm8VwAakxJ9vNz0kurKqGHoKDSHWo7d0pcOe0iBUiMLEHNqdTJYrfu2aH6jszEyUzbF6 w43A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=MpiUD6dy+eXt5/IGhO2Sb5O4IiNvr9UGc4qUSWkw2Pc=; fh=kxj3FgmpbGW9owB1VqUdlVzWwNMG2usRYhSXFsLAAIY=; b=IlFBmPqhRFQ94/0354MJyTD2KbfJrjhqwmDogLUUxKd3fZdt3i74PCvrGvIqOQiMLF 71oIORl0r/06ISDrsFK47NL7qQv+gEZwIq/hMymFmvWiGZzXSGZAzNkEfgWHhvchi2ja nf6JNiUgzgj5Hh0Hp7r0/Osydl+io6yRbluORomzHt2XRNmpatqiLn61hX984po3R4Uw 3deyG0kZiGYS0iheVAX5Uvls2RFNJPs8uHnXDdHGgLLjKgT1M5eqvuWQckTY50L5VKS+ X5Z8SMQKkxVe2fgw4lNI589AiJHbzhL1L48ITQoHwMwWYKuCXHNhb9i3AZh861gL6x+Z V17g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=krjj7Zb7; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-182320-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-182320-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id d9443c01a7336-1ef0bf32b19si183187275ad.324.2024.05.17.08.57.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 May 2024 08:57:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-182320-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=krjj7Zb7; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-182320-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-182320-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 6C95D286C4F for ; Fri, 17 May 2024 15:57:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6602012FB02; Fri, 17 May 2024 15:57:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="krjj7Zb7" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43E4112F597; Fri, 17 May 2024 15:57:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715961434; cv=none; b=tzcTe8KxznaHds3QkDAbgHEdVluRlmtf9WOdVl7qllrxLNTSwIMLlpzRMzKfebRMA8DVrWJzvwB/fpJaxaIkAK28Y8K3CtU9A1X6kQip8wqlx5WO5cUtu78UTMrX9lCixg/bLktDWzv+ht0iBYYydX313lWMhp3DpywXmd1OBlk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715961434; c=relaxed/simple; bh=/THtfddWNe2X0O3uTjzuAOx1zf4DbLYV51WhztiYedo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=N2GMA8cGbGEZ0V/7Rq/8Xw3bj3IINAitjWvhk3y6a4Cxl2xCV8sbhsXlpkIOsXBBEYOZKDWkG5cYBU7bHeRryqg2z1fPMGHS5XwjMRy59i803onZk4ShMOQSO8cyYHG6FyCtu0Y1sH7Y9d6mEEiZ6hTq1T+EcGv6XAEYDb9h8LU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=krjj7Zb7; arc=none smtp.client-ip=198.175.65.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1715961433; x=1747497433; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=/THtfddWNe2X0O3uTjzuAOx1zf4DbLYV51WhztiYedo=; b=krjj7Zb7XELS2yLkUZQuiRe1MKcsqoUXy+A5V/KLr4Y04qPD7zTW0ylg k++CDQ9TpGcvI64vb+k2vyFj4k9ttAwPEuRoIXFxLgPSylh3qPVbLXlvh 8gMzDZtH5r3eFpjQXoI2F3NmJ1ALsq+QhUBehpuxyyney5FXEkMA1IQlf rdtiVPhD9gEEYN5DcWhvKv4zH4bYi9SbD2x7+pLlRF0uCmVGVLKWSzGmz c5h3RKlmOkCmv+KgIfC8AsCjBML4cY49bS+W6WRVm6fL8Z9OfMIw5cAhk kHRvdhpyEiFi53omY1oEeZ9tIUGSlIjucvVrll8v6PVtfk9UIcDpQwFC2 g==; X-CSE-ConnectionGUID: kJsJ2F8iQLqODgA6sIywEg== X-CSE-MsgGUID: +p2qjS7ASVicVFHMnhCEBw== X-IronPort-AV: E=McAfee;i="6600,9927,11075"; a="23284583" X-IronPort-AV: E=Sophos;i="6.08,168,1712646000"; d="scan'208";a="23284583" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2024 08:57:12 -0700 X-CSE-ConnectionGUID: n4bU1dzLT4OY/9YPGl9Wqg== X-CSE-MsgGUID: yICPwXpfS9K3ATPuIxaOfg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,168,1712646000"; d="scan'208";a="31751403" Received: from kinlongk-mobl1.amr.corp.intel.com (HELO [10.125.108.204]) ([10.125.108.204]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2024 08:57:11 -0700 Message-ID: Date: Fri, 17 May 2024 08:57:10 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 16/20] x86/tdx: Convert VP_INFO tdcall to use new TDCALL_5() macro To: "Kirill A. Shutemov" , Sean Christopherson , Paolo Bonzini , Dave Hansen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Josh Poimboeuf , Peter Zijlstra Cc: linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org References: <20240517141938.4177174-1-kirill.shutemov@linux.intel.com> <20240517141938.4177174-17-kirill.shutemov@linux.intel.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20240517141938.4177174-17-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/17/24 07:19, Kirill A. Shutemov wrote: > - /* > - * TDINFO TDX module call is used to get the TD execution environment > - * information like GPA width, number of available vcpus, debug mode > - * information, etc. More details about the ABI can be found in TDX > - * Guest-Host-Communication Interface (GHCI), section 2.4.2 TDCALL > - * [TDG.VP.INFO]. > - */ > - tdcall(TDG_VP_INFO, &args); > + tdg_vp_info(&gpa_width, &td_attr); Why is the comment going away?