Received-SPF: pass (google.com: domain of linux-kernel+bounces-182340-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 17 May 2024 17:16:45 +0100
From: Conor Dooley <conor@kernel.org>
To: Hal Feng <hal.feng@starfivetech.com>
Cc: Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>,
	Ilpo =?iso-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Conor Dooley <conor+dt@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Emil Renner Berthing <emil.renner.berthing@canonical.com>,
	devicetree@vger.kernel.org, linux-serial@vger.kernel.org,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/3] dt-bindings: serial: snps-dw-apb-uart: Add one
 more reset signal for StarFive JH7110 SoC
Message-ID: <20240517-lion-supplier-f4d15b0edcff@spud>
References: <20240517061713.95803-1-hal.feng@starfivetech.com>
 <20240517061713.95803-2-hal.feng@starfivetech.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="ET0G0aOiXXDFM+f4"
Content-Disposition: inline
In-Reply-To: <20240517061713.95803-2-hal.feng@starfivetech.com>


--ET0G0aOiXXDFM+f4
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, May 17, 2024 at 02:17:11PM +0800, Hal Feng wrote:
> The UART of StarFive JH7110 has two reset signals.
> Both of them are necessary for JH7110 to initialize UART.
>=20
> Signed-off-by: Hal Feng <hal.feng@starfivetech.com>
> ---
>  .../bindings/serial/snps-dw-apb-uart.yaml          | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)
>=20
> diff --git a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.ya=
ml b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> index 1001d2a6ace8..a6396c5cbfb1 100644
> --- a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> @@ -13,6 +13,16 @@ allOf:
>    - $ref: serial.yaml#
>    - $ref: rs485.yaml#
> =20
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: starfive,jh7110-uart
> +    then:
> +      properties:
> +        resets:
> +          minItems: 2

else:
  properties:
    resets:
      maxItems: 1

Thanks,
Conor.

> +
>  properties:
>    compatible:
>      oneOf:
> @@ -48,6 +58,7 @@ properties:
>            - enum:
>                - starfive,jh7100-hsuart
>                - starfive,jh7100-uart
> +              - starfive,jh7110-uart
>            - const: snps,dw-apb-uart
>        - const: snps,dw-apb-uart
> =20
> @@ -82,7 +93,8 @@ properties:
>      type: boolean
> =20
>    resets:
> -    maxItems: 1
> +    minItems: 1
> +    maxItems: 2
> =20
>    reg-shift: true
> =20
> --=20
> 2.43.2
>=20
>=20
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv

--ET0G0aOiXXDFM+f4
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZkeC7QAKCRB4tDGHoIJi
0vZ0AP0SDG3gdkl/SROzsnRuQ3RQz0FByypwdFgIWR36PF1aywD/fUifiJN9EkJS
DWNaC36x9nDD0qUF9URCjGhdPH1TMws=
=KlsG
-----END PGP SIGNATURE-----

--ET0G0aOiXXDFM+f4--