Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp1083466lqo; Fri, 17 May 2024 10:06:13 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU15+ajD4wgM2uzFWJ4hMyXvqKkmjK0mVkuW841bokEL+jgsyCYbOKuakak2djyPZeGkfwtH7hmmeLvEKWyvvhAebT4EjmyFt0cmPjOnQ== X-Google-Smtp-Source: AGHT+IEL2IsMZ7TP70zmDS2Hmd9211Irhd+kNvgbGFTQIIMQWNYUCmEbDkK+tUobNQX+O6Nt1JQY X-Received: by 2002:a05:6359:a3a3:b0:194:801b:151a with SMTP id e5c5f4694b2df-194801b18c0mr1145005755d.23.1715965572956; Fri, 17 May 2024 10:06:12 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715965572; cv=pass; d=google.com; s=arc-20160816; b=Nn0vaRPl4sLDdKr0V/o/89lES2GHdBih0ORvZlltGV465s94q+0maiD6RkbV9P3WGC +BCtXfTQr4vTEifpXQiSv8uykBVeWgnliVoDlyfluyNc7XmvuNG4+VTZt0Y12VkgOQ7I V4urAHM/it8BR1uzLu40sXcCfeuJ+70Fx1VL7JDoxea531Uux9o52Bt61cHO2XRLE5Z2 9j3TPyDUmavSerTrc+c8msqLHAjHFmzVevDh6x7A1MyOQEr1QT6X1p1SVWvh4i4G8EDn B0NYkTiInz+sIerDklIHLjaWmuGmCwVoxo/f8FRi/3EHGT4Pb9TJXpgdmENsQEOJxxNY KPQg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date; bh=VVvDZJ25CM7AvrtcNE+5/owwmFHIQhBFnMSMaajYoM0=; fh=kxgrOFjmEqP2u+reJbif1buZs/TRvqFk4wKUOB7exoA=; b=M3Hcix3ihrIkz+hvvUOf905eK7Kds8JZ/8og52m75ZJ/2of5XHPASD4vGtZPiiLTHF 2xdcmmAZZ1XE30FhFRjxwqdyAsWXaVeYzcxI42vJiRB+h40Q0DqQF6M4iLdMCYkfY6ds U7JuT9enRDWFlyzpRfQNbApjXtzqrpOFaf9mh27n0Br/a8qTWz+ngxswzmqFuhqb7vtw rRsqS2433jVs06QZfp2YsQPKxsYgM46PPG1ZmlaJ4Rbx/HlLJOQP5VTL8x6bQLObjDds yXPm61M8XbFQkYnytEXG+R1xVlMU+XJzS3TmcJ2ndhaUeKC0z8e2xpPztlNO7nLjg/FT UkpA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-182375-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-182375-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linux.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id d75a77b69052e-43df738a017si50942601cf.345.2024.05.17.10.06.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 May 2024 10:06:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-182375-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-182375-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-182375-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linux.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id A809B1C2237D for ; Fri, 17 May 2024 17:06:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 62E1E13DB88; Fri, 17 May 2024 17:06:05 +0000 (UTC) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5F4F12F5A3; Fri, 17 May 2024 17:06:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715965564; cv=none; b=ArWpnm6BEjGiscrpXRC0Qfp5wEFwKmEG4jzDSUrCWQCCPzont84mQ4GZqsZLjxALncgWvFsCmWbcMxSlyEwI31NxRfBhl0Y+tIMVlDc/44WK156QKBDiVkybGCo4mdB1itko3q27liJwrvsEZsl+FXSh8WjoIRRzVfi1cfcmIl8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715965564; c=relaxed/simple; bh=K2VnhU6ogrvxD5ir1zRQbmZRUAqElyzks1ABSMOc1YY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MQ9R/J7HEdOEbI5DvbCFgVVmdXRkVD+8za4hkXXHbsT+jS2y4OkXXb5cVhJqDGWccBi3OW72mMfsA9lWVubtP6Hwhq8XbVM4IFJ718wAoORCtMO5YxZhFZDl9TLt3Br8RoIp+36DP1MyM8OxO2w0UZKJBQfVEqZVySIAn2ZduaA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.com; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1edfc57ac0cso14536895ad.3; Fri, 17 May 2024 10:06:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715965563; x=1716570363; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VVvDZJ25CM7AvrtcNE+5/owwmFHIQhBFnMSMaajYoM0=; b=o44hNWZb4EQHoUSqgryBr04p2/0V7+E/CV5+Tf52SlKFb4YHo9ZeqPgC63r9WjEmRp 1/bweXpAKJ1b5+dKynJdRMBkQ+yNNnst8hz3qhFi0zn+FN4OrYIcLL0BrfQRUdiDzkVb ZGjmgTiu5NWNa09/nF5+cCcYyayd5DxSC6CtKF6zTg2MXzJlKWggbdkrpz4cPV7uakgJ u/tqWVxaxkeDxOoIlRGcjhztjGmKr/C5TIF2yyJaNevDqczd27Mgtp6pU2ZoBkf1H6w4 0yXLkXXDrKghXG5RcYpkpEvLygxlivhxtZzUHft9925LYYptbtNltkLceQLR7jod6gOm 292g== X-Forwarded-Encrypted: i=1; AJvYcCXCXu5UtVsDhP9HY2DACYbm+nRex+Fq9tNczvzLzJF9b4VsO/9KN+LyurMVbYKTzibctHABEWVvZvh9zwOgq/8JVEzO+fcDppY0Vd07WXrzOimwQM+7nylbNdqTvaif5QJ9F4izZGIZ X-Gm-Message-State: AOJu0YzjF3QYzFSliSJk6QbE7aVhY5/SbntUouz2mgywgg11hZSR2UrD eFVDW5uAaeiVXlJR1BE1LHMWXqAzWuQuhiOR8/eKGS+jTfHbSDqZ X-Received: by 2002:a17:902:c246:b0:1ea:f9b1:8b13 with SMTP id d9443c01a7336-1ef43e2322emr190094445ad.31.1715965562832; Fri, 17 May 2024 10:06:02 -0700 (PDT) Received: from localhost (fpd11144dd.ap.nuro.jp. [209.17.68.221]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0c264479sm159001365ad.292.2024.05.17.10.06.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 May 2024 10:06:02 -0700 (PDT) Date: Sat, 18 May 2024 02:06:00 +0900 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Konrad Dybcio Cc: Jingoo Han , Gustavo Pimentel , Manivannan Sadhasivam , Lorenzo Pieralisi , Rob Herring , Bjorn Helgaas , Marijn Suijten , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: Re: [PATCH v2] PCI: dwc: Use the correct sleep function in wait_for_link Message-ID: <20240517170600.GB1947919@rocinante> References: <20240215-topic-pci_sleep-v2-1-79334884546b@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240215-topic-pci_sleep-v2-1-79334884546b@linaro.org> Hello, > According to [1], msleep should be used for large sleeps, such as the > 100-ish ms one in this function. Comply with the guide and use it. > > [1] https://www.kernel.org/doc/Documentation/timers/timers-howto.txt Applied to controller/dwc, thank you! [1/1] PCI: dwc: Use msleep() in dw_pcie_wait_for_link() https://git.kernel.org/pci/pci/c/0189ae3b7f87 Krzysztof