Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp1085989lqo; Fri, 17 May 2024 10:10:09 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUTnOwCWMFH1GaCw0K7SCAaEqkUpPbbN+PIqvOHIbKFPi+ZwWTFbYm00nLOkKVvxu42t/cVFezpLLjxGtJsRtgZapU2U8kgkdNFwUACyw== X-Google-Smtp-Source: AGHT+IG9Dx1JRNHW/gOaglXc6vBBMpjU+fdKlSVj6Eub17VSAeEK9Kq92ZTxVY1KcE94tk7WN6yY X-Received: by 2002:a17:902:b181:b0:1e8:32ed:6f6d with SMTP id d9443c01a7336-1ef43e23a66mr201022115ad.39.1715965809327; Fri, 17 May 2024 10:10:09 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715965809; cv=pass; d=google.com; s=arc-20160816; b=IzDOVCHBXbw+GwOepkhzRWqMLHSfe92TQF2iBFAdhWWP7nKGCqUSL5MK/19WXc5hJw HIgmwcBTMWaHZuw8q8ojPgYT74l3gPKB6yUfwXhstX7u8w3IBGsJifn0itPQc1t2LEM9 8o8wHNrXkgOB8S2RaAOu4cikw6VpLdM7mnYqkIQKZSwyw04IKoa5FlSFM43pX4fp/zd7 19LFbwpiB+aUt7m8GkPlRm2qjX6fACessACDthazMGZ3uIF2JrBUNbWCwTAmA9xsoa8b wroXwPySgLfQyfXd+sk9n0FlcD6dAgKcpl2dWXfMPTVaWEmH/ik+tDpAwtwVrt/Cuz1I ZOxA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=+pdp9Fgv06c5uCl9iN53c2RFQnQI9vJm8SjFQl4B3n8=; fh=RLy4fNdZenUiE+L5TwH3nElM42+AickDCAzyOK4A/1Y=; b=YYFzlvWDRWjQiAArThtoXtarqHbmH2RH2yif5qf0IzwQ1Sq2biEf2uYcstfaTp/7o9 /zSeFsZNLwWmSmr4HqdjVPS8pZvzfwtiCcu1wEGycl/8rmFZhrC/w8wFRqd4z3OdPxHt sCILl0pmprdEl4CH/uMUW8YVJST2zii8CaLZHo4B+972sjuHAboDGchMk7hGWzrW4EVR Mh8dPkuFfA+FwSPF7VInbQgKoVxHBPqJBzkQFrl84/veXqIYVYQNtZBoGLzCErlz9NqD iCIntf/eYNTkEJ0PUibqlROtCEXDjofZOrel+U93gUNuyCS/qIeaa4JL/9y0XTlIqize p9Hg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=b0yTdLDU; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-182378-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-182378-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id d9443c01a7336-1ef0b9cfbbdsi185047065ad.24.2024.05.17.10.10.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 May 2024 10:10:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-182378-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=b0yTdLDU; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-182378-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-182378-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id F001BB215F8 for ; Fri, 17 May 2024 17:10:05 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 88CAA13DB8A; Fri, 17 May 2024 17:09:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="b0yTdLDU" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A422712F5A3 for ; Fri, 17 May 2024 17:09:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715965797; cv=none; b=VwaLkzayW211Y32ZS473z1HQdEgcsD2R8y3IDtuyVZrE70VBOSWDK5qsHWRBgWo9idG7rLjbgheZulKcWjZI9q9mPr3CTHU4hhZcN//4V1nk4lp0XvcLaPdvGn+4taVGesCIPb7D6HQQZ8H2TGIfhzQtIBVcN3MSx+JauClh9C0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715965797; c=relaxed/simple; bh=x7Bw4tG2gXrUHLF36e6j3ojXvbwM76d82R/kfpkt0DI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CFIR1ffHa4lu6tMd6zIkJN7YnnnuWvXYppAQMbUje/86GfrUntRb4Q2S5MWR/cdZN8c4a9+QQDRW7yji/lQKRop/n2q4kJCHtToTC1las97dcpYouml58q+4e6dJ9ijXMeqrpLcEKiVF4Hq+PjUHXXL+ZkaNMiuM5quY+D+VSUk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=b0yTdLDU; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715965794; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+pdp9Fgv06c5uCl9iN53c2RFQnQI9vJm8SjFQl4B3n8=; b=b0yTdLDUlU8skMJHbdCiKrnAMvye1sAflKsOCklhygm+urh/xsUssIe+9t5lzt+IOtfj86 WLGpcjZ0fLg3A4WmA+5BCBoNnaXuPWvCcKR5HIDq8g4EimAm3IdGSae3rIH/Xa+8Y+BgPv lthjxGYqHQpoeXyW71dFl3vsqDVpp4A= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-691-oD-mcOygM5yL2wr6n5S2ww-1; Fri, 17 May 2024 13:09:52 -0400 X-MC-Unique: oD-mcOygM5yL2wr6n5S2ww-1 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-a59bfd32b8fso565166366b.3 for ; Fri, 17 May 2024 10:09:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715965791; x=1716570591; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+pdp9Fgv06c5uCl9iN53c2RFQnQI9vJm8SjFQl4B3n8=; b=u3AyI+/G2IY+YHYoi7vOQgk/2xzq60zuphTljSYKC3rZzpMaVTVNXIj/AoYDLbQKCH m5QLy/Pg4P3nGHmwEsqFCz0hHtjpcRhhVRB3Z/2+98+iRXwJExM/ZqR2SSB9rAGOh7v5 G82bknATkSqcZGOruVptzckqnZpPSz3yui3C2kQWSzW1VG3eeG5b3KeSwfDGnhzJGlLi zKZS/E3AEm+EgvYX6tgFtkeDOVnGMZ7ZqgNNPziH4LvBYms8mR+2k2N2uVw4vIQE/h+y 8MbJ33pFwAzO0wgTqOHHet0Wodlkhiw4n6wafQgKLmDF1hu7mu1Tg+KaHj6OA0t3x6qO GhpQ== X-Gm-Message-State: AOJu0YwPUKlSm1P9oFM57D+nRcRuHBoc1XdT5wGfvyugnF0VHqs108ac crzDrpmHObs2Y4hURFS83lv3KvhwfAg41hrK6Ub6ZyVbsnCxoXTmvG6L/jRv6Ozd6Rbz5WGpT5e TcHUp6YEwjCpMefxwZH9ngKQ9IzwR5bE5ZW7h5yjnp//mXU/VZLNIorp0BuH32A== X-Received: by 2002:a17:907:2d86:b0:a5a:423:a69f with SMTP id a640c23a62f3a-a5a2d53b9bemr1782609566b.9.1715965791658; Fri, 17 May 2024 10:09:51 -0700 (PDT) X-Received: by 2002:a17:907:2d86:b0:a5a:423:a69f with SMTP id a640c23a62f3a-a5a2d53b9bemr1782608366b.9.1715965791307; Fri, 17 May 2024 10:09:51 -0700 (PDT) Received: from [192.168.10.81] ([151.95.155.52]) by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-a5a55275e80sm856667566b.8.2024.05.17.10.09.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 May 2024 10:09:50 -0700 (PDT) Message-ID: <2450ce49-2230-45a2-bc0d-b21071f2cce6@redhat.com> Date: Fri, 17 May 2024 19:09:48 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 7/7] KVM: VMX: Introduce test mode related to EPT violation VE To: Sean Christopherson Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Isaku Yamahata References: <20240507154459.3950778-1-pbonzini@redhat.com> <20240507154459.3950778-8-pbonzini@redhat.com> <7c0bbec7-fa5c-4f55-9c08-ca0e94e68f7c@redhat.com> From: Paolo Bonzini Content-Language: en-US Autocrypt: addr=pbonzini@redhat.com; keydata= xsEhBFRCcBIBDqDGsz4K0zZun3jh+U6Z9wNGLKQ0kSFyjN38gMqU1SfP+TUNQepFHb/Gc0E2 CxXPkIBTvYY+ZPkoTh5xF9oS1jqI8iRLzouzF8yXs3QjQIZ2SfuCxSVwlV65jotcjD2FTN04 hVopm9llFijNZpVIOGUTqzM4U55sdsCcZUluWM6x4HSOdw5F5Utxfp1wOjD/v92Lrax0hjiX DResHSt48q+8FrZzY+AUbkUS+Jm34qjswdrgsC5uxeVcLkBgWLmov2kMaMROT0YmFY6A3m1S P/kXmHDXxhe23gKb3dgwxUTpENDBGcfEzrzilWueOeUWiOcWuFOed/C3SyijBx3Av/lbCsHU Vx6pMycNTdzU1BuAroB+Y3mNEuW56Yd44jlInzG2UOwt9XjjdKkJZ1g0P9dwptwLEgTEd3Fo UdhAQyRXGYO8oROiuh+RZ1lXp6AQ4ZjoyH8WLfTLf5g1EKCTc4C1sy1vQSdzIRu3rBIjAvnC tGZADei1IExLqB3uzXKzZ1BZ+Z8hnt2og9hb7H0y8diYfEk2w3R7wEr+Ehk5NQsT2MPI2QBd wEv1/Aj1DgUHZAHzG1QN9S8wNWQ6K9DqHZTBnI1hUlkp22zCSHK/6FwUCuYp1zcAEQEAAc0j UGFvbG8gQm9uemluaSA8cGJvbnppbmlAcmVkaGF0LmNvbT7CwU0EEwECACMFAlRCcBICGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRB+FRAMzTZpsbceDp9IIN6BIA0Ol7MoB15E 11kRz/ewzryFY54tQlMnd4xxfH8MTQ/mm9I482YoSwPMdcWFAKnUX6Yo30tbLiNB8hzaHeRj jx12K+ptqYbg+cevgOtbLAlL9kNgLLcsGqC2829jBCUTVeMSZDrzS97ole/YEez2qFpPnTV0 VrRWClWVfYh+JfzpXmgyhbkuwUxNFk421s4Ajp3d8nPPFUGgBG5HOxzkAm7xb1cjAuJ+oi/K CHfkuN+fLZl/u3E/fw7vvOESApLU5o0icVXeakfSz0LsygEnekDbxPnE5af/9FEkXJD5EoYG SEahaEtgNrR4qsyxyAGYgZlS70vkSSYJ+iT2rrwEiDlo31MzRo6Ba2FfHBSJ7lcYdPT7bbk9 AO3hlNMhNdUhoQv7M5HsnqZ6unvSHOKmReNaS9egAGdRN0/GPDWr9wroyJ65ZNQsHl9nXBqE AukZNr5oJO5vxrYiAuuTSd6UI/xFkjtkzltG3mw5ao2bBpk/V/YuePrJsnPFHG7NhizrxttB nTuOSCMo45pfHQ+XYd5K1+Cv/NzZFNWscm5htJ0HznY+oOsZvHTyGz3v91pn51dkRYN0otqr bQ4tlFFuVjArBZcapSIe6NV8C4cEiSTOwE0EVEJx7gEIAMeHcVzuv2bp9HlWDp6+RkZe+vtl KwAHplb/WH59j2wyG8V6i33+6MlSSJMOFnYUCCL77bucx9uImI5nX24PIlqT+zasVEEVGSRF m8dgkcJDB7Tps0IkNrUi4yof3B3shR+vMY3i3Ip0e41zKx0CvlAhMOo6otaHmcxr35sWq1Jk tLkbn3wG+fPQCVudJJECvVQ//UAthSSEklA50QtD2sBkmQ14ZryEyTHQ+E42K3j2IUmOLriF dNr9NvE1QGmGyIcbw2NIVEBOK/GWxkS5+dmxM2iD4Jdaf2nSn3jlHjEXoPwpMs0KZsgdU0pP JQzMUMwmB1wM8JxovFlPYrhNT9MAEQEAAcLBMwQYAQIACQUCVEJx7gIbDAAKCRB+FRAMzTZp sadRDqCctLmYICZu4GSnie4lKXl+HqlLanpVMOoFNnWs9oRP47MbE2wv8OaYh5pNR9VVgyhD OG0AU7oidG36OeUlrFDTfnPYYSF/mPCxHttosyt8O5kabxnIPv2URuAxDByz+iVbL+RjKaGM GDph56ZTswlx75nZVtIukqzLAQ5fa8OALSGum0cFi4ptZUOhDNz1onz61klD6z3MODi0sBZN Aj6guB2L/+2ZwElZEeRBERRd/uommlYuToAXfNRdUwrwl9gRMiA0WSyTb190zneRRDfpSK5d usXnM/O+kr3Dm+Ui+UioPf6wgbn3T0o6I5BhVhs4h4hWmIW7iNhPjX1iybXfmb1gAFfjtHfL xRUr64svXpyfJMScIQtBAm0ihWPltXkyITA92ngCmPdHa6M1hMh4RDX+Jf1fiWubzp1voAg0 JBrdmNZSQDz0iKmSrx8xkoXYfA3bgtFN8WJH2xgFL28XnqY4M6dLhJwV3z08tPSRqYFm4NMP dRsn0/7oymhneL8RthIvjDDQ5ktUjMe8LtHr70OZE/TT88qvEdhiIVUogHdo4qBrk41+gGQh b906Dudw5YhTJFU3nC6bbF2nrLlB4C/XSiH76ZvqzV0Z/cAMBo5NF/w= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/17/24 18:38, Sean Christopherson wrote: >>> I've hit this three times now when running KVM-Unit-Tests (I'm pretty sure it's >>> the EPT test, unsurprisingly). And unless I screwed up my testing, I verified it >>> still fires with Isaku's fix[*], though I'm suddenly having problems repro'ing. >>> >>> I'll update tomorrow as to whether I botched my testing of Isaku's fix, or if >>> there's another bug lurking. >>> >>> https://lore.kernel.org/all/20240515173209.GD168153@ls.amr.corp.intel.com >> I cannot reproduce it on a Skylake (Xeon Gold 5120), with or without Isaku's >> fix, with either ./runtests.sh or your reproducer line. >> >> However I can reproduce it only if eptad=0 and with the following line: >> >> ./x86/run x86/vmx.flat -smp 1 -cpu max,host-phys-bits,+vmx -m 2560 \ >> -append 'ept_access_test_not_present ept_access_test_read_only' > > FWIW, I tried that on RPL, still no failure. Ok, so it does look like a CPU issue. Even with the fixes you identified, I don't see any other solution than adding scary text in Kconfig, defaulting it to "n", and adding an also-very-scary pr_err_once("...") the first time VMPTRLD is executed with CONFIG_KVM_INTEL_PROVE_VE. Paolo