Received-SPF: pass (google.com: domain of linux-kernel+bounces-182379-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 17 May 2024 13:10:05 -0400
From: Frank Li <Frank.li@nxp.com>
To: Conor Dooley <conor@kernel.org>
Cc: Shengjiu Wang <shengjiu.wang@gmail.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Shengjiu Wang <shengjiu.wang@nxp.com>, abelvesa@kernel.org,
	peng.fan@nxp.com, mturquette@baylibre.com, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org,
	s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com,
	marex@denx.de, linux-clk@vger.kernel.org, imx@lists.linux.dev,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, p.zabel@pengutronix.de
Subject: Re: [PATCH v3 3/6] dt-bindings: clock: imx8mp: Add reset-controller
 sub-node
Message-ID: <ZkePbZBufOHWQdzM@lizhi-Precision-Tower-5810>
References: <1715679210-9588-1-git-send-email-shengjiu.wang@nxp.com>
 <1715679210-9588-4-git-send-email-shengjiu.wang@nxp.com>
 <20240514-campus-sibling-21cdf4c78366@spud>
 <b86c83a520f0c45a60249468fa92b1de.sboyd@kernel.org>
 <CAA+D8ANTdvQJVtniyMtqjnJdT4qX+LDGjVuFO6H0RSO+GDw+ng@mail.gmail.com>
 <20240515-unbundle-bubble-8623b495a4f1@spud>
 <ZkT+4yUgcUdB/i2t@lizhi-Precision-Tower-5810>
 <20240516-reversing-demeanor-def651bc82ac@spud>
 <ZkbVa5KvvbnH/tNQ@lizhi-Precision-Tower-5810>
 <20240517-gristle-dealt-56b5299b9cb8@spud>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240517-gristle-dealt-56b5299b9cb8@spud>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?44zp28m4M+me6qyeLIDgIAVodim0ORr9GcwWB5a56RDE070AT4GK7wCADH2r?=
 =?us-ascii?Q?WAbgREEucKxhTUw734N7ixoLtyDtyh96Tx3nQMKLLEJnbPOWxPGnMPNTyb39?=
 =?us-ascii?Q?FOftvNw9y1gdzjzhFQRP7qmULH7s+URb2vLOEgR1ywPRQAAjqRsdk4XlcC/M?=
 =?us-ascii?Q?9K2i0ld/jiSxXfswC4RL4+oJuL1xOZf/V3TkjcQSRUBpgXszFfszD3bABKhz?=
 =?us-ascii?Q?1eBLmBtiLLCiY0Kexc57XPr/FRsHI0HegE51EwpxR5O86SCfLvkidFBjzKfe?=
 =?us-ascii?Q?V2ka6Y5JBD27Zf+VX3DXpZnC2HDblO3DA17xb7uHG/rdF0q7hY8T7LUbYlO9?=
 =?us-ascii?Q?z43dggC+XvRt5hhXTJJPNg/ysNMp+N4K/QDF00dJf3kwzXa+TXhPDSU5+Sep?=
 =?us-ascii?Q?ltBrxe7Uqm1xz91G0iZ8uC1y+54V9Cp0Hdpg526L24Az4DAlTztQODj1RbEe?=
 =?us-ascii?Q?l4exZV6Fhj12aW2P0j70E10y/sUjjDrG/AD35eaJOM8r4kLhkYuxb0q/ulQk?=
 =?us-ascii?Q?1xSbXOZU+Ggh0GsDOtgCWjKMuuAt0bxNpg1X7SGuR2afw61hR8eqt1yTG50d?=
 =?us-ascii?Q?t3WnNDxaiHewIm6aJV5zS+KAWPayTanhhilw30ICG1R+jtqIu3/49cv4o1dK?=
 =?us-ascii?Q?4qxn8aoMdJUTLkfdIN+8ZRGBiR5uXzo0UUbjPi7wz1TbDih5Z2SWJ4sm7M9f?=
 =?us-ascii?Q?8So09JbwV8NKhNJTWJtE4bCeYsMBS7Z5ywz85jmhX3lvuyNHZJoRYIh90+Ep?=
 =?us-ascii?Q?JqiE02fksiqKfpLuN9a/yD8+xjKByNklYVfMx3MeksL94q0FlD9J/lTJSsrY?=
 =?us-ascii?Q?nKRZCAXak8T4aMfi93lv3xyqmo/JkBCsvDsEOT7puNAksPjzjdrHNYTIj59Z?=
 =?us-ascii?Q?QkzIGX0az7QVjaDcAy1dVK+o3sM7/zRQq2Qq5eX21xe99HzkbZha5RuAP/MY?=
 =?us-ascii?Q?CnTkhbbIWD7Ljk8WtkxQ8A6kLLXk+vUqmN0Xi/pHeMdQ3FSrrgxIe48rU4ye?=
 =?us-ascii?Q?WPDOh5Oi/yXssNF+wuRDGScZkW0fJ5iTpCHTBr6mdZVBHOzD/aFRS3hFb+d4?=
 =?us-ascii?Q?pGHI09l8fo44kTkCtJ7asxayE332ZpzknzwTxIAbKOGEbs/RcfUDqKBMNKqZ?=
 =?us-ascii?Q?+rGmHQtO84NzQbExe/2Fv04vaI601S0mtKKkzMRo0wmTP5f9MXrCIV6KaA/c?=
 =?us-ascii?Q?mkllDgT0HPhjy2MTmiEP1av+P+4/Dg+hnVjVAuoNysT7z93vgVXZHhJ600dm?=
 =?us-ascii?Q?v05xF00JQsR2sDooUi0Qh8ZszS3wU7sPuHMwe/hRg8DYxJxJ/8Eh1gYNVfho?=
 =?us-ascii?Q?l4/9mj2jZL7FkFXCexR/iwYfBJblebA58TV9OJpyhr9fG2hff5XttOdWj59f?=
 =?us-ascii?Q?QEt+CJtBVV9+nH2LybKrl7nwXtUwZC7qFrwxnfecD7WpJQWwapP+75B4BBp4?=
 =?us-ascii?Q?tRq5bKxxZA9P0M6TO7t9wXoMu6t5wkpb64o0Xm50EHZ7Br/xpUOw6aNhwE+d?=
 =?us-ascii?Q?KNRopzzAhcMwtRi5a2l/huhm4rF8LuWLsKoCXAn95FWudOWhtkI164nZ8VtC?=
 =?us-ascii?Q?iEgJgDpPLtncwyPgky6NroA7TTbRT5EoaRkc4PHZ?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7238153a-8eed-4c22-7212-08dc7694387d
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2024 17:10:15.5603
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vg//+gR0QBthI1KKUeMh1IG103nV3En0XHG5l/oK2eAjZcmCyI3od3WI8jC7xfS0Ei4x7W9YWVTW48FUVnF+UQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9574

On Fri, May 17, 2024 at 05:21:32PM +0100, Conor Dooley wrote:
> On Thu, May 16, 2024 at 11:56:27PM -0400, Frank Li wrote:
> 
> > Look like it is easy to register auxdev "reset" devices. But I have a
> > problem. How to use it by DT phandle?  "reset" devices is service provider.
> > Some client will use it.
> > 
> > Generally, reset node will used by other devices nodes. like
> > 
> > ABC: reset {
> > 	compatible="simple-reset";
> > 	...
> > }
> > 
> > other node will use "reset = <&ABC 0>".  If use auxdev, how to get &ABC
> > in dts file.
> 
> Whether or not you use auxdev or any other method etc, does not matter
> in a DT system, the consumer will always have a phandle to the provider
> node:
> 
> ABC: whatever {
> 	compatible = "whatever";
> 	#clock-cells = <...>;
> 	#reset-cells = <...>;
> }
> 
> something-else {
> 	clocks = <&ABC ...>;
> 	resets = <&ABC ...>;
> }


It goes back to old problem, "reset-cells" will be in "clock-controller".

clock-controller@30e20000 {
        compatible = "fsl,imx8mp-audio-blk-ctrl", "syscon", "simple-mfd";
        reg = <0x30e20000 0x10000>;
	...
	
	#reset-cells = <...>;
	^^^
    };

If create new "whatever" auxdev bus driver which included two aux devices, 
(clock and reset). 

it will be similar with mfd. Still need change
clock-controller@30e20000 drivers.

"Which is I suspect is gonna require a change to your clock driver,
because the range in the existing clock nodes:
	audio_blk_ctrl: clock-controller@30e20000 {
		compatible = "fsl,imx8mp-audio-blk-ctrl";
		reg = <0x30e20000 0x10000>;
	};
would then have to move to the mfd parent node, and your clock child
would have a reg property that overlaps the reset region. You'd need to
then define a new binding that splits the range in two - obviously
doable, but significantly more work and more disruptive than using an
auxdev."

So I don't know why auxdev will be better than mfd.

A possible benefit may be that Auxdev needn't binding doc for clock and
reset node devices.

Frank


Frank