Received-SPF: pass (google.com: domain of linux-kernel+bounces-182395-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Kalle Valo <kvalo@kernel.org>
To: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
Cc: Dave Hansen <dave.hansen@intel.com>,  Borislav Petkov <bp@alien8.de>,
  Thomas Gleixner <tglx@linutronix.de>,  Ingo Molnar <mingo@redhat.com>,
  Dave Hansen <dave.hansen@linux.intel.com>,  "Rafael J. Wysocki"
 <rafael@kernel.org>,  x86@kernel.org,  linux-pm@vger.kernel.org,
  linux-kernel@vger.kernel.org,  regressions@lists.linux.dev,  Jeff Johnson
 <quic_jjohnson@quicinc.com>,  Daniel Sneddon
 <daniel.sneddon@linux.intel.com>
Subject: Re: [regression] suspend stress test stalls within 30 minutes
References: <87o79cjjik.fsf@kernel.org>
	<20240511184847.GCZj-9j2sh1Akpt9iS@fat_crate.local>
	<20240511184945.GDZj-9yaOEWqf1ng8u@fat_crate.local>
	<87h6f4jdrq.fsf@kernel.org> <878r0djxgc.fsf@kernel.org>
	<874jb0jzx5.fsf@kernel.org>
	<feaefaae-e25b-4a48-b6be-e20054f2c8df@intel.com>
	<20240515072231.z3wlyoblyc34ldmr@desk>
Date: Fri, 17 May 2024 20:19:49 +0300
In-Reply-To: <20240515072231.z3wlyoblyc34ldmr@desk> (Pawan Gupta's message of
	"Wed, 15 May 2024 00:22:31 -0700")
Message-ID: <87ikzcfj9m.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Pawan Gupta <pawan.kumar.gupta@linux.intel.com> writes:

> On Tue, May 14, 2024 at 09:10:07AM -0700, Dave Hansen wrote:
>
>> On 5/14/24 06:17, Kalle Valo wrote:
>> > The kernel we use in our ath11k testing has almost all kernel debug
>> > features enabled so I decided disable all of them, which unsurprisingly
>> > also fixed my suspend problems. So maybe this is something which happens
>> > only when MITIGATION_IBRS_ENTRY and some debug option from 'Kernel
>> > hacking' are both enabled?
>> 
>> I had my money on DEBUG_ENTRY, but it doesn't look like you ever had it
>> enabled.
>> 
>> I've got basically two theories:
>> 
>> One, the IBRS value is getting mucked up somewhere, either that %r15
>> value is getting stepped on or the per-cpu value is corrupt and the
>> WRMSR #GP's, causing the hang.
>> 
>> Two, IBRS_{ENTER,EXIT} is called in a "wrong" context somewhere.  Either
>> it is clobbering something it shouldn't or it is assuming something is
>> in place that is not (like a valid stack).
>> 
>> But the whole "'sudo shutdown -h now' then suspend somehow immediately
>> unstalls" thing is really perplexing.  I hope Pawan has some ideas.
>
> Nothing promising yet. I now have the system with the same model, but the
> system is only booting in recovery mode with the config attached with the
> report.
>
> Kalle, I wanted to try reverting the below commits:
>
> aa1567a7e644 ("intel_idle: Add ibrs_off module parameter to force-disable IBRS")
> 1e4d3001f59f ("x86/entry: Harden return-to-user")
> c516213726fb ("x86/entry: Optimize common_interrupt_return()")
>
> ... but I haven't reproduced the issue yet.

I can try to revert those but didn't manage to do it yet.

> FYI, cmdline "spectre_v2=off" should have the same effect as
> CONFIG_IBRS_ENTRY=n.

Confirmed, I don't see the bug with "spectre_v2=off" and the box
suspended succesfully 400 times.

> Other interesting thing to try is cmdline "dis_ucode_ldr".

This didn't help. I tried twice, the first time it failed after 11
suspend loops and the second time after 34 loops.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches