Received-SPF: pass (google.com: domain of linux-kernel+bounces-182558-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 17 May 2024 15:15:42 -0400
From: Frank Li <Frank.li@nxp.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Han Xu <han.xu@nxp.com>,
	Vinod Koul <vkoul@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>, Marek Vasut <marex@denx.de>,
	linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
	imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/5] dt-bindings: mtd: gpmi-nand: Add
 'fsl,imx8qxp-gpmi-nand' compatible string
Message-ID: <Zkes3n6ZLjIFFQUK@lizhi-Precision-Tower-5810>
References: <20240517-gpmi_nand-v1-0-73bb8d2cd441@nxp.com>
 <20240517-gpmi_nand-v1-1-73bb8d2cd441@nxp.com>
 <20240517203621.72b8b9c7@xps-13>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240517203621.72b8b9c7@xps-13>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?iso-8859-1?Q?mgZ912TDCpHwyEwCChfXC84XZJWitiCggAae5Y4WZ484kPaGZIXQu3e27/?=
 =?iso-8859-1?Q?iWkQ43NpEgfkBRU+uTaXEo7actuB/FpJX/0kNR5hozDlg6oiE7z5Fubuzk?=
 =?iso-8859-1?Q?OEfn+Qja3MV6+gqD5m4cxaUxO6szmwIJcHzEXNMMjPF2HCOwBrRmiuVUV7?=
 =?iso-8859-1?Q?mSLxpDcS+fjrjOo8r//cMNOH/1Dw1d4nIN5LZ3s5jGm6o7gc6r0UdXmRF2?=
 =?iso-8859-1?Q?KFfiqlOHRa3jXsH4uN+tEiKjP8KVnWkZUO2N3Ac4Ogo9QGlKjmXL7JMq9M?=
 =?iso-8859-1?Q?kWGu9XMDGGqd/Fl6m9AR9T1A/Txeo19L5uCUwcO4+lE16pYPxIQOJBlffW?=
 =?iso-8859-1?Q?b8qrIXfLB3dLH1OpR+BIyWpnkw12MKjniwi072OJlGh0SVA/MZ8Xbxd1g2?=
 =?iso-8859-1?Q?W/3pwO+uBfU4hh364L7E02enCtADRIoMm9gHWfEz1+udEMB2+MQev+LXW/?=
 =?iso-8859-1?Q?rQoctZYjJ1XdCjGvjqw3ZhzI7eJe7OQ+ARohZO8WZ3HO3n2upG4QREtifT?=
 =?iso-8859-1?Q?vgtprXazICbhxPPugI1reEEfTVdLhM6AB0HNb6EXOyGk5KJqn+wY36A655?=
 =?iso-8859-1?Q?K3coztmN3Ij50jKFju+zcgxwXqkpxO29iEArNlmrUh9cTzZAvdoSgdLJLX?=
 =?iso-8859-1?Q?sGOJu+1QkL9+qqQ3tkhUDwevXWHptCd8RzdXI2S29Rn+cChf2kR+C6EI8i?=
 =?iso-8859-1?Q?ve6IGUgHpJ7Rd62+NcJDDiV9xF+n1PPOT2pDWVcZf3J664N39Dm/IU4keX?=
 =?iso-8859-1?Q?OaPUWG7TWS6i2lALtL7VCvU2TErZ1JiNCoDrLNgbPB8f6Q81dHnMW/w6kz?=
 =?iso-8859-1?Q?iiN9UX89ldrIq1Wnew/V6d9sx4BC9yRGe7Pvr4heo86GQ6HdyYKDmHk9x3?=
 =?iso-8859-1?Q?S2rVqWIGGEY20lKzv53aDQTbukdJxZ8ssrjdTR0cmggruZ5GwdIgODDG7v?=
 =?iso-8859-1?Q?cq8kEAbKLqpCFlhYY7JthrZHqwDVz4F1xzeTFsliV2lcUJMsR9jBprLIWN?=
 =?iso-8859-1?Q?q5sZXHT/XpMOC4nQ5AJ+zEemO4SbjxICFaFnaQ5wckm3VZ/HvElbGo6kBn?=
 =?iso-8859-1?Q?ptwRMqZ/Mze1Uv4vEyQqUjtWcgztcPkawBE8ecmbwu2FJFo0+sE0M89AO/?=
 =?iso-8859-1?Q?YgNIT9lgVY2++QBnZKJy/9H8L2nVCli9BBfc4yOUE8SxL9TSLgEBZYZM5d?=
 =?iso-8859-1?Q?gNqxYr5KAUXcFDwu4l67TWsdNDa5rKcR5bVGFp5ftXjg5ntJ2cYj02STQX?=
 =?iso-8859-1?Q?jUlRWU5IioWNpzoJqCbx0KGumiTakMLpxGObdPclziYlF8nVptnrBl6ONM?=
 =?iso-8859-1?Q?c0ECD8mR4UjhsF7F3J1HUMXy+QauDgl+kcRCP8B0RzMH3GDRdtUzpoHhg1?=
 =?iso-8859-1?Q?lYCjCZS3LvDA7ce3WN2kp5Rb+pCU84IZfep5pyZXo6m7Amd7TaSEmgmCcr?=
 =?iso-8859-1?Q?HGaOVjOuOv1mkJOwfu0O65aFVyeCplrO43GcgyNYAB4Xvpjg0tFQP6LBRm?=
 =?iso-8859-1?Q?nd+sMv8MXOAlLi1CohlJeZJukN1/KUxhr+llLu8AfyZRvAexXGBeEMVA1R?=
 =?iso-8859-1?Q?2fZQFnFQXLIVBLtVobCvRcyi+nlZuHkf//ahKibSvkG2FpTKBD2IfsbH9G?=
 =?iso-8859-1?Q?VQPXB1kAwf9+6D7pJqXl6sJOoupMrlRNSX?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c5b639d9-77fb-417b-f064-08dc76a5c492
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2024 19:15:52.0420
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nSbmFAIfbMsVXlEdA+AmcITV5oo/gtSZD2zj+8UV1rx3WxK2XbL7ijVDg2zcdKikm0HDnKnNDEmfb0U5k2LM3A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9584

On Fri, May 17, 2024 at 08:36:21PM +0200, Miquel Raynal wrote:
> Hi Frank,
> 
> Frank.Li@nxp.com wrote on Fri, 17 May 2024 14:09:48 -0400:
> 
> > Add 'fsl,imx8qxp-gpmi-nand' compatible string and clock-names restriction.
> > 
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> >  .../devicetree/bindings/mtd/gpmi-nand.yaml         | 22 ++++++++++++++++++++++
> >  1 file changed, 22 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/mtd/gpmi-nand.yaml b/Documentation/devicetree/bindings/mtd/gpmi-nand.yaml
> > index 021c0da0b072f..f9eb1868ca1f4 100644
> > --- a/Documentation/devicetree/bindings/mtd/gpmi-nand.yaml
> > +++ b/Documentation/devicetree/bindings/mtd/gpmi-nand.yaml
> > @@ -24,6 +24,7 @@ properties:
> >            - fsl,imx6q-gpmi-nand
> >            - fsl,imx6sx-gpmi-nand
> >            - fsl,imx7d-gpmi-nand
> > +          - fsl,imx8qxp-gpmi-nand
> >        - items:
> >            - enum:
> >                - fsl,imx8mm-gpmi-nand
> > @@ -151,6 +152,27 @@ allOf:
> >              - const: gpmi_io
> >              - const: gpmi_bch_apb
> >  
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            enum:
> > +              - fsl,imx8qxp-gpmi-nand
> > +    then:
> > +      properties:
> > +        clocks:
> > +          items:
> > +            - description: SoC gpmi io clock
> > +            - description: SoC gpmi apb clock
> 
> I believe these two clocks are mandatory?

minItems default is equal to items numbers, here is 4. So all 4 clock are
mandatory.

Anything wrong here?

Frank

> 
> > +            - description: SoC gpmi bch clock
> > +            - description: SoC gpmi bch apb clock
> > +        clock-names:
> > +          items:
> > +            - const: gpmi_io
> > +            - const: gpmi_apb
> > +            - const: gpmi_bch
> > +            - const: gpmi_bch_apb
> > +
> >  examples:
> >    - |
> >      nand-controller@8000c000 {
> > 
> 
> 
> Thanks,
> Miqu?l