Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp1167908lqo; Fri, 17 May 2024 12:55:12 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWqSeD0Uakr2sLvrjxWVX+8D6XoyPAqQcEwr6akE8xEjeNAU04lBC+mxhtDKZFvOZLtbFyob/Ut7EJit6IW+1H6a1EnhO510NPRseAQ7g== X-Google-Smtp-Source: AGHT+IEEvXYSzriwkRG18IiFHkP/H+pFh071xyeLQ5n3anMuEykYgLHn5PwFU/kLJ2e7pZ0FWxUM X-Received: by 2002:ac2:5119:0:b0:523:772c:2c1c with SMTP id 2adb3069b0e04-523772c2e00mr9320597e87.38.1715975712467; Fri, 17 May 2024 12:55:12 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715975712; cv=pass; d=google.com; s=arc-20160816; b=tq60eq94FAJ1NyNfYZ6nPcvpZLSh0vDWoiftNGBOhTT55yTtRLxys7Fyb1xwFj49k6 xXs3VvESrTIO5HrhYDEbQBoBxGnqyN5vjpUBonFZjzOOWjkVTyDPnNv0iPfyxrPtlT1B Ywso91ohDHkC7JEfaPNOCoaossLLA37M5vcUnqJCsRnb84j8+bR4RmSX2tKiLUYX3u/L wV4BjjgntcLhgK3vt/GvBziOxOBUkBwHDSzGIVJKr6pUgTXGWCaOhgI8KZ5byRMzYlg2 yrl3FmhsDAn6pHTQg1b/TQMLuDF6C9wuIlyYDKPf/Nrqo6wmTh9Uxi/Pm9F0GctEffm0 S1IA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=PIxvzyMExA5pVZeSthUKnpXf6dg41HcryJMHLzZOoV8=; fh=LDKqGB8ZNl8NmJgUmuofQ9Azw0SMDgDBwSQzUt/rWWA=; b=FBBl3tHvEWt7J2LqlLTyFNwCf43SsOknUWmPv9O0qbxPE3ACzzv4rKOAkfX8K7+XBA xVZhZeEF+JSpQPHZ6tPCRnRCVGekBVpON6Jrpx5RsB0czp3YIsKKiBfzqJNHxb++wZ1R +R4SBeZpzhkFjd/KbJ/Hv/a4Su3PZxAP+WBBCXqKSNhDxVO6KHnUOAceCr/dVjvOPYIS 6aphF3gh0imBZwQMo3VRCMgmvnOrE63Xf/tupeOLxRkdNbiUrpOVPe/NjmfUmHIgLGf9 HdXhYrbChiKtgRIQHxykypG0cldLaTnFYZX2kIJcn/th9LJB1dnND5bxLD7GVJT80Kzx lC8Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=W1qFJX54; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-182592-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-182592-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id a640c23a62f3a-a5a17b4c66fsi1061791566b.278.2024.05.17.12.55.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 May 2024 12:55:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-182592-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=W1qFJX54; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-182592-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-182592-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 30D681F24E1E for ; Fri, 17 May 2024 19:55:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 99F35142642; Fri, 17 May 2024 19:53:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="W1qFJX54" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E30B31411EF; Fri, 17 May 2024 19:53:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715975633; cv=none; b=M1AEoJuxrPOxA8T1UrqfrtZwGzUneMg7kHtD0FOi/XXuJYW30g7m3GbySCMHtWPX7dbdDnDwwu6boiYRaE6MPilmpY0LfupZc+YZVFy49vzFFzZ+vUPd+bNc6DkcUexGS8/7AstC7+0Z23dEhFrYAR3c0DPQfbZRuGLKzRowOO0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715975633; c=relaxed/simple; bh=HBWQ6IuxWBHRAQ4QfisCUK6oqXawkSugTUNHrkfwhz4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YrQ17yALuro5kCS+t9jrXy03OY7kgcd/Q/J7Td8UOzkTU6NvqUC3BrOLTAmhiOReJKA3BfFiqoLgK6dODi8bcjdxe3aMDicYU+gkmq5cnDLZa1wcH/5V9czJkdLsUNRNVIdUSymkzAAPCHPnjErQ+g1JOtCP9ziMYc9ZVUqTELg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=W1qFJX54; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1715975632; x=1747511632; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=HBWQ6IuxWBHRAQ4QfisCUK6oqXawkSugTUNHrkfwhz4=; b=W1qFJX54bryzba+zXLwPbYrk+AlguQXnfsKxFVzUmbHOI0f6bNoMdY6S ZLPshec/x0EQ/IJtCrbtKUnafVV2nsP98QtPUgMVAnFaTqFUvD52iwOLA nOneIwJnAZHM69qSXH1TFIOwwGNyoXOsPGWkRb8jXJ3Es7lFsUah6tsCY MqK0Kt0DiYm0m8YYnh87XgzXuh0MmVjGtj6u/4l+afpucxRCj4sTn5Tr+ g00cBK5E7FSFJqvpz9zyDW8g7lx2bn49oF/roSQmNLpBabG2H2nsQmj4J Zl7mvZb5t1ySPAnPzUDsXW+Icc3xcv7i1a1hDcekKbXqpiQ7MVZZFpKl0 Q==; X-CSE-ConnectionGUID: Bd3saI1qRk6xqIaEh+4Ybw== X-CSE-MsgGUID: vj1vER+fT1eq6gJ3vN2HYQ== X-IronPort-AV: E=McAfee;i="6600,9927,11075"; a="12348672" X-IronPort-AV: E=Sophos;i="6.08,168,1712646000"; d="scan'208";a="12348672" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2024 12:53:52 -0700 X-CSE-ConnectionGUID: MMr9Eq2ETEidSEtteES/3Q== X-CSE-MsgGUID: 6mSVDHLuRYSdn73/LP21pQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,168,1712646000"; d="scan'208";a="31915015" Received: from black.fi.intel.com ([10.237.72.28]) by fmviesa006.fm.intel.com with ESMTP; 17 May 2024 12:53:49 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 5945253A; Fri, 17 May 2024 22:53:45 +0300 (EEST) From: Andy Shevchenko To: Mark Brown , Andy Shevchenko , Linus Walleij , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Daniel Mack , Haojian Zhuang , Robert Jarzmik Subject: [PATCH v1 06/10] spi: pxa2xx: Remove duplicate check Date: Fri, 17 May 2024 22:47:40 +0300 Message-ID: <20240517195344.813032-7-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1336.g36b5255a03ac In-Reply-To: <20240517195344.813032-1-andriy.shevchenko@linux.intel.com> References: <20240517195344.813032-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The mmio_base can't be NULL at this point. It's either checked in both pxa_ssp_probe() and pxa2xx_spi_init_ssp() or correctly provided by PCI core. Hence, remove duplicate check which is a dead code. Signed-off-by: Andy Shevchenko --- drivers/spi/spi-pxa2xx.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c index 6bbeb1d09ed9..cd28b798b53b 100644 --- a/drivers/spi/spi-pxa2xx.c +++ b/drivers/spi/spi-pxa2xx.c @@ -1417,9 +1417,6 @@ static int pxa2xx_spi_probe(struct platform_device *pdev) if (!ssp) ssp = &platform_info->ssp; - if (!ssp->mmio_base) - return dev_err_probe(dev, -ENODEV, "failed to get SSP\n"); - if (platform_info->is_target) controller = devm_spi_alloc_target(dev, sizeof(*drv_data)); else -- 2.43.0.rc1.1336.g36b5255a03ac