Received-SPF: pass (google.com: domain of linux-kernel+bounces-182210-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <e2b386431754d70c6772abee099dce4acc1d4023.camel@linux.intel.com>
Subject: Re: [PATCH] platform/x86: ISST: fix use-after-free in
 tpmi_sst_dev_remove()
From: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
To: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>, Hans de Goede
	 <hdegoede@redhat.com>, Ilpo =?ISO-8859-1?Q?J=E4rvinen?=
	 <ilpo.jarvinen@linux.intel.com>, Zhang Rui <rui.zhang@intel.com>, 
	platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: dan.carpenter@linaro.org, kernel-janitors@vger.kernel.org, 
	error27@gmail.com
Date: Fri, 17 May 2024 07:33:58 -0700
In-Reply-To: <48377484a8a9e479b301e9a9772653a3bc6ccf81.camel@linux.intel.com>
References: <20240514092656.3462832-1-harshit.m.mogalapalli@oracle.com>
	 <48377484a8a9e479b301e9a9772653a3bc6ccf81.camel@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
Precedence: bulk
MIME-Version: 1.0

On Fri, 2024-05-17 at 07:31 -0700, srinivas pandruvada wrote:
> On Tue, 2024-05-14 at 02:26 -0700, Harshit Mogalapalli wrote:
> > In tpmi_sst_dev_remove(), tpmi_sst is dereferenced after being
> > freed.
> > Fix this by reordering the kfree() post the dereference.
> >=20
> > Fixes: 9d1d36268f3d ("platform/x86: ISST: Support partitioned
> > systems")
> > Signed-off-by: Harshit Mogalapalli
> > <harshit.m.mogalapalli@oracle.com>
> Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
>=20
I realized the line length is 127 chars in commit description.
Please fix that and run checkpatch.pl before posting again.

Thanks,
Srinivas

> > ---
> > This is found by smatch and only compile tested.
> > ---
> > =C2=A0drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c | 2 +=
-
> > =C2=A01 file changed, 1 insertion(+), 1 deletion(-)
> >=20
> > diff --git
> > a/drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c
> > b/drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c
> > index 7bac7841ff0a..7fa360073f6e 100644
> > --- a/drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c
> > +++ b/drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c
> > @@ -1610,8 +1610,8 @@ void tpmi_sst_dev_remove(struct
> > auxiliary_device *auxdev)
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0tpmi_sst->partition_mas=
k_current &=3D ~BIT(plat_info-
> > > partition);
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0/* Free the package ins=
tance when the all partitions are
> > removed */
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (!tpmi_sst->partitio=
n_mask_current) {
> > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0kfree(tpmi_sst);
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0isst_common.sst_inst[tpmi_sst->package_id] =3D N=
ULL;
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0kfree(tpmi_sst);
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0}
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0mutex_unlock(&isst_tpmi=
_dev_lock);
> > =C2=A0}
>=20