Received-SPF: pass (google.com: domain of linux-kernel+bounces-182621-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Thomas Gleixner <tglx@linutronix.de>
To: "Luck, Tony" <tony.luck@intel.com>, "H. Peter Anvin" <hpa@zytor.com>,
 Borislav Petkov <bp@alien8.de>
Cc: Ingo Molnar <mingo@redhat.com>, Dave Hansen
 <dave.hansen@linux.intel.com>, "x86@kernel.org" <x86@kernel.org>, "Peter
 Zijlstra (Intel)" <peterz@infradead.org>, Uros
 Bizjak <ubizjak@gmail.com>, "Edgecombe, Rick P"
 <rick.p.edgecombe@intel.com>, Arnd Bergmann <arnd@arndb.de>, Mateusz Guzik
 <mjguzik@gmail.com>, Thomas
 Renninger <trenn@suse.de>, Greg Kroah-Hartman <gregkh@suse.de>, Andi Kleen
 <ak@linux.intel.com>, "linux-kernel@vger.kernel.org"
 <linux-kernel@vger.kernel.org>, "patches@lists.linux.dev"
 <patches@lists.linux.dev>
Subject: RE: [PATCH v2] x86/cpu: Fix x86_match_cpu() to match just
 X86_VENDOR_INTEL
In-Reply-To: <SJ1PR11MB60837E7CD8952271654EA379FCEE2@SJ1PR11MB6083.namprd11.prod.outlook.com>
References: <20240516162925.79245-1-tony.luck@intel.com>
 <20240517144312.GBZkdtAOuJZCvxhFbJ@fat_crate.local>
 <863D0F06-1217-4C94-B2CA-816FC4ABB103@zytor.com>
 <SJ1PR11MB60837E7CD8952271654EA379FCEE2@SJ1PR11MB6083.namprd11.prod.outlook.com>
Date: Fri, 17 May 2024 22:42:44 +0200
Message-ID: <87eda0jhkr.ffs@tglx>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

On Fri, May 17 2024 at 18:17, Luck, Tony wrote:
>> I'm confused. Why not simply use say -1 for wildcard vendor match, -2
>> for no vendor ID (no CPUID or other known probing mechanism) and -3
>> for unrecognized vendor (vendor detectable but not known.)
>
> It was really convenient to have "0" be the wildcard for all of
> vendor, family, model, stepping, feature because users of
> x86_match_cpu() could just initialize the fields they cared about in
> the struct x86_cpu_id and have the compiler make the rest be 0
> automagically.
>
> But X86_VENDOR_INTEL being zero has always been a thorn in that scheme.

As all initializers are macro based, that's really a non-problem.

Thanks,

        tglx