Received-SPF: pass (google.com: domain of linux-kernel+bounces-182631-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Fri, 17 May 2024 17:09:20 -0400
From: Frank Li <Frank.li@nxp.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Han Xu <han.xu@nxp.com>,
	Vinod Koul <vkoul@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>, Marek Vasut <marex@denx.de>,
	linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
	imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/5] dt-bindings: mtd: gpmi-nand: Add
 'fsl,imx8qxp-gpmi-nand' compatible string
Message-ID: <ZkfHgGhc5821c9Ma@lizhi-Precision-Tower-5810>
References: <20240517-gpmi_nand-v1-0-73bb8d2cd441@nxp.com>
 <20240517-gpmi_nand-v1-1-73bb8d2cd441@nxp.com>
 <20240517203621.72b8b9c7@xps-13>
 <Zkes3n6ZLjIFFQUK@lizhi-Precision-Tower-5810>
 <20240517215055.02622324@xps-13>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240517215055.02622324@xps-13>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?iso-8859-1?Q?AHxWyhhk754Ho2y6jukQ+kGkvwIhpYS3co2e92QxIr80hsxduXONj6Nco4?=
 =?iso-8859-1?Q?b/1EIqauwfDziTh+t8wYCcfrXpemGI2+Z2Ppd7I4I28YG1Sazd7LqeRmp8?=
 =?iso-8859-1?Q?KPAZSLDH0oJ5rK1omfRjZF1WlHDQFuefZ1D+RQec0pfHEh6xQ7rLHnLpbU?=
 =?iso-8859-1?Q?tFjZHm+slEPNf6qp2sajD0uqd3qEogFaNQeS+F4XE1RHV0LaoYt9zqJ5Ki?=
 =?iso-8859-1?Q?gDmRC7djDfdTm+fNO+hja04nt+MyA8w9t4ZumiTJxw8SwIMeQzEro0cgii?=
 =?iso-8859-1?Q?hkmyddiZbxjEfxmasQrERJs4Hb7r0VWYXYsfsd9V1SpF9iA849ZWDJcjaW?=
 =?iso-8859-1?Q?1IuhcskILCEMbOd5wsGtP3VFJP3R8Sik7ZQrwgea+/zBmYx15QWolTMJFV?=
 =?iso-8859-1?Q?HqKltGDDREqoaVpd+J2S0gwN9+3Y2kUDumcWob7NKogvhPERmsfVsryEYM?=
 =?iso-8859-1?Q?cJzrNzdW0iz1tiqJ4wzJxEZhP4lJXqZHEaUkZqzAr33f2duFQzB08pevha?=
 =?iso-8859-1?Q?Aui89I1TYlahVYT7gmxH2CPknC7PbOxnQuN2HF35yqapcgEZT34M8Oba1h?=
 =?iso-8859-1?Q?9lGhUpS7XTqPC93weHAW5VPfZWtcJY7hLtOhD1yODDffs5IriXNpGwVjyN?=
 =?iso-8859-1?Q?UG64KkGzMHB5Z+9mwqrhGaKIiRPwU2hysxymmTiLxvu7SecsvYf0psJlKp?=
 =?iso-8859-1?Q?B+B5smKwUxJacqXVVnLZ8FOJK0fVeSxGqenST1OXwe65FMBn+YC//GFVb4?=
 =?iso-8859-1?Q?RWyGKRlnVieYpVlPSJhVCVU2ScFTx+j43GlKrf7LQGlsTYFUIVs3Xm2o4Y?=
 =?iso-8859-1?Q?QJb7CCNesJWvwqxEBlJDY1PU1JPZExa4kuqVEYukn7J0nb6vbd/IfiiHf/?=
 =?iso-8859-1?Q?DFtKLo2w4qt2ul7fuc042F1DDuo1yHmQMinqXmkPkH8NiSs8Oo4rfVAKa9?=
 =?iso-8859-1?Q?bRbkAzlrQ29BkpJZ9tBahxZEqR6ymRBK2Lzogu4MJXnGNmYFvC4iQl9PUT?=
 =?iso-8859-1?Q?XgbQSsvdOmjVwrQwtJXmxq9xcB/If0H/0qY64KPioRNjNWRSOxvsGoy45i?=
 =?iso-8859-1?Q?jEN7x3KRXG8+iVjR+/50ASie17QY1U2rZ848hqYHeo3AfxYMsm7yCEbhGv?=
 =?iso-8859-1?Q?32bs8TEwDLCmt9cCTCHEZlIt+WEUIv+2CxpH3xhi5Tb55179WpBizLH+jY?=
 =?iso-8859-1?Q?NYpIg8yxFzMyM/iNv84fvRwiHN3l2SwhJ+XNYxdcjGg8VqOOkDs3q4LCLd?=
 =?iso-8859-1?Q?7/l4u9K28NfHh52pHo95VD5G4TpB4f38RdWwUXpoU/RokRg/pJtMBpwSxl?=
 =?iso-8859-1?Q?cqvet2EdiZWM/Igr4BvKyScbhViazuEM3eaKXLyiBfxl9O0lpxOCfsBHHR?=
 =?iso-8859-1?Q?8XvhwyG4srpyLHIOGz8qShJs4IQTiAQ6ahbTh/v70pRth+rR8EaSkAspQ3?=
 =?iso-8859-1?Q?6202Oa4VvJ/kYAflU4ylKu1Y+XTmb0Ydz3e/roWmzPyMSma9oK98K9m3LL?=
 =?iso-8859-1?Q?lGV9gTntaH3xQD5lmLMKWHC+z7rOTf6FQMKDhrEHItc/pnAb14TzsnAB/6?=
 =?iso-8859-1?Q?hV5nLQxxtbgHjZZWfcx2wW1m4u/g7CF3ldgvx9UAFZZ1Hibhm3Ijk08ZBc?=
 =?iso-8859-1?Q?qcY4Mr/8ooIWQpNwBJQyudE28p3KSzaPRh?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0236998b-f49b-4c1c-7794-08dc76b5a3fc
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2024 21:09:29.3745
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oQxRNba2UrgUhoSFThYh9Yxm/R6V6t6vrOa95pp1IS62i6fc07iHVY+DjJAC+5nes9AAfcjqo99F4SIG3585rg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS5PR04MB10020

On Fri, May 17, 2024 at 09:50:55PM +0200, Miquel Raynal wrote:
> Hi Frank,
> 
> Frank.li@nxp.com wrote on Fri, 17 May 2024 15:15:42 -0400:
> 
> > On Fri, May 17, 2024 at 08:36:21PM +0200, Miquel Raynal wrote:
> > > Hi Frank,
> > > 
> > > Frank.Li@nxp.com wrote on Fri, 17 May 2024 14:09:48 -0400:
> > >   
> > > > Add 'fsl,imx8qxp-gpmi-nand' compatible string and clock-names restriction.
> > > > 
> > > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > > ---
> > > >  .../devicetree/bindings/mtd/gpmi-nand.yaml         | 22 ++++++++++++++++++++++
> > > >  1 file changed, 22 insertions(+)
> > > > 
> > > > diff --git a/Documentation/devicetree/bindings/mtd/gpmi-nand.yaml b/Documentation/devicetree/bindings/mtd/gpmi-nand.yaml
> > > > index 021c0da0b072f..f9eb1868ca1f4 100644
> > > > --- a/Documentation/devicetree/bindings/mtd/gpmi-nand.yaml
> > > > +++ b/Documentation/devicetree/bindings/mtd/gpmi-nand.yaml
> > > > @@ -24,6 +24,7 @@ properties:
> > > >            - fsl,imx6q-gpmi-nand
> > > >            - fsl,imx6sx-gpmi-nand
> > > >            - fsl,imx7d-gpmi-nand
> > > > +          - fsl,imx8qxp-gpmi-nand
> > > >        - items:
> > > >            - enum:
> > > >                - fsl,imx8mm-gpmi-nand
> > > > @@ -151,6 +152,27 @@ allOf:
> > > >              - const: gpmi_io
> > > >              - const: gpmi_bch_apb
> > > >  
> > > > +  - if:
> > > > +      properties:
> > > > +        compatible:
> > > > +          contains:
> > > > +            enum:
> > > > +              - fsl,imx8qxp-gpmi-nand
> > > > +    then:
> > > > +      properties:
> > > > +        clocks:
> > > > +          items:
> > > > +            - description: SoC gpmi io clock
> > > > +            - description: SoC gpmi apb clock  
> > > 
> > > I believe these two clocks are mandatory?  
> > 
> > minItems default is equal to items numbers, here is 4. So all 4 clock are
> > mandatory.
> > 
> > Anything wrong here?
> 
> I'd say that the two "bch" clocks are only used if you decide to
> configure the on-host hardware ECC engine and thus are not needed with
> software corrections, but I'm fine keeping the fourth described in all
> cases if that's simpler.
> 
> Also,here the diff just shows that "if we provide a clocks property
> with this compatible, then we need to provide 4 members", I believe the
> "required" property is already filled somewhere with the
> clocks/clock-names properties?

yes, before allOf

required:
..                                                                 
  - clocks                                                                 
  - clock-names                                                            
..

> 
> Thanks,
> Miqu?l