Received-SPF: pass (google.com: domain of linux-kernel+bounces-182667-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240507154459.3950778-1-pbonzini@redhat.com> <20240507154459.3950778-8-pbonzini@redhat.com>
 <ZkVHh49Hn8gB3_9o@google.com> <7c0bbec7-fa5c-4f55-9c08-ca0e94e68f7c@redhat.com>
 <ZkeH8agqiHzay5r9@google.com> <2450ce49-2230-45a2-bc0d-b21071f2cce6@redhat.com>
 <ZkefU_PhjvnaEE7Q@google.com>
In-Reply-To: <ZkefU_PhjvnaEE7Q@google.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Date: Sat, 18 May 2024 00:05:01 +0200
Message-ID: <CABgObfYwxN7yoRUDfYVPb57=p90nUqfW9+y_=Ndeg4oXKaZNQg@mail.gmail.com>
Subject: Re: [PATCH 7/7] KVM: VMX: Introduce test mode related to EPT
 violation VE
To: Sean Christopherson <seanjc@google.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, 
	Isaku Yamahata <isaku.yamahata@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, May 17, 2024 at 8:18=E2=80=AFPM Sean Christopherson <seanjc@google.=
com> wrote:
> > Ok, so it does look like a CPU issue.  Even with the fixes you identifi=
ed, I
> > don't see any other solution than adding scary text in Kconfig, default=
ing
> > it to "n", and adding an also-very-scary pr_err_once("...") the first t=
ime
> > VMPTRLD is executed with CONFIG_KVM_INTEL_PROVE_VE.
>
> I don't think we need to make it super scary, at least not yet.  KVM just=
 needs
> to not kill the VM, which thanks to the BUSY flag is trivial: just resume=
 the guest.
> Then the failure is "just" a WARN, which won't be anywhere near as proble=
matic for
> KVM developers.
>
> If we don't have a resolution by rc6 or so, then maybe consider doing som=
ething
> more drastic?
>
> I agree that it should be off by default though.  And the help text shoul=
d be
> more clear that this intended only for developers and testing environment=
s.
>
> I have a handful of patches, including one to not kill the VM.  I'll try =
to post
> them later today, mostly just need to write changelogs.
>
> diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
> index 75082c4a9ac4..5c22186671e9 100644
> --- a/arch/x86/kvm/Kconfig
> +++ b/arch/x86/kvm/Kconfig
> @@ -98,15 +98,15 @@ config KVM_INTEL
>
>  config KVM_INTEL_PROVE_VE
>          bool "Check that guests do not receive #VE exceptions"
> -        default KVM_PROVE_MMU || DEBUG_KERNEL
> -        depends on KVM_INTEL
> +        depends on KVM_INTEL && KVM_PROVE_MMU
>          help

"depends on KVM_PROVE_MMU" is wrong, I think.  I'd like to keep it
enabled without slowing down too much the VMs, for example.

On the other hand "default DEBUG_KERNEL" is definitely too heavy
with these CPU issues.

Paolo