Received-SPF: pass (google.com: domain of linux-kernel+bounces-182683-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <f2cfac67-c793-4f47-b390-2b4fff21ff5e@linaro.org>
Date: Sat, 18 May 2024 00:13:09 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] dmaengine: qcom: gpi: remove unused struct 'reg_info'
To: "Dr. David Alan Gilbert" <linux@treblig.org>
Cc: Frank.li@nxp.com, vkoul@kernel.org, linux-arm-msm@vger.kernel.org,
 dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240516152537.262354-1-linux@treblig.org>
 <39b66355-f67e-49e9-a64b-fdd87340f787@linaro.org>
 <Zkc69sMlwawV8Z7l@gallifrey> <Zkc9J4vbQdeCmTpO@gallifrey>
 <3fe6e86d-5b4d-4b3c-a5d7-59f01dc6b0bc@linaro.org>
 <Zkfidbh3Sqy6BEDh@gallifrey>
Content-Language: en-US
From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
In-Reply-To: <Zkfidbh3Sqy6BEDh@gallifrey>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 18/05/2024 00:04, Dr. David Alan Gilbert wrote:
> * Bryan O'Donoghue (bryan.odonoghue@linaro.org) wrote:
>> On 17/05/2024 12:19, Dr. David Alan Gilbert wrote:
>>>> If you look at the V1 I had
>>>> ''gpi_desc' seems like it was never used.
>>>> Remove it.'
>>>>
>>>> but Frank suggested copying the subject line; so I'm not sure
>>>> whether you want more or less!
>>>>
>>>> I could change this to:
>>>>
>>>> 'gpi_desc' was never used since it's initial
>>>> commit 5d0c3533a19f ("dmaengine: qcom: Add GPI dma driver")
>>> Oops, of course I mean 'reg_info' which is what I fixed in v2.
>>>
>>>> Would you be OK with that?
>>> Dave
>>>
>>>> Dave
>>
>> Hi Dave,
>>
>> I saw your v1 interaction after commenting but, I still think commits that
>> say "this removes a data structure" should elaborate more.
>>
>> "This structure is no longer used since commit: 12charsubshahere" or "This
>> structure was never used and should be considered dead code"
>>
>> I generally hope the intention of my commits is clear from the code with the
>> commit log adding whatever context or elaboration on top.
>>
>> So that's what I'm suggesting here. A bit of commit log sugar on top which
>> elaborates on and justifies the change.
> 
> OK, so how about the version I suggested above:
> 
>   'reg_info' was never used since it's initial
>   commit 5d0c3533a19f ("dmaengine: qcom: Add GPI dma driver")
>   Remove it.
> 
> Is that OK with you?
> 
> Dave
> 
>>
>> ---
>> bod
>>

LGTM

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>