Received-SPF: pass (google.com: domain of linux-kernel+bounces-182704-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 17 May 2024 23:41:16 +0000
From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: Frank.li@nxp.com, vkoul@kernel.org, linux-arm-msm@vger.kernel.org,
	dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dmaengine: qcom: gpi: remove unused struct 'reg_info'
Message-ID: <ZkfrHAxINJTWo6Pk@gallifrey>
References: <20240516152537.262354-1-linux@treblig.org>
 <39b66355-f67e-49e9-a64b-fdd87340f787@linaro.org>
 <Zkc69sMlwawV8Z7l@gallifrey>
 <Zkc9J4vbQdeCmTpO@gallifrey>
 <3fe6e86d-5b4d-4b3c-a5d7-59f01dc6b0bc@linaro.org>
 <Zkfidbh3Sqy6BEDh@gallifrey>
 <f2cfac67-c793-4f47-b390-2b4fff21ff5e@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <f2cfac67-c793-4f47-b390-2b4fff21ff5e@linaro.org>
User-Agent: Mutt/2.2.12 (2023-09-09)

* Bryan O'Donoghue (bryan.odonoghue@linaro.org) wrote:
> On 18/05/2024 00:04, Dr. David Alan Gilbert wrote:
> > * Bryan O'Donoghue (bryan.odonoghue@linaro.org) wrote:
> > > On 17/05/2024 12:19, Dr. David Alan Gilbert wrote:
> > > > > If you look at the V1 I had
> > > > > ''gpi_desc' seems like it was never used.
> > > > > Remove it.'
> > > > > 
> > > > > but Frank suggested copying the subject line; so I'm not sure
> > > > > whether you want more or less!
> > > > > 
> > > > > I could change this to:
> > > > > 
> > > > > 'gpi_desc' was never used since it's initial
> > > > > commit 5d0c3533a19f ("dmaengine: qcom: Add GPI dma driver")
> > > > Oops, of course I mean 'reg_info' which is what I fixed in v2.
> > > > 
> > > > > Would you be OK with that?
> > > > Dave
> > > > 
> > > > > Dave
> > > 
> > > Hi Dave,
> > > 
> > > I saw your v1 interaction after commenting but, I still think commits that
> > > say "this removes a data structure" should elaborate more.
> > > 
> > > "This structure is no longer used since commit: 12charsubshahere" or "This
> > > structure was never used and should be considered dead code"
> > > 
> > > I generally hope the intention of my commits is clear from the code with the
> > > commit log adding whatever context or elaboration on top.
> > > 
> > > So that's what I'm suggesting here. A bit of commit log sugar on top which
> > > elaborates on and justifies the change.
> > 
> > OK, so how about the version I suggested above:
> > 
> >   'reg_info' was never used since it's initial
> >   commit 5d0c3533a19f ("dmaengine: qcom: Add GPI dma driver")
> >   Remove it.
> > 
> > Is that OK with you?
> > 
> > Dave
> > 
> > > 
> > > ---
> > > bod
> > > 
> 
> LGTM
> 
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

Thanks, v3 sent and copied to you with that RB added.

Dave

-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/