Received-SPF: pass (google.com: domain of linux-kernel+bounces-182742-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 17 May 2024 18:47:00 -0700
From: Josh Poimboeuf <jpoimboe@kernel.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: x86@kernel.org, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: select ARCH_WANT_FRAME_POINTERS again when
 UNWINDER_FRAME_POINTER=y
Message-ID: <20240518014700.3aieomeev4s4rq3a@treble>
References: <20240204122003.53795-1-masahiroy@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20240204122003.53795-1-masahiroy@kernel.org>

On Sun, Feb 04, 2024 at 09:20:03PM +0900, Masahiro Yamada wrote:
> It took me some time to understand the purpose of the tricky code at
> the end of arch/x86/Kconfig.debug.
> 
> Without it, the following would be shown:
> 
>   WARNING: unmet direct dependencies detected for FRAME_POINTER
> 
> because commit 81d387190039 ("x86/kconfig: Consolidate unwinders into
> multiple choice selection") removed 'select ARCH_WANT_FRAME_POINTERS'.
> 
> The correct and more straightforward approach should have been to move
> it where 'select FRAME_POINTER' is located.
> 
> Several architectures properly handle the conditional selection of
> ARCH_WANT_FRAME_POINTERS. For example, 'config UNWINDER_FRAME_POINTER'
> in arch/arm/Kconfig.debug.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

Looks good, thanks for fixing that!

Fixes: 81d387190039 ("x86/kconfig: Consolidate unwinders into multiple choice selection")
Acked-by: Josh Poimboeuf <jpoimboe@kernel.org>

-- 
Josh