Received-SPF: pass (google.com: domain of linux-kernel+bounces-182759-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Stephen Brennan <stephen.s.brennan@oracle.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
        Masami Hiramatsu
 <mhiramat@kernel.org>
Cc: Andrii Nakryiko <andrii@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
        Jonathan Haslam <jonathan.haslam@gmail.com>,
        Kui-Feng Lee
 <thinker.li@gmail.com>, Ye Bin <yebin10@huawei.com>,
        Steven Rostedt
 <rostedt@goodmis.org>, linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] probes updates for v6.10
In-Reply-To: <CAHk-=wgQ_MNipb2fOSDmXJ9tYko8OhzA0fPueR-kh6eYT_MbDg@mail.gmail.com>
References: <20240516095216.ac9a0fd13357450cc5f2e491@kernel.org>
 <CAHk-=wgQ_MNipb2fOSDmXJ9tYko8OhzA0fPueR-kh6eYT_MbDg@mail.gmail.com>
Date: Fri, 17 May 2024 19:23:33 -0700
Message-ID: <878r07q2my.fsf@oracle.com>
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?t2U8IKDKhxQtpThXjeAs9fsXg7CIP8Oe3vZkws/D5WVS1FwGju/MPc3wcBqS?=
 =?us-ascii?Q?XmwfwNCTle6xu46m+uv3EKXwuiQzFUcHwziYoOVhAm5h6Z19rQAuZWR9S44Y?=
 =?us-ascii?Q?yONakdAYrLaOBzim5ZfFO6cxPZxxcpPTwaGiWIjzOerIWdak3Ge7elF0RFne?=
 =?us-ascii?Q?rwZ6R9jrxiAM5tPpt3/Oeiw8s6qXX/QCbOQGW3ugIpxRHpDHieINrnp/Ne5M?=
 =?us-ascii?Q?lUIWyRIwWULJlhO9/taW7LAfEK4U6oms16RpLKH2yQfUSrHHAgeH2+DTH5Ny?=
 =?us-ascii?Q?JAejPNuw/d3AsF8X4Ihxmw3cwbPOeAEq/mUYxid/zAmaWe7taWBN2U+2c9wz?=
 =?us-ascii?Q?OaFURmoJtqgL0KX1SXaQ9Nl8j9SC6rsyeNBEVq0cC2CYO3le7dpBtuJ3r4UE?=
 =?us-ascii?Q?I5S+r3AFjopHK1ogR5RkoLSjWhuvFTPQoupNTDTy7w9ipckmu7t1843Y8sNH?=
 =?us-ascii?Q?mDWGPiLY3IxT8YmmOoSd5XFxcBtTZ8sPC2E3kxxONZ+DNBlNP4kRRIwbYs6E?=
 =?us-ascii?Q?U/5Ah4hBXJfTdVxu+zFeDk0nyCYGXQgp9HX7MmkCQo5ZyMCIU5O1k0lH/WJ1?=
 =?us-ascii?Q?wjDH9gYV7ZSWOnv6ApbWilsRug+MCdMyml37tMBFxHOJ0VTzv8KplBD+Qtwq?=
 =?us-ascii?Q?1H6OvDc3kQNeuijfhvl+Ku1dvTAd2VLVPWzQjo0z9Cig2NSt4vFaeD0s9K6n?=
 =?us-ascii?Q?15tNQeDyK+qq0BtnKdiB6Sq5WvUNL6mS0nX1hpdyqO6TR8Kkn3enZKrDK1tb?=
 =?us-ascii?Q?L1UqLih1FMwny+FFyzHn3DVT5kAddlhlo2H/HshN60Vh8wTf7sWawg3haLf4?=
 =?us-ascii?Q?v5Mq62Wf65HAXjOGChZ3pllWSuBARWU5UA5JMEQw9n2w6JZa1FNV3v85gz30?=
 =?us-ascii?Q?1MgrMiNovSj7cf+fm+KNMFuuPn1dNEC8axN3u80zqga+otLcAvlXAExbawzj?=
 =?us-ascii?Q?JSQEEVLHH1s/wEwnCcOB/Lp8UvXVj3MaEhgF3Jzqhg6yFTn4lv8ywSbscAib?=
 =?us-ascii?Q?6zfWyKSg0MTtn3RYALAX2c+PDiRI2Zz2mnMY2PZBLb/PSaZflQcF6mkv76L+?=
 =?us-ascii?Q?8JICBVw3KB3HhQEbr2sfJMFxNxsJ82bXjBcTSa2AE548G5cHfDFiWUgnJ+iK?=
 =?us-ascii?Q?hPO7bq+Bnq6140PuVwfej5oCHQ29P4uOEPouzcv39s8BmLl8y0ufeA86dBqQ?=
 =?us-ascii?Q?0RoGNUx9NSwsFS4CEUZhGvTNjcq2MxnuJvEwxqQ/AM5jOd2mQrhOs9ZIOc3B?=
 =?us-ascii?Q?T6WXuVNYLRRixLC/d7otqpnbZZWefY0oEI9PCR6tUkKCPC+Mrc97ZLEFgfM7?=
 =?us-ascii?Q?n9mY3sAkd67WIK0ZDPCUJolJw1+5HfMQmdFAgbKZ63KLit9pbKLq9+88t/L8?=
 =?us-ascii?Q?WBCXsAbvGXVF1/+hQuSWQDX0C/nv7ukNIeIMucCWGH+gyv8nKZd3MV0LMGlh?=
 =?us-ascii?Q?61D/49eBgiQIj4nS6XefzHfTYVJOZyl2yo5nJ2hfCXcXUSCKBkg8BSprzdHQ?=
 =?us-ascii?Q?JyHiF/xAJCJy0VB1cM5wZEfrMtQx4IT+sGzaoTuJhXjsbb7B2WmWM1TBt3aP?=
 =?us-ascii?Q?qiShhen9Lz5TfMXO+q710TgaPWOrDM5Gp3GHAryzz15zJ6ZClh6VmEaRw+Fi?=
 =?us-ascii?Q?7hFvXpyZ/7wrD1Q9jHOiTT11S/n2lfRPuYNzNBUcIJQSELAPTgbUOvBccB5Z?=
 =?us-ascii?Q?KErqAw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	h4SyrnC9ON20DnDM1Zb3fKF4oh3Pp8KcNowzT9BCJrrnbtOOMDfeyshcJ2/QjkckfRMe7ePoRfqW6eRzBngES2H9iwXX1BnNqxylRGIuHtTOmYuYUVnGzxW1c8Hq/k0ISuBeXX2B4/TMyGCuIDjlz+spL3CXxGw1CR8EEBRX+ncYU9+6EceglQyVgGcdCnB+emTrppXra0rDSr9bHrHKmHsuijtqJhFbFMj5Rqtv6T1bXACXgzI/oLZ+dVa++WQud6rEs5w9ex688aH4PJwpCCSYIKQKftuLznjns70govDXFRVR6SMiF68zvH7dL6l8KqYsDl1p5VeXS52u5xLHowj5LlDorz7yMNaQEjSKtUGt6r6Bh8gau8krbpmx0oSZ3aTOLVDcXLc0YOhIR3h7qIw1YsqRet3p+ghpBwqG8hLQYmBrVttiH29/sr2MoJPVpnX755gV9DrWWy9d3DATVBMhr9eIWdH1lIoUuN9DYpYfGc/iMG4TaQ+eaI7YieHGZInwc9Cm3JQ7lZBnWjAYyK7RZsGsdK+3P0I3p/OPsUkAN0XU19aHcmtH/8XUIbMzJIzjBBK6adSJmRtnIa4GlVe/f2CDMSDra1ERpnfN+mA=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 67fbb638-f7f6-4847-4c07-08dc76e184b8
X-MS-Exchange-CrossTenant-AuthSource: PH8PR10MB6597.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2024 02:23:34.7506
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GFB5vtcAfRJLh8f+eMNlQYK8MFCiJwQJXwDP894Mv2S3unEu1YPDB5gKRXnkMurJnnPd+PFsVgEM54HCJ4gGuBW6t0uz08wOAcIxzo8n8Ho=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB4864
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-05-17_13,2024-05-17_03,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 spamscore=0
 adultscore=0 mlxlogscore=999 malwarescore=0 suspectscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2405180019
X-Proofpoint-GUID: i6VcewvSrws1_CAjZMnYo-UYV-QabQOV
X-Proofpoint-ORIG-GUID: i6VcewvSrws1_CAjZMnYo-UYV-QabQOV

Linus Torvalds <torvalds@linux-foundation.org> writes:

> On Wed, 15 May 2024 at 17:52, Masami Hiramatsu <mhiramat@kernel.org> wrote:
>>
>> Probes updates for v6.10:
>
> Grr,
>
> This doesn't even build right.
>
> Yes, it builds cleanly in an allmoconfig build, which is what I did
> before I pushed out.
>
> But after pushing out, I notice that it doesn't build in more limited
> configurations and with clang, because:
>
>> Stephen Brennan (1):
>>       kprobe/ftrace: bail out if ftrace was killed
>
> This is no longer valid C code, and hasn't been for a long long while:
>
>     void kprobe_ftrace_kill()
>     {
>         kprobe_ftrace_disabled = true;
>     }
>
> we require proper prototypes, not some ancient per-ANSI K&R syntax.
>
> It turns out that gcc apparently still accepts these things, but it
> really shouldn't. But with a clang build, you get a big error:
>
>     kernel/kprobes.c:1140:24: error: a function declaration without a
> prototype is deprecated in all versions of C
> [-Werror,-Wstrict-prototypes]
>
> and the reason it didn't get noticed in -next is that this commit had
> apparently not *been* in linux-next.
>
> Dammit, that's now how any of this is supposed to work.
>
> Why was this untested crap sent to me?

Hi Linus,

Yes, this was may fault for missing "(void)", that's basic and shouldn't
have gone out. I was too focused on getting a prototype for each
possible configuration that I couldn't see the forest for the trees!

My GCC builds were not W=1, which I will do next time. I would have seen
this with a W=1 build. I can't speak for why it wasn't in -next, but it
did get caught yesterday and I sent a fix:

https://lore.kernel.org/oe-kbuild-all/202405170340.eyEMhYvc-lkp@intel.com/

My apologies.

-Stephen