Received-SPF: pass (google.com: domain of linux-kernel+bounces-182780-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <b2537aa6-4c00-4c47-862a-0e706ebbf305@gmail.com>
Date: Sat, 18 May 2024 15:00:41 +0900
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] line6: add midibuf init failure handling in
 line6_init_midi()
To: Takashi Iwai <tiwai@suse.de>
Cc: Jaroslav Kysela <perex@perex.cz>, skhan@linuxfoundation.org,
 Bjorn Helgaas <helgaas@kernel.org>,
 linux-kernel-mentees@lists.linuxfoundation.org,
 Austin Kim <austindh.kim@gmail.com>, shjy180909@gmail.com,
 linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240516174737.415912-1-yskelg@gmail.com>
 <8734qg260i.wl-tiwai@suse.de>
 <a258b613-3697-4f21-a8fd-20b276f63132@gmail.com>
 <871q608gz7.wl-tiwai@suse.de>
Content-Language: en-US
From: Yunseong Kim <yskelg@gmail.com>
In-Reply-To: <871q608gz7.wl-tiwai@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit


On 5/18/24 2:51 오전, Takashi Iwai wrote:
> On Fri, 17 May 2024 19:10:44 +0200,
> Yunseong Kim wrote:
>>
>> On 5/17/24 5:32 오후, Takashi Iwai wrote:
>>> The allocated object is already freed by snd_line6_midi_free() that is
>>> called via rawmidi private_free at its destruction.  So your change
>>> would lead to a double-free.
>>>
>>>
>>> thanks,
>>>
>>> Takashi
>>
>> Thanks for the review Takashi.
>>
>> I have one question:
>>
>> line6_midibuf_destroy() have no NULL check for the memory to free.
>>
>> If line6midi->midibuf_in is in this->buf = NULL from
>> line6_midibuf_init() with memory allocation failed,
>> won't the free(NULL) when accessed by snd_line6_midi_free() to
>> line6_midibuf_destroy()?
> 
> free(NULL) is fine, it's defined to be noop.
> Many codes just call free() unconditionally for that, as it reduces
> the code size.
> 
> 
> thanks,
> 
> Takashi

Thak you Takashi, I've been studying the kfree behavior in detail since
you mentioned it, so thanks for advicing the details.

Warm Regards,
Yunseong Kim

>>
>>>> ---
>>>>  sound/usb/line6/midi.c | 9 +++++++--
>>>>  1 file changed, 7 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/sound/usb/line6/midi.c b/sound/usb/line6/midi.c
>>>> index 0838632c788e..abcf58f46673 100644
>>>> --- a/sound/usb/line6/midi.c
>>>> +++ b/sound/usb/line6/midi.c
>>>> @@ -283,13 +283,18 @@ int line6_init_midi(struct usb_line6 *line6)
>>>>  
>>>>  	err = line6_midibuf_init(&line6midi->midibuf_in, MIDI_BUFFER_SIZE, 0);
>>>>  	if (err < 0)
>>>> -		return err;
>>>> +		goto error;
>>>>  
>>>>  	err = line6_midibuf_init(&line6midi->midibuf_out, MIDI_BUFFER_SIZE, 1);
>>>>  	if (err < 0)
>>>> -		return err;
>>>> +		goto error;
>>>>  
>>>>  	line6->line6midi = line6midi;
>>>>  	return 0;
>>>> +
>>>> +error:
>>>> +	kfree(line6midi);
>>>> +	return err;
>>>> +
>>>>  }
>>>>  EXPORT_SYMBOL_GPL(line6_init_midi);
>>>> -- 
>>>> 2.34.1
>>>>