Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp1508805lqo; Sat, 18 May 2024 06:21:34 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVoOAbGtTlcJHZb1Cbf3sSQ/rn7N09Pg7otnp/5becwSNabeaq7huvwXuLIEaqZRbkKNsq76NyEh1j4XQGAqpewoHqd7t4vcPu5j/uoYw== X-Google-Smtp-Source: AGHT+IFpXIbH1HyWlB1KADlNmqkhyU7S/aBFjAFNxK5QerGwOAm+uyyGP/DVw1RniDFl+/V60Y/p X-Received: by 2002:a50:8a91:0:b0:571:bf62:81ce with SMTP id 4fb4d7f45d1cf-5752b47fe5fmr1384485a12.9.1716038494238; Sat, 18 May 2024 06:21:34 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716038494; cv=pass; d=google.com; s=arc-20160816; b=SX+Nelnh6EE3j/29wHvTcyJjPFtKro/8BLvmlBrUF0OiP/0IKZnZpM08hSc0q9Ij5q zhgvOOPu/jDtgKzNqG+KvUtEYveRUUhBsAQXu1tzQ1ynWwIyzr6nivfo6c9CoA93Bjv9 TPBpl8itAeFwYg9RITV07pfWt8WODizbL7jp2i98JN6B1hMt/fVzg9ETNBv2Kv5Yx18H eRGruO0DhNJOk/9HAjEQAyIllC/HmZ1Xh/s9CkpO0zmWL3v8ihHN3NCbBWOgMmAyBd+p 0I1RbBo2gFbnlT0n4YkS2fWCiSqGjGC69vJ43wX/WCja4837PU+582ZlU3XoLZ7VRADx pvjA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=X+XZkADxoXZ0DB7eXEnh8J7Qynp6Huw6DX79kn85yPs=; fh=QmptZ6IeRMU6PbYeng89dT20LsR1GjwpKZbzhbdnSB0=; b=rzcPRuWIe4VbS2HilfGq/G6bhQHUcVXlzQeOdBOmELLs/r9BniWgYFHGqFUHf0XkS5 JBbcqHEGyctBj3dyLm9B7YbP3jifPdC06SG5JjEzlqX9DZU3eW3z/oGzC+Th6hrey08F cy0A9AsrZS9vIKO6YN+AxUKLbZIySV+YZC5v4EChqxsA954LzrHFVucxJzGpbYUlPLvZ zeNN6++puo/DHUE2WxO+XPsnyITu9+9pCh60OxCz7ZssZ05sAual5C+ZDfGyLAKEvcwA aJ8y9razMs4UCSCD0NDLeZ/2oIfaHcI87vcq6mf1HFrUFnKf5G/6FyMMxt5LBXsQ0OhS kGsA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=S66wiEfv; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-182886-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-182886-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-5733c32cf4bsi10990510a12.465.2024.05.18.06.21.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 May 2024 06:21:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-182886-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=S66wiEfv; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-182886-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-182886-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id CD99B1F21A95 for ; Sat, 18 May 2024 13:21:33 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 550D63F8E2; Sat, 18 May 2024 13:21:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="S66wiEfv" Received: from out-175.mta1.migadu.com (out-175.mta1.migadu.com [95.215.58.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 191A11F5FA for ; Sat, 18 May 2024 13:21:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716038487; cv=none; b=XRmZ0uNT6u2MEkwML395CvYN9uZOsUeMTapb4uwICYWVC+qFLvUwjarmyeAJD93t8qSIz+71o1XcvxReMOmrjV3Xpazz8dl5OyiHClcNO76xqLxiP9JJYQG5ob3//s/4ypsakl66tzPTXTqOIM6Z4sCg91iixaYE1JiGSCeo8bs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716038487; c=relaxed/simple; bh=u16OiIWEx6HPEvJpf14r5jR3yHhHV19bMmlM9Nj+PzE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MFFsiNwGRTxAXAjuvbYFjXHzgnYy65fr3canQGsVx7gDfMCOW4XcCdSp1bEoea2gJidJDTlwLp/0h87nDGkNwep1WPkYxSIAtdQzEJOiKPxWgr0eCYsUS+/MXVByZHSAiPDY7zC7ei46urt9y9e0dH6AZeT/eEY57ti4bWRzGZw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=S66wiEfv; arc=none smtp.client-ip=95.215.58.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev X-Envelope-To: dianders@chromium.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1716038482; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X+XZkADxoXZ0DB7eXEnh8J7Qynp6Huw6DX79kn85yPs=; b=S66wiEfvqu+Giau5N20Bp+EzLh/9Y40AGsIcGADEZGBt7DQeJIL8QaoHPqIfqUQ9dom6cz isvbfaoC4axdfx3QKGAdjkziRQGgihnQqMSOYvsiC/D1FAa/l1sHSZCe1MSenL/M/gC/ZL v+HdEJaDAUqD6CfwqKmDRyPiADR+MS4= X-Envelope-To: dri-devel@lists.freedesktop.org X-Envelope-To: mripard@kernel.org X-Envelope-To: linus.walleij@linaro.org X-Envelope-To: macromorgan@hotmail.com X-Envelope-To: yuran.pereira@hotmail.com X-Envelope-To: neil.armstrong@linaro.org X-Envelope-To: daniel@ffwll.ch X-Envelope-To: airlied@gmail.com X-Envelope-To: quic_jesszhan@quicinc.com X-Envelope-To: maarten.lankhorst@linux.intel.com X-Envelope-To: sam@ravnborg.org X-Envelope-To: tzimmermann@suse.de X-Envelope-To: linux-kernel@vger.kernel.org Message-ID: Date: Sat, 18 May 2024 21:20:52 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [RFT,v2,26/48] drm/panel: simple: Stop tracking prepared/enabled To: Douglas Anderson , dri-devel@lists.freedesktop.org, Maxime Ripard Cc: Linus Walleij , Chris Morgan , Yuran Pereira , Neil Armstrong , Daniel Vetter , David Airlie , Jessica Zhang , Maarten Lankhorst , Sam Ravnborg , Thomas Zimmermann , linux-kernel@vger.kernel.org References: <20240503143327.RFT.v2.26.I865be97dd393d6ae3c3a3cd1358c95fdbca0fe83@changeid> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sui Jingfeng In-Reply-To: <20240503143327.RFT.v2.26.I865be97dd393d6ae3c3a3cd1358c95fdbca0fe83@changeid> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT Hi, On 2024/5/4 05:33, Douglas Anderson wrote: > As talked about in commit d2aacaf07395 ("drm/panel: Check for already > prepared/enabled in drm_panel"), we want to remove needless code from > panel drivers that was storing and double-checking the > prepared/enabled state. Even if someone was relying on the > double-check before, that double-check is now in the core and not > needed in individual drivers. I think you are right, as I see drm_panel already has embed the 'prepared' and 'enabled' as members, remove them from the derived structure could probably save memory footprint. Reducing boilerplate is also a side benefit. > Signed-off-by: Douglas Anderson Acked-by: Sui Jingfeng -- Best regards, Sui